diff options
| author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-07 21:41:50 +0000 |
|---|---|---|
| committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-07 21:41:50 +0000 |
| commit | 807cb1036f557b8e24306c66a6bac9bfb0c804af (patch) | |
| tree | b10af2181ae1e2ce1640f868a217a868332ecc3e /chrome/browser/renderer_host/browser_render_process_host.h | |
| parent | 462474b9444dcda47b5c140f5d31b790610b6176 (diff) | |
| download | chromium_src-807cb1036f557b8e24306c66a6bac9bfb0c804af.zip chromium_src-807cb1036f557b8e24306c66a6bac9bfb0c804af.tar.gz chromium_src-807cb1036f557b8e24306c66a6bac9bfb0c804af.tar.bz2 | |
Relanding the language detection code.
The code would crash if multiple PageContents notifications
were received rapidly. The CLDHelper now notifies the
TabContents directly and the TabContents ensures only one
language detection can be performed at a time.
Added unit-tests to validate these cases in web_contents_unittest.cc.
Note that patch set 1 is the original patch, patch set 2 contains the new changes.
Original review:
http://codereview.chromium.org/492024/show
BUG=30662
TEST=Run the unit-tests.
Review URL: http://codereview.chromium.org/504051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35735 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/renderer_host/browser_render_process_host.h')
| -rw-r--r-- | chrome/browser/renderer_host/browser_render_process_host.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/chrome/browser/renderer_host/browser_render_process_host.h b/chrome/browser/renderer_host/browser_render_process_host.h index 3a6e83b..0fd51ea 100644 --- a/chrome/browser/renderer_host/browser_render_process_host.h +++ b/chrome/browser/renderer_host/browser_render_process_host.h @@ -104,8 +104,6 @@ class BrowserRenderProcessHost : public RenderProcessHost, friend class VisitRelayingRenderProcessHost; // Control message handlers. - void OnPageContents(const GURL& url, int32 page_id, - const std::wstring& contents); void OnUpdatedCacheStats(const WebKit::WebCache::UsageStats& stats); void SuddenTerminationChanged(bool enabled); void OnExtensionAddListener(const std::string& event_name); |