diff options
| author | suzhe@chromium.org <suzhe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-01 04:49:06 +0000 |
|---|---|---|
| committer | suzhe@chromium.org <suzhe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-01 04:49:06 +0000 |
| commit | ad53baa575a30701cf26e77d748252c010fb96ab (patch) | |
| tree | 168fccfcfe9852812f34c0675fdc8b0656cb6af5 /chrome/browser/renderer_host/render_widget_host_view_gtk.cc | |
| parent | 29bba6f380ab785dc70d0632b62e98b47f5f4763 (diff) | |
| download | chromium_src-ad53baa575a30701cf26e77d748252c010fb96ab.zip chromium_src-ad53baa575a30701cf26e77d748252c010fb96ab.tar.gz chromium_src-ad53baa575a30701cf26e77d748252c010fb96ab.tar.bz2 | |
[Linux]Improve keyboard event handling code of RWHV.
Just like what Mac port already did, this CL changes the method to determine if a keyboard event should be processed by the browser to use a boolean field instead of setting the keyval of os_event to GDK_VoidSymbol. Because in some cases, GDK_VoidSymbol might be valid key value, for example ctrl-b on Arabic keyboard.
BUG=35117 Emacs key binding ctrl-b doesn't work in web page when using Arabic keyboard layout.
TEST=Enable Emacs key theme and switch to Arabic keyboard layout, then try ctrl-b (move cursor backwards) in web page's text area.
Review URL: http://codereview.chromium.org/661149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40255 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/renderer_host/render_widget_host_view_gtk.cc')
| -rw-r--r-- | chrome/browser/renderer_host/render_widget_host_view_gtk.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/browser/renderer_host/render_widget_host_view_gtk.cc b/chrome/browser/renderer_host/render_widget_host_view_gtk.cc index 338e960..a5792b4 100644 --- a/chrome/browser/renderer_host/render_widget_host_view_gtk.cc +++ b/chrome/browser/renderer_host/render_widget_host_view_gtk.cc @@ -815,7 +815,8 @@ void RenderWidgetHostViewGtk::ForwardKeyboardEvent( return; EditCommands edit_commands; - if (key_bindings_handler_->Match(event, &edit_commands)) { + if (!event.skip_in_browser && + key_bindings_handler_->Match(event, &edit_commands)) { host_->ForwardEditCommandsForNextKeyEvent(edit_commands); } host_->ForwardKeyboardEvent(event); |