Attempt at fixing bug 24248 with a workaround.

This is a similar fix to what eroman did previously.
We NULL render_widget_host_ when it's deleted, so we do not call it if it's been destroyed.
Added a bunch of check for render_widget_host_ before using it, as eroman changes triggered some crashers with some windows messages somehow happening after render_widget_host_ was NULLed.
Also added a NOTREACHED when the RenderWidgetHostViewWin OnFinalMessage is called and the destruction has not been initiated by the render view host, but it's gone, in an attempt to understand how this crasher can happen.
More info is available in the bug comments.

BUG=24248
TEST=Make sure opening/closing tab works as expected.
     Test that selects (for example the language on under
     http://www.google.com/advanced_search?hl=en can be open,
     closed, selected.

Review URL: http://codereview.chromium.org/338054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30398 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 1 insertions, 0 deletions

diff --git a/chrome/browser/renderer_host/render_widget_host_view_mac.h b/chrome/browser/renderer_host/render_widget_host_view_mac.h
index 38edca2..99a9d47 100644
--- a/chrome/browser/renderer_host/render_widget_host_view_mac.h
+++ b/chrome/browser/renderer_host/render_widget_host_view_mac.h
@@ -103,6 +103,7 @@ class RenderWidgetHostViewMac : public RenderWidgetHostView {
   virtual void DidPaintRect(const gfx::Rect& rect);
   virtual void DidScrollRect(const gfx::Rect& rect, int dx, int dy);
   virtual void RenderViewGone();
+  virtual void WillDestroyRenderWidget(RenderWidgetHost* rwh) {};
   virtual void Destroy();
   virtual void SetTooltipText(const std::wstring& tooltip_text);
   virtual BackingStore* AllocBackingStore(const gfx::Size& size);