diff options
author | dbeam@chromium.org <dbeam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-12-20 02:50:45 +0000 |
---|---|---|
committer | dbeam@chromium.org <dbeam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-12-20 02:50:45 +0000 |
commit | c4991f239998abe4a577be06c4419666c85556cd (patch) | |
tree | 33cff918c80bc3333f095886a4d0ca0981cd9e94 /chrome/browser/resources/file_manager/js | |
parent | 3024571e695e2da3e3caaed51302806b93c8973d (diff) | |
download | chromium_src-c4991f239998abe4a577be06c4419666c85556cd.zip chromium_src-c4991f239998abe4a577be06c4419666c85556cd.tar.gz chromium_src-c4991f239998abe4a577be06c4419666c85556cd.tar.bz2 |
[web_dev_style] (Boolean|Number|String) -> (boolean|number|string) and add
presubmit check.
BUG=113202
TEST=chrome/browser/resources/test_presubmit.py
Review URL: https://codereview.chromium.org/11628003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174083 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/resources/file_manager/js')
11 files changed, 24 insertions, 24 deletions
diff --git a/chrome/browser/resources/file_manager/js/commandbutton.js b/chrome/browser/resources/file_manager/js/commandbutton.js index 4ba18eb..f550f421 100644 --- a/chrome/browser/resources/file_manager/js/commandbutton.js +++ b/chrome/browser/resources/file_manager/js/commandbutton.js @@ -46,7 +46,7 @@ CommandButton.prototype.getCommand = function() { /** * Associates command with this button. - * @param {String|cr.ui.Command} command Command id, or command object to + * @param {string|cr.ui.Command} command Command id, or command object to * associate with this button. */ CommandButton.prototype.setCommand = function(command) { @@ -78,7 +78,7 @@ CommandButton.prototype.setCommand = function(command) { /** * Returns button label - * @return {String} Button label. + * @return {string} Button label. */ CommandButton.prototype.getLabel = function() { return this.textContent; diff --git a/chrome/browser/resources/file_manager/js/default_action_dialog.js b/chrome/browser/resources/file_manager/js/default_action_dialog.js index 71c223e..3f4fc7a 100644 --- a/chrome/browser/resources/file_manager/js/default_action_dialog.js +++ b/chrome/browser/resources/file_manager/js/default_action_dialog.js @@ -81,8 +81,8 @@ cr.define('cr.filebrowser', function() { /** * Shows dialog. * - * @param {String} title Title in dialog caption. - * @param {String} message Message in dialog caption. + * @param {string} title Title in dialog caption. + * @param {string} message Message in dialog caption. * @param {Array} items Items to render in list * @param {int} defaultIndex Item to select by default. * @param {Function} onOk Callback function. diff --git a/chrome/browser/resources/file_manager/js/file_manager.js b/chrome/browser/resources/file_manager/js/file_manager.js index 29140d4..5be562b 100644 --- a/chrome/browser/resources/file_manager/js/file_manager.js +++ b/chrome/browser/resources/file_manager/js/file_manager.js @@ -2600,7 +2600,7 @@ DialogType.isModal = function(type) { /** * Handler invoked on preference setting in gdata context menu. - * @param {String} pref The preference to alter. + * @param {string} pref The preference to alter. * @param {boolean} inverted Invert the value if true. * @param {Event} event The click event. */ diff --git a/chrome/browser/resources/file_manager/js/file_tasks.js b/chrome/browser/resources/file_manager/js/file_tasks.js index 86d3e8f..6febf1c 100644 --- a/chrome/browser/resources/file_manager/js/file_tasks.js +++ b/chrome/browser/resources/file_manager/js/file_tasks.js @@ -46,7 +46,7 @@ FileTasks.prototype.init = function(urls, opt_mimeTypes) { /** * Returns amount of tasks. - * @return {Number=} amount of tasks. + * @return {number=} amount of tasks. */ FileTasks.prototype.size = function() { return (this.tasks_ && this.tasks_.length) || 0; @@ -555,8 +555,8 @@ FileTasks.decorate = function(method) { * Shows modal action picker dialog with currently available list of tasks. * * @param {DefaultActionDialog} actionDialog Action dialog to show and update. - * @param {String} title Title to use. - * @param {String} message Message to use. + * @param {string} title Title to use. + * @param {string} message Message to use. * @param {function(Object)} onSuccess Callback to pass selected task. */ FileTasks.prototype.showTaskPicker = function(actionDialog, title, message, diff --git a/chrome/browser/resources/file_manager/js/image_editor/exif_encoder.js b/chrome/browser/resources/file_manager/js/image_editor/exif_encoder.js index 4b330f4..e49aee0 100644 --- a/chrome/browser/resources/file_manager/js/image_editor/exif_encoder.js +++ b/chrome/browser/resources/file_manager/js/image_editor/exif_encoder.js @@ -130,7 +130,7 @@ ExifEncoder.prototype.setThumbnailData = function(canvas, quality) { /** * Return a range where the metadata is (or should be) located. - * @param {String} encodedImage Raw image data to look for metadata. + * @param {string} encodedImage Raw image data to look for metadata. * @return {Object} An object with from and to properties. */ ExifEncoder.prototype.findInsertionRange = function(encodedImage) { @@ -268,7 +268,7 @@ ExifEncoder.prototype.encode = function() { * @param {Object} directory A directory map as created by ExifParser. * @param {Array} resolveLater An array of tag ids for which the values will be * resolved later. - * @param {String} nextDirPointer A forward key for the pointer to the next + * @param {string} nextDirPointer A forward key for the pointer to the next * directory. If omitted the pointer is set to 0. */ ExifEncoder.encodeDirectory = function( @@ -507,7 +507,7 @@ ByteWriter.prototype.writeScalar = function(value, width, opt_signed) { /** * Writes string. - * @param {String} str String to write. + * @param {string} str String to write. */ ByteWriter.prototype.writeString = function(str) { this.validateWrite(str.length); diff --git a/chrome/browser/resources/file_manager/js/image_editor/image_buffer.js b/chrome/browser/resources/file_manager/js/image_editor/image_buffer.js index 8d0da59..4cf78aa 100644 --- a/chrome/browser/resources/file_manager/js/image_editor/image_buffer.js +++ b/chrome/browser/resources/file_manager/js/image_editor/image_buffer.js @@ -49,7 +49,7 @@ ImageBuffer.prototype.draw = function() { * @param {number} x X coordinate for cursor. * @param {number} y Y coordinate for cursor. * @param {boolean} mouseDown If mouse button is down. - * @return {String} A value for style.cursor CSS property. + * @return {string} A value for style.cursor CSS property. */ ImageBuffer.prototype.getCursorStyle = function(x, y, mouseDown) { for (var i = this.overlays_.length - 1; i >= 0; i--) { @@ -63,7 +63,7 @@ ImageBuffer.prototype.getCursorStyle = function(x, y, mouseDown) { * Searches for a click handler in the descending Z-order. * @param {number} x X coordinate for click event. * @param {number} y Y coordinate for click event. - * @return {Boolean} True if handled. + * @return {boolean} True if handled. */ ImageBuffer.prototype.onClick = function(x, y) { for (var i = this.overlays_.length - 1; i >= 0; i--) { diff --git a/chrome/browser/resources/file_manager/js/image_editor/image_encoder.js b/chrome/browser/resources/file_manager/js/image_editor/image_encoder.js index 8673fef..54eeb6d 100644 --- a/chrome/browser/resources/file_manager/js/image_editor/image_encoder.js +++ b/chrome/browser/resources/file_manager/js/image_editor/image_encoder.js @@ -51,7 +51,7 @@ ImageEncoder.encodeMetadata = function(metadata, canvas, quality) { * Return a blob with the encoded image with metadata inserted. * @param {HTMLCanvasElement} canvas The canvas with the image to be encoded. * @param {ImageEncoder.MetadataEncoder} metadataEncoder Encoder to use. - * @param {Number} quality (0..1], Encoding quality, defaults to 0.9. + * @param {number} quality (0..1], Encoding quality, defaults to 0.9. * @return {Blob} encoded data. */ ImageEncoder.getBlob = function(canvas, metadataEncoder, quality) { @@ -106,8 +106,8 @@ ImageEncoder.getBlob = function(canvas, metadataEncoder, quality) { * Why return a string? Calling atob and having the rest of the code deal * with a string is several times faster than decoding base64 in Javascript. * - * @param {String} dataURL Data URL to decode. - * @return {String} A binary string (char codes are the actual byte values). + * @param {string} dataURL Data URL to decode. + * @return {string} A binary string (char codes are the actual byte values). */ ImageEncoder.decodeDataURL = function(dataURL) { // Skip the prefix ('data:image/<type>;base64,') @@ -118,7 +118,7 @@ ImageEncoder.decodeDataURL = function(dataURL) { /** * Return a thumbnail for an image. * @param {HTMLCanvasElement} canvas Original image. - * @param {Number} opt_shrinkage Thumbnail should be at least this much smaller + * @param {number} opt_shrinkage Thumbnail should be at least this much smaller * than the original image (in each dimension). * @return {HTMLCanvasElement} Thumbnail canvas */ @@ -192,7 +192,7 @@ ImageEncoder.MetadataEncoder.prototype.setThumbnailData = /** * Return a range where the metadata is (or should be) located. - * @param {String} encodedImage //TODO(JSDOC) + * @param {string} encodedImage //TODO(JSDOC) * @return {Object} An object with from and to properties. */ ImageEncoder.MetadataEncoder.prototype. diff --git a/chrome/browser/resources/file_manager/js/media/media_controls.js b/chrome/browser/resources/file_manager/js/media/media_controls.js index 0cf6005..c0d2b87 100644 --- a/chrome/browser/resources/file_manager/js/media/media_controls.js +++ b/chrome/browser/resources/file_manager/js/media/media_controls.js @@ -70,7 +70,7 @@ MediaControls.prototype.createControl = function(className, opt_parent) { * @param {string} className Class name. * @param {function(Event)} handler Click handler. * @param {HTMLElement=} opt_parent Parent element or container if undefined. - * @param {Boolean} opt_toggle True if the button has toggle state. + * @param {boolean} opt_toggle True if the button has toggle state. * @return {HTMLElement} The new button element. */ MediaControls.prototype.createButton = function( diff --git a/chrome/browser/resources/file_manager/js/photo/gallery.js b/chrome/browser/resources/file_manager/js/photo/gallery.js index 9688c9d..19b560d 100644 --- a/chrome/browser/resources/file_manager/js/photo/gallery.js +++ b/chrome/browser/resources/file_manager/js/photo/gallery.js @@ -140,13 +140,13 @@ Gallery.openStandalone = function(path, pageState) { /** * Tools fade-out timeout im milliseconds. - * @type {Number} + * @type {number} */ Gallery.FADE_TIMEOUT = 3000; /** * First time tools fade-out timeout im milliseconds. - * @type {Number} + * @type {number} */ Gallery.FIRST_FADE_TIMEOUT = 1000; @@ -731,7 +731,7 @@ Gallery.prototype.onFilenameEditKeydown_ = function() { }; /** - * @return {Boolean} True if file renaming is currently in progress + * @return {boolean} True if file renaming is currently in progress * @private */ Gallery.prototype.isRenaming_ = function() { diff --git a/chrome/browser/resources/file_manager/js/photo/ribbon.js b/chrome/browser/resources/file_manager/js/photo/ribbon.js index d2a0036..d6170e5 100644 --- a/chrome/browser/resources/file_manager/js/photo/ribbon.js +++ b/chrome/browser/resources/file_manager/js/photo/ribbon.js @@ -48,7 +48,7 @@ Ribbon.decorate = function(self, metadataCache, dataModel, selectionModel, /** * Max number of thumbnails in the ribbon. - * @type {Number} + * @type {number} */ Ribbon.ITEMS_COUNT = 5; diff --git a/chrome/browser/resources/file_manager/js/selection.js b/chrome/browser/resources/file_manager/js/selection.js index 8afa815..cce1f8d 100644 --- a/chrome/browser/resources/file_manager/js/selection.js +++ b/chrome/browser/resources/file_manager/js/selection.js @@ -5,7 +5,7 @@ /** * The current selection object. * @param {FileManager} fileManager FileManager instance. - * @param {Array.<Number>} indexes Selected indexes. + * @param {Array.<number>} indexes Selected indexes. */ function Selection(fileManager, indexes) { this.fileManager_ = fileManager; |