summaryrefslogtreecommitdiffstats
path: root/chrome/browser/resources/options/browser_options.js
diff options
context:
space:
mode:
authorestade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-02-01 22:55:13 +0000
committerestade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-02-01 22:55:13 +0000
commit099c10860b86a8f4b652a9aa0ab414a1aa2e7c88 (patch)
tree4a351877cf06a271c3fba43ff35a7fc6a0111c4e /chrome/browser/resources/options/browser_options.js
parent51e07e946c9aeb2b527c20a1a7dfa542581aad15 (diff)
downloadchromium_src-099c10860b86a8f4b652a9aa0ab414a1aa2e7c88.zip
chromium_src-099c10860b86a8f4b652a9aa0ab414a1aa2e7c88.tar.gz
chromium_src-099c10860b86a8f4b652a9aa0ab414a1aa2e7c88.tar.bz2
Fix up history state in tabbed options.
I need to write a test for this once dtseng's DOMUI testing framework is in. Manual tests: 1. open settings page via wrench menu. The back stack should be empty. 2. click on nav links on left. back and forward should work as expected. 3. open a subpage (such as passwords management). Then click on a different nav link, like advanced. Back should take you directly back to the passwords management subpage. 4. Close a subpage via the top right (x). Pressing back should reopen it. 5. search for "auto". Click on content settings, then close it. The original search page should show again (not "under the hood"). BUG=71452 TEST=see above Review URL: http://codereview.chromium.org/6287033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73368 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/resources/options/browser_options.js')
-rw-r--r--chrome/browser/resources/options/browser_options.js2
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/resources/options/browser_options.js b/chrome/browser/resources/options/browser_options.js
index 9d70454..4bdf82c 100644
--- a/chrome/browser/resources/options/browser_options.js
+++ b/chrome/browser/resources/options/browser_options.js
@@ -48,7 +48,7 @@ cr.define('options', function() {
OptionsPage.showOverlay('addStartupPageOverlay');
};
$('defaultSearchManageEnginesButton').onclick = function(event) {
- OptionsPage.showPageByName('searchEngines');
+ OptionsPage.navigateToPage('searchEngines');
chrome.send('coreOptionsUserMetricsAction',
['Options_ManageSearchEngines']);
};