diff options
author | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-01 22:55:13 +0000 |
---|---|---|
committer | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-01 22:55:13 +0000 |
commit | 099c10860b86a8f4b652a9aa0ab414a1aa2e7c88 (patch) | |
tree | 4a351877cf06a271c3fba43ff35a7fc6a0111c4e /chrome/browser/resources/options/personal_options.js | |
parent | 51e07e946c9aeb2b527c20a1a7dfa542581aad15 (diff) | |
download | chromium_src-099c10860b86a8f4b652a9aa0ab414a1aa2e7c88.zip chromium_src-099c10860b86a8f4b652a9aa0ab414a1aa2e7c88.tar.gz chromium_src-099c10860b86a8f4b652a9aa0ab414a1aa2e7c88.tar.bz2 |
Fix up history state in tabbed options.
I need to write a test for this once dtseng's DOMUI testing framework is in.
Manual tests:
1. open settings page via wrench menu. The back stack should be empty.
2. click on nav links on left. back and forward should work as expected.
3. open a subpage (such as passwords management). Then click on a different nav link, like advanced. Back should take you directly back to the passwords management subpage.
4. Close a subpage via the top right (x). Pressing back should reopen it.
5. search for "auto". Click on content settings, then close it. The original search page should show again (not "under the hood").
BUG=71452
TEST=see above
Review URL: http://codereview.chromium.org/6287033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73368 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/resources/options/personal_options.js')
-rw-r--r-- | chrome/browser/resources/options/personal_options.js | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/resources/options/personal_options.js b/chrome/browser/resources/options/personal_options.js index 72dcb48..6e62372 100644 --- a/chrome/browser/resources/options/personal_options.js +++ b/chrome/browser/resources/options/personal_options.js @@ -47,13 +47,13 @@ cr.define('options', function() { chrome.send('openPrivacyDashboardTabAndActivate'); }; $('manage-passwords').onclick = function(event) { - OptionsPage.showPageByName('passwordManager'); + OptionsPage.navigateToPage('passwordManager'); OptionsPage.showTab($('passwords-nav-tab')); chrome.send('coreOptionsUserMetricsAction', ['Options_ShowPasswordManager']); }; $('autofill-settings').onclick = function(event) { - OptionsPage.showPageByName('autoFillOptions'); + OptionsPage.navigateToPage('autoFillOptions'); chrome.send('coreOptionsUserMetricsAction', ['Options_ShowAutoFillSettings']); }; |