summaryrefslogtreecommitdiffstats
path: root/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc
diff options
context:
space:
mode:
authorbryner@chromium.org <bryner@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-08-26 02:28:57 +0000
committerbryner@chromium.org <bryner@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-08-26 02:28:57 +0000
commit5444af87f9e4a9f61be163344e41ed3dca70dcf0 (patch)
tree9e065b8062a76841962b43b94bfd142eaf5e84c4 /chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc
parentda58c9cf8cb374a06e511ab6b59b47f21c6549d4 (diff)
downloadchromium_src-5444af87f9e4a9f61be163344e41ed3dca70dcf0.zip
chromium_src-5444af87f9e4a9f61be163344e41ed3dca70dcf0.tar.gz
chromium_src-5444af87f9e4a9f61be163344e41ed3dca70dcf0.tar.bz2
Add support for client-side phishing detection for non-UMA users.
In this mode, a sanitized pingback is sent that does not include the URL or any tokens extracted from the URL or page content. Currently, this feature is behind a command-line flag. BUG=none TEST=ClientSideDetectionServiceTest,BrowserFeatureExtractorTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98168 Review URL: http://codereview.chromium.org/7635010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98383 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc')
-rw-r--r--chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc50
1 files changed, 50 insertions, 0 deletions
diff --git a/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc b/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc
index f333755..3156f28 100644
--- a/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc
+++ b/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc
@@ -15,6 +15,7 @@
#include "chrome/browser/history/history.h"
#include "chrome/browser/history/history_backend.h"
#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/safe_browsing/browser_features.h"
#include "chrome/browser/safe_browsing/client_side_detection_service.h"
#include "chrome/test/base/testing_profile.h"
#include "content/browser/browser_thread.h"
@@ -23,6 +24,7 @@
#include "content/browser/tab_contents/test_tab_contents.h"
#include "content/common/page_transition_types.h"
#include "content/common/view_messages.h"
+#include "crypto/sha2.h"
#include "googleurl/src/gurl.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -474,4 +476,52 @@ TEST_F(BrowserFeatureExtractorTest, SafeBrowsingFeatures) {
EXPECT_DOUBLE_EQ(1.0, features[features::kSafeBrowsingIsSubresource]);
EXPECT_DOUBLE_EQ(2.0, features[features::kSafeBrowsingThreatType]);
}
+
+TEST_F(BrowserFeatureExtractorTest, URLHashes) {
+ ClientPhishingRequest request;
+ request.set_url("http://host.com/");
+ request.set_client_score(0.8f);
+
+ history_service()->AddPage(GURL("http://host.com/"),
+ history::SOURCE_BROWSED);
+ contents()->NavigateAndCommit(GURL("http://host.com/"));
+
+ EXPECT_TRUE(ExtractFeatures(&request));
+ EXPECT_EQ(crypto::SHA256HashString("host.com/").substr(
+ 0, BrowserFeatureExtractor::kSuffixPrefixHashLength),
+ request.suffix_prefix_hash());
+
+ request.set_url("http://www.host.com/path/");
+ history_service()->AddPage(GURL("http://www.host.com/path/"),
+ history::SOURCE_BROWSED);
+ contents()->NavigateAndCommit(GURL("http://www.host.com/path/"));
+
+ EXPECT_TRUE(ExtractFeatures(&request));
+ EXPECT_EQ(crypto::SHA256HashString("www.host.com/path/").substr(
+ 0, BrowserFeatureExtractor::kSuffixPrefixHashLength),
+ request.suffix_prefix_hash());
+
+ request.set_url("http://user@www.host.com:1111/path/123?args");
+ history_service()->AddPage(
+ GURL("http://user@www.host.com:1111/path/123?args"),
+ history::SOURCE_BROWSED);
+ contents()->NavigateAndCommit(
+ GURL("http://user@www.host.com:1111/path/123?args"));
+
+ EXPECT_TRUE(ExtractFeatures(&request));
+ EXPECT_EQ(crypto::SHA256HashString("www.host.com/path/123").substr(
+ 0, BrowserFeatureExtractor::kSuffixPrefixHashLength),
+ request.suffix_prefix_hash());
+
+ // Check that escaping matches the SafeBrowsing specification.
+ request.set_url("http://www.host.com/A%21//B");
+ history_service()->AddPage(GURL("http://www.host.com/A%21//B"),
+ history::SOURCE_BROWSED);
+ contents()->NavigateAndCommit(GURL("http://www.host.com/A%21//B"));
+
+ EXPECT_TRUE(ExtractFeatures(&request));
+ EXPECT_EQ(crypto::SHA256HashString("www.host.com/A!/B").substr(
+ 0, BrowserFeatureExtractor::kSuffixPrefixHashLength),
+ request.suffix_prefix_hash());
+}
} // namespace safe_browsing