diff options
author | dcheng <dcheng@chromium.org> | 2014-10-21 17:46:21 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-10-22 04:03:14 +0000 |
commit | 2bcca5574426bd380d58a7d4ed2ac206b447eb3e (patch) | |
tree | bb2388aaf74310e16fc21229770876d90aa22f88 /chrome/browser/safe_browsing/database_manager.h | |
parent | ba1acbb6fd858192298dd2d9eba8298cd94c2948 (diff) | |
download | chromium_src-2bcca5574426bd380d58a7d4ed2ac206b447eb3e.zip chromium_src-2bcca5574426bd380d58a7d4ed2ac206b447eb3e.tar.gz chromium_src-2bcca5574426bd380d58a7d4ed2ac206b447eb3e.tar.bz2 |
Standardize usage of virtual/override/final in chrome/browser/safe_browsing/
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
BUG=417463
R=mattm@chromium.org
Review URL: https://codereview.chromium.org/657373004
Cr-Commit-Position: refs/heads/master@{#300586}
Diffstat (limited to 'chrome/browser/safe_browsing/database_manager.h')
-rw-r--r-- | chrome/browser/safe_browsing/database_manager.h | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/chrome/browser/safe_browsing/database_manager.h b/chrome/browser/safe_browsing/database_manager.h index 824800a..e001a35 100644 --- a/chrome/browser/safe_browsing/database_manager.h +++ b/chrome/browser/safe_browsing/database_manager.h @@ -205,7 +205,7 @@ class SafeBrowsingDatabaseManager void StopOnIOThread(bool shutdown); protected: - virtual ~SafeBrowsingDatabaseManager(); + ~SafeBrowsingDatabaseManager() override; // protected for tests. void NotifyDatabaseUpdateFinished(bool update_succeeded); @@ -341,15 +341,15 @@ class SafeBrowsingDatabaseManager const base::Closure& task); // SafeBrowsingProtocolManageDelegate override - virtual void ResetDatabase() override; - virtual void UpdateStarted() override; - virtual void UpdateFinished(bool success) override; - virtual void GetChunks(GetChunksCallback callback) override; - virtual void AddChunks(const std::string& list, - scoped_ptr<ScopedVector<SBChunkData> > chunks, - AddChunksCallback callback) override; - virtual void DeleteChunks( - scoped_ptr<std::vector<SBChunkDelete> > chunk_deletes) override; + void ResetDatabase() override; + void UpdateStarted() override; + void UpdateFinished(bool success) override; + void GetChunks(GetChunksCallback callback) override; + void AddChunks(const std::string& list, + scoped_ptr<ScopedVector<SBChunkData>> chunks, + AddChunksCallback callback) override; + void DeleteChunks( + scoped_ptr<std::vector<SBChunkDelete>> chunk_deletes) override; scoped_refptr<SafeBrowsingService> sb_service_; |