diff options
author | dcheng <dcheng@chromium.org> | 2014-10-21 17:46:21 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-10-22 04:03:14 +0000 |
commit | 2bcca5574426bd380d58a7d4ed2ac206b447eb3e (patch) | |
tree | bb2388aaf74310e16fc21229770876d90aa22f88 /chrome/browser/safe_browsing/ping_manager.h | |
parent | ba1acbb6fd858192298dd2d9eba8298cd94c2948 (diff) | |
download | chromium_src-2bcca5574426bd380d58a7d4ed2ac206b447eb3e.zip chromium_src-2bcca5574426bd380d58a7d4ed2ac206b447eb3e.tar.gz chromium_src-2bcca5574426bd380d58a7d4ed2ac206b447eb3e.tar.bz2 |
Standardize usage of virtual/override/final in chrome/browser/safe_browsing/
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
BUG=417463
R=mattm@chromium.org
Review URL: https://codereview.chromium.org/657373004
Cr-Commit-Position: refs/heads/master@{#300586}
Diffstat (limited to 'chrome/browser/safe_browsing/ping_manager.h')
-rw-r--r-- | chrome/browser/safe_browsing/ping_manager.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/safe_browsing/ping_manager.h b/chrome/browser/safe_browsing/ping_manager.h index d48cc4f..a33559b 100644 --- a/chrome/browser/safe_browsing/ping_manager.h +++ b/chrome/browser/safe_browsing/ping_manager.h @@ -25,7 +25,7 @@ class URLRequestContextGetter; class SafeBrowsingPingManager : public net::URLFetcherDelegate { public: - virtual ~SafeBrowsingPingManager(); + ~SafeBrowsingPingManager() override; // Create an instance of the safe browsing ping manager. static SafeBrowsingPingManager* Create( @@ -33,7 +33,7 @@ class SafeBrowsingPingManager : public net::URLFetcherDelegate { const SafeBrowsingProtocolConfig& config); // net::URLFetcherDelegate interface. - virtual void OnURLFetchComplete(const net::URLFetcher* source) override; + void OnURLFetchComplete(const net::URLFetcher* source) override; // For UMA users we report to Google when a SafeBrowsing interstitial is shown // to the user. |threat_type| should be one of the types known by |