summaryrefslogtreecommitdiffstats
path: root/chrome/browser/safe_browsing/protocol_manager.h
diff options
context:
space:
mode:
authordcheng <dcheng@chromium.org>2014-10-21 17:46:21 -0700
committerCommit bot <commit-bot@chromium.org>2014-10-22 04:03:14 +0000
commit2bcca5574426bd380d58a7d4ed2ac206b447eb3e (patch)
treebb2388aaf74310e16fc21229770876d90aa22f88 /chrome/browser/safe_browsing/protocol_manager.h
parentba1acbb6fd858192298dd2d9eba8298cd94c2948 (diff)
downloadchromium_src-2bcca5574426bd380d58a7d4ed2ac206b447eb3e.zip
chromium_src-2bcca5574426bd380d58a7d4ed2ac206b447eb3e.tar.gz
chromium_src-2bcca5574426bd380d58a7d4ed2ac206b447eb3e.tar.bz2
Standardize usage of virtual/override/final in chrome/browser/safe_browsing/
The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=mattm@chromium.org Review URL: https://codereview.chromium.org/657373004 Cr-Commit-Position: refs/heads/master@{#300586}
Diffstat (limited to 'chrome/browser/safe_browsing/protocol_manager.h')
-rw-r--r--chrome/browser/safe_browsing/protocol_manager.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/safe_browsing/protocol_manager.h b/chrome/browser/safe_browsing/protocol_manager.h
index 3eb549a..ae357f8 100644
--- a/chrome/browser/safe_browsing/protocol_manager.h
+++ b/chrome/browser/safe_browsing/protocol_manager.h
@@ -51,7 +51,7 @@ class SafeBrowsingProtocolManager : public net::URLFetcherDelegate,
typedef base::Callback<void(const std::vector<SBFullHashResult>&,
const base::TimeDelta&)> FullHashCallback;
- virtual ~SafeBrowsingProtocolManager();
+ ~SafeBrowsingProtocolManager() override;
// Makes the passed |factory| the factory used to instantiate
// a SafeBrowsingService. Useful for tests.
@@ -70,7 +70,7 @@ class SafeBrowsingProtocolManager : public net::URLFetcherDelegate,
virtual void Initialize();
// net::URLFetcherDelegate interface.
- virtual void OnURLFetchComplete(const net::URLFetcher* source) override;
+ void OnURLFetchComplete(const net::URLFetcher* source) override;
// Retrieve the full hash for a set of prefixes, and invoke the callback
// argument when the results are retrieved. The callback may be invoked