summaryrefslogtreecommitdiffstats
path: root/chrome/browser/safe_browsing/safe_browsing_database.cc
diff options
context:
space:
mode:
authorshess@chromium.org <shess@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-10-15 13:24:15 +0000
committershess@chromium.org <shess@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-10-15 13:24:15 +0000
commit99f337aa610c4f6c3271435bcfb46cac0b7f776a (patch)
tree0346f6ea74c5c8155c6818fa56384771a1f32cb0 /chrome/browser/safe_browsing/safe_browsing_database.cc
parent2998df85b9882b8197fd43ac3b66b1581446bb92 (diff)
downloadchromium_src-99f337aa610c4f6c3271435bcfb46cac0b7f776a.zip
chromium_src-99f337aa610c4f6c3271435bcfb46cac0b7f776a.tar.gz
chromium_src-99f337aa610c4f6c3271435bcfb46cac0b7f776a.tar.bz2
Adjust safe-browsing database-update metrics to account for update read.
Oops. The time and I/O counts weren't accounting for the full update. I believe this makes things comparable to safe_browsing_database_bloom.cc's metrics. BUG=none TEST=none Review URL: http://codereview.chromium.org/3826007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62729 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/safe_browsing/safe_browsing_database.cc')
-rw-r--r--chrome/browser/safe_browsing/safe_browsing_database.cc16
1 files changed, 8 insertions, 8 deletions
diff --git a/chrome/browser/safe_browsing/safe_browsing_database.cc b/chrome/browser/safe_browsing/safe_browsing_database.cc
index df76d47..3301666 100644
--- a/chrome/browser/safe_browsing/safe_browsing_database.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_database.cc
@@ -559,14 +559,6 @@ void SafeBrowsingDatabaseNew::UpdateFinished(bool update_succeeded) {
pending_hashes_.begin(), pending_hashes_.end());
}
- std::vector<SBAddPrefix> add_prefixes;
- std::vector<SBAddFullHash> add_full_hashes;
- if (!store_->FinishUpdate(pending_add_hashes,
- &add_prefixes, &add_full_hashes)) {
- RecordFailure(FAILURE_DATABASE_UPDATE_FINISH);
- return;
- }
-
// Measure the amount of IO during the bloom filter build.
base::IoCounters io_before, io_after;
base::ProcessHandle handle = base::Process::Current().handle();
@@ -586,6 +578,14 @@ void SafeBrowsingDatabaseNew::UpdateFinished(bool update_succeeded) {
const base::Time before = base::Time::Now();
+ std::vector<SBAddPrefix> add_prefixes;
+ std::vector<SBAddFullHash> add_full_hashes;
+ if (!store_->FinishUpdate(pending_add_hashes,
+ &add_prefixes, &add_full_hashes)) {
+ RecordFailure(FAILURE_DATABASE_UPDATE_FINISH);
+ return;
+ }
+
// Create and populate |filter| from |add_prefixes|.
// TODO(shess): The bloom filter doesn't need to be a
// scoped_refptr<> for this code. Refactor that away.