diff options
| author | shess@chromium.org <shess@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-08 20:18:52 +0000 |
|---|---|---|
| committer | shess@chromium.org <shess@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-08 20:18:52 +0000 |
| commit | 83c18d40e8d5ae1faa5903720a421a303cc1a531 (patch) | |
| tree | 6793011174c42613355d4f7e6ae05dfe636b8969 /chrome/browser/safe_browsing/safe_browsing_database.h | |
| parent | 75e50df09cedc5b78574531c95316cdccbd7950c (diff) | |
| download | chromium_src-83c18d40e8d5ae1faa5903720a421a303cc1a531.zip chromium_src-83c18d40e8d5ae1faa5903720a421a303cc1a531.tar.gz chromium_src-83c18d40e8d5ae1faa5903720a421a303cc1a531.tar.bz2 | |
Clean up safe_browsing_database.cc histograms.
Sizes were being logged in bytes, which meant they were pegged at one
million. Change to log kilobytes.
Unify a bunch of separate single-value histograms into a since enum.
The existing histograms have been left in place for now for
continuity for the next release.
BUG=58401
TEST=none
Review URL: http://codereview.chromium.org/3551020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62006 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/safe_browsing/safe_browsing_database.h')
| -rw-r--r-- | chrome/browser/safe_browsing/safe_browsing_database.h | 21 |
1 files changed, 21 insertions, 0 deletions
diff --git a/chrome/browser/safe_browsing/safe_browsing_database.h b/chrome/browser/safe_browsing/safe_browsing_database.h index 4120afd..ad04a7c 100644 --- a/chrome/browser/safe_browsing/safe_browsing_database.h +++ b/chrome/browser/safe_browsing/safe_browsing_database.h @@ -91,6 +91,27 @@ class SafeBrowsingDatabase { // The name of the bloom-filter file for the given database file. static FilePath BloomFilterForFilename(const FilePath& db_filename); + + // Enumerate failures for histogramming purposes. DO NOT CHANGE THE + // ORDERING OF THESE VALUES. + enum FailureType { + FAILURE_DATABASE_CORRUPT, + FAILURE_DATABASE_CORRUPT_HANDLER, + FAILURE_DATABASE_UPDATE_BEGIN, + FAILURE_DATABASE_UPDATE_FINISH, + FAILURE_DATABASE_FILTER_MISSING, + FAILURE_DATABASE_FILTER_READ, + FAILURE_DATABASE_FILTER_WRITE, + FAILURE_DATABASE_FILTER_DELETE, + FAILURE_DATABASE_STORE_MISSING, + FAILURE_DATABASE_STORE_DELETE, + + // Histogram space is determined by the max. If this is exceeded, + // simply start a new histogram. + FAILURE_MAX = 50 + }; + + static void RecordFailure(FailureType failure_type); }; class SafeBrowsingDatabaseNew : public SafeBrowsingDatabase { |