diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-21 03:21:51 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-21 03:21:51 +0000 |
| commit | 33b2261718852034e1c93b708fc176337d862db5 (patch) | |
| tree | f5ae5e98e3162a5ad7a6857800134430c9d9c1f9 /chrome/browser/safe_browsing | |
| parent | 81af939f99865071091db5393e87d85fb0f02012 (diff) | |
| download | chromium_src-33b2261718852034e1c93b708fc176337d862db5.zip chromium_src-33b2261718852034e1c93b708fc176337d862db5.tar.gz chromium_src-33b2261718852034e1c93b708fc176337d862db5.tar.bz2 | |
Fix a leak of the NavigationController during many tests. A duplicate
NavigationController was begin created from when we had to create this
separately.
BUG=10781
Review URL: http://codereview.chromium.org/88018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14084 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/safe_browsing')
| -rw-r--r-- | chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc index 771d4be..a7f8307 100644 --- a/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc +++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc @@ -111,7 +111,7 @@ class SafeBrowsingBlockingPageTest : public RenderViewHostTestHarness, // showing. SafeBrowsingBlockingPage* GetSafeBrowsingBlockingPage() { InterstitialPage* interstitial = - InterstitialPage::GetInterstitialPage(contents_); + InterstitialPage::GetInterstitialPage(contents()); if (!interstitial) return NULL; return static_cast<SafeBrowsingBlockingPage*>(interstitial); @@ -186,11 +186,11 @@ TEST_F(SafeBrowsingBlockingPageTest, MalwarePageProceed) { ProceedThroughInterstitial(sb_interstitial); // The interstitial is shown until the navigation commits. - ASSERT_TRUE(InterstitialPage::GetInterstitialPage(contents_)); + ASSERT_TRUE(InterstitialPage::GetInterstitialPage(contents())); // Commit the navigation. Navigate(kBadURL, 1); // The interstitial should be gone now. - ASSERT_FALSE(InterstitialPage::GetInterstitialPage(contents_)); + ASSERT_FALSE(InterstitialPage::GetInterstitialPage(contents())); } // Tests showing a blocking page for a page that contains malware subresources |