diff options
| author | lzheng@chromium.org <lzheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-08 01:37:56 +0000 |
|---|---|---|
| committer | lzheng@chromium.org <lzheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-08 01:37:56 +0000 |
| commit | 604635002f06447c0cfbad908a3cb7121ba28a39 (patch) | |
| tree | 57a391abc6fe99dc199a47528109961362f99cac /chrome/browser/safe_browsing | |
| parent | 2094a1d19b638b8e126e07f4476fd4f2cc3efd86 (diff) | |
| download | chromium_src-604635002f06447c0cfbad908a3cb7121ba28a39.zip chromium_src-604635002f06447c0cfbad908a3cb7121ba28a39.tar.gz chromium_src-604635002f06447c0cfbad908a3cb7121ba28a39.tar.bz2 | |
Re-design the phishing interstitial page. The change is mostly about: make the 'go back' button big and green in a central place, and put the 'proceed' into a link at the bottom of the page.
sample screenshot: https://docs1.google.com/document/d/1peJV0yfVSgjbdydInshy8FSU2Q9kUivTtdyMpIDIP1w/edit?authkey=CLCQl9sE#
Patch from Ke Wang <kewang@google.com>
BUG=60813
TEST=unit_tests. To see the UI change, start the browser and try load some sites in malware blacklist.
Review URL: http://codereview.chromium.org/5560003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68548 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/safe_browsing')
| -rw-r--r-- | chrome/browser/safe_browsing/safe_browsing_blocking_page.cc | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc index 2601023..9bc9f7d 100644 --- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc +++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc @@ -288,6 +288,13 @@ void SafeBrowsingBlockingPage::PopulateMalwareStringDictionary( void SafeBrowsingBlockingPage::PopulatePhishingStringDictionary( DictionaryValue* strings) { + std::wstring proceed_link = StringPrintf( + kPLinkHtml, + l10n_util::GetString(IDS_SAFE_BROWSING_PHISHING_PROCEED_LINK).c_str()); + std::wstring description3 = l10n_util::GetStringF( + IDS_SAFE_BROWSING_PHISHING_DESCRIPTION3, + proceed_link); + PopulateStringDictionary( strings, l10n_util::GetString(IDS_SAFE_BROWSING_PHISHING_TITLE), @@ -295,10 +302,8 @@ void SafeBrowsingBlockingPage::PopulatePhishingStringDictionary( l10n_util::GetStringF(IDS_SAFE_BROWSING_PHISHING_DESCRIPTION1, UTF8ToWide(url().host())), l10n_util::GetString(IDS_SAFE_BROWSING_PHISHING_DESCRIPTION2), - L""); + description3); - strings->SetString("continue_button", - l10n_util::GetStringUTF16(IDS_SAFE_BROWSING_PHISHING_PROCEED_BUTTON)); strings->SetString("back_button", l10n_util::GetStringUTF16(IDS_SAFE_BROWSING_PHISHING_BACK_BUTTON)); strings->SetString("report_error", |