Non-functional changes: * 0 -> TemplateURLRef::NO_SUGGESTIONS_AVAILABLE * GURL x = GURL(...) -> GURL x(...) * Infobar -> InfoBar * AllSources -> AllBrowserContextsAndSources * Pass a Profile* to SearchProviderInstallData, which it will need for more purposes once UIThreadSearchTermsData takes a Profile* * Add/modify comments * "" -> std::string() * Other trivial changes to minimize diffs Functional changes: * TemplateURLFetcher::RequestDelegate::AddSearchProvider() no longer clears the keyword for a newly-added, explicitly-requested TemplateURL that conflicts with a non-replaceable keyword. This means the conflicting keyword will appear in the dialog box and the box will indicate a conflict. This is mostly to avoid giving a TemplateURL an empty keyword, which will later be made illegal. * TemplateURLFetcher::ScheduleDownload() now expects the provided keyword to be non-NULL for autodetected cases (which was always true already) and ignores the keyword for explicit cases (which only matters to tests, as the actual browser code always passed an empty keyword here anyway). * TemplateURLService::CanReplaceKeyword() now always sets its outparam. This prevents any possible use-without-set on the caller side. * Properly order (expected, actual) * ASSERT -> EXPECT * Construct the TemplateURL for TemplateURLTableModel::Add() in that function rather than the caller. This will make it easier to change TemplateURLs to require a Profile* later. * Check all fields at the end of WebDatabaseMigrationTest.MigrateVersion27ToCurrent BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9811022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128270 0039d316-1c4b-4281-b951-d872f2087c98