diff options
| author | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-06 21:00:01 +0000 |
|---|---|---|
| committer | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-06 21:00:01 +0000 |
| commit | 668cd428d8cb73e496067e866ffc57524665e756 (patch) | |
| tree | e263e77bff92aed13f86e30d1ecabb51baca2257 /chrome/browser/sessions/session_service.h | |
| parent | 39fc6471702683395aac43277fd2b95da5dfbb4d (diff) | |
| download | chromium_src-668cd428d8cb73e496067e866ffc57524665e756.zip chromium_src-668cd428d8cb73e496067e866ffc57524665e756.tar.gz chromium_src-668cd428d8cb73e496067e866ffc57524665e756.tar.bz2 | |
Attempt 2 at changing session restores handling of incognito
windows. Previously when closing the last non-incognito window while
an incognito window was open resulted in clearing out the current
session. Now the session is not cleared out.
BUG=31540
TEST=see bug, also covered by tests
R=brettw@chromium.org,kuan@chromium.org
Review URL: http://codereview.chromium.org/6693084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80691 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/sessions/session_service.h')
| -rw-r--r-- | chrome/browser/sessions/session_service.h | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/chrome/browser/sessions/session_service.h b/chrome/browser/sessions/session_service.h index d7d4aeb..4d09e9b 100644 --- a/chrome/browser/sessions/session_service.h +++ b/chrome/browser/sessions/session_service.h @@ -33,12 +33,13 @@ struct SessionWindow; // and tabs so that they can be restored at a later date. The state of the // currently open browsers is referred to as the current session. // -// SessionService supports restoring from the previous or last session. The -// previous session typically corresponds to the last run of the browser, but -// not always. For example, if the user has a tabbed browser and app window -// running, closes the tabbed browser, then creates a new tabbed browser the -// current session is made the last session and the current session reset. This -// is done to provide the illusion that app windows run in separate processes. +// SessionService supports restoring from the last session. The last session +// typically corresponds to the last run of the browser, but not always. For +// example, if the user has a tabbed browser and app window running, closes the +// tabbed browser, then creates a new tabbed browser the current session is made +// the last session and the current session reset. This is done to provide the +// illusion that app windows run in separate processes. Similar behavior occurs +// with incognito windows. // // SessionService itself maintains a set of SessionCommands that allow // SessionService to rebuild the open state of the browser (as @@ -240,9 +241,8 @@ class SessionService : public BaseSessionService, SessionCommand* CreatePinnedStateCommand(const SessionID& tab_id, bool is_pinned); - // Callback from the backend for getting the commands from the previous - // or save file. Converts the commands in SessionWindows and notifies - // the real callback. + // Callback from the backend for getting the commands from the save file. + // Converts the commands in SessionWindows and notifies the real callback. void OnGotSessionCommands( Handle handle, scoped_refptr<InternalGetCommandsRequest> request); @@ -440,8 +440,8 @@ class SessionService : public BaseSessionService, // If true and a new tabbed browser is created and there are no opened tabbed // browser (has_open_trackable_browsers_ is false), then the current session - // is made the previous session. See description above class for details on - // current/previous session. + // is made the last session. See description above class for details on + // current/last session. bool move_on_new_browser_; // Used for reporting frequency of session altering operations. |