diff options
| author | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-11 01:02:56 +0000 |
|---|---|---|
| committer | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-11 01:02:56 +0000 |
| commit | bd5174ddc1e9dd3ac8099e380f1e92152df9b789 (patch) | |
| tree | 551b41843a1291fc409a55bb134f36075e90db8a /chrome/browser/sidebar | |
| parent | 4e6ffdeb72dead790b276ea580210c9f4584b277 (diff) | |
| download | chromium_src-bd5174ddc1e9dd3ac8099e380f1e92152df9b789.zip chromium_src-bd5174ddc1e9dd3ac8099e380f1e92152df9b789.tar.gz chromium_src-bd5174ddc1e9dd3ac8099e380f1e92152df9b789.tar.bz2 | |
Fix some coverity defects (mostly pass by value).
CID=15414,15415,15413,15412,15402,14582,13684,12723,15407,14785,14511,13975,13647,11655,10891,9103,8402,8394,10924,8497,others
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/6665012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77740 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/sidebar')
| -rw-r--r-- | chrome/browser/sidebar/sidebar_container.cc | 2 | ||||
| -rw-r--r-- | chrome/browser/sidebar/sidebar_container.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/sidebar/sidebar_container.cc b/chrome/browser/sidebar/sidebar_container.cc index 140dffe..cab6dc2 100644 --- a/chrome/browser/sidebar/sidebar_container.cc +++ b/chrome/browser/sidebar/sidebar_container.cc @@ -112,7 +112,7 @@ bool SidebarContainer::IsPopup(const TabContents* source) const { } void SidebarContainer::OnImageLoaded(SkBitmap* image, - ExtensionResource resource, + const ExtensionResource& resource, int index) { if (image && use_default_icon_) { *icon_ = *image; diff --git a/chrome/browser/sidebar/sidebar_container.h b/chrome/browser/sidebar/sidebar_container.h index 9ae2396..658e85e 100644 --- a/chrome/browser/sidebar/sidebar_container.h +++ b/chrome/browser/sidebar/sidebar_container.h @@ -117,7 +117,7 @@ class SidebarContainer // Overridden from ImageLoadingTracker::Observer. virtual void OnImageLoaded(SkBitmap* image, - ExtensionResource resource, + const ExtensionResource& resource, int index); // Returns an extension this sidebar belongs to. |