diff options
author | estark <estark@chromium.org> | 2015-05-13 15:01:55 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-05-13 22:02:50 +0000 |
commit | 4282f117db4ddb6b307efad849ec6635095e9cd1 (patch) | |
tree | 16e84773eda4a7e4568f1ef234e71f2482054fee /chrome/browser/ssl/ssl_cert_reporter.h | |
parent | 8a9efca9b5451c75da244f62f073206c97ef6dd4 (diff) | |
download | chromium_src-4282f117db4ddb6b307efad849ec6635095e9cd1.zip chromium_src-4282f117db4ddb6b307efad849ec6635095e9cd1.tar.gz chromium_src-4282f117db4ddb6b307efad849ec6635095e9cd1.tar.bz2 |
Split cert reporter class into report building/serializing and sending
The pre-existing |CertificateErrorReporter| class (in
//chrome/browser/net) is now only in charge of sending reports over the
network. A new class (|CertificateErrorReport| in //chrome/browser/ssl)
is in charge of building and serializing the reports.
The motivation for this change is to allow reports to include
interstitial-specific information (such as the type of interstitial that
was shown, whether the user clicked through, etc.). So as to avoid
introducing interstitial knowledge into //c/b/net, all the report
building and serializing knowledge (including the report protobuf) has
been moved into //c/b/ssl. |SSLBlockingPage| now sends a serialized report
through |ChromeContentBrowserClient| to the SafeBrowsing UIManager to be
sent over the network.
|ChromeFraudulentCertificateReporter| (responsible for reporting
Google-property pinning violations) has also been moved into //c/b/ssl
so that it can use the new |CertificateErrorReport| class to build
reports before sending them with a |CertificateErrorReporter|.
BUG=462713,461588
Review URL: https://codereview.chromium.org/1117173004
Cr-Commit-Position: refs/heads/master@{#329723}
Diffstat (limited to 'chrome/browser/ssl/ssl_cert_reporter.h')
-rw-r--r-- | chrome/browser/ssl/ssl_cert_reporter.h | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/chrome/browser/ssl/ssl_cert_reporter.h b/chrome/browser/ssl/ssl_cert_reporter.h index d31c080..37c8d87 100644 --- a/chrome/browser/ssl/ssl_cert_reporter.h +++ b/chrome/browser/ssl/ssl_cert_reporter.h @@ -17,11 +17,10 @@ class SSLCertReporter { public: virtual ~SSLCertReporter() {} - // Send a report for |hostname| with the given |ssl_info| to the - // report collection endpoint. |callback| will be run when the report has - // been sent off (not necessarily after a response has been received). - virtual void ReportInvalidCertificateChain(const std::string& hostname, - const net::SSLInfo& ssl_info) = 0; + // Sends a serialized certificate report to the report collection + // endpoint. + virtual void ReportInvalidCertificateChain( + const std::string& serialized_report) = 0; }; #endif // CHROME_BROWSER_SSL_SSL_CERT_REPORTER_H_ |