diff options
| author | tim@chromium.org <tim@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-04 23:33:36 +0000 |
|---|---|---|
| committer | tim@chromium.org <tim@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-04 23:33:36 +0000 |
| commit | 4557d22bc0b6fe59fb146b08065f91d47d3c9254 (patch) | |
| tree | 7ef9d789310470d974d3af98ca3c94e611cff8e7 /chrome/browser/sync/syncable/syncable.cc | |
| parent | b7522682a07d06f417ba596fd3e7822bf22c1ab3 (diff) | |
| download | chromium_src-4557d22bc0b6fe59fb146b08065f91d47d3c9254.zip chromium_src-4557d22bc0b6fe59fb146b08065f91d47d3c9254.tar.gz chromium_src-4557d22bc0b6fe59fb146b08065f91d47d3c9254.tar.bz2 | |
sync: remove use of protobuf extensions in protocol to reduce static init overhead.
Instead, we now use optional fields in EntitySpecifics. Because the tag numbers remain
the same, this is a wire-format compatible change.
This incurs a (#datatypes * sizeof(void*))*#sync_items memory cost, due to storing extra pointers. In practice, for a typical account on windows this amounts to < 200k, and the static init cost is believed to be greater.
Note - upcoming features in protobufs may let us eliminate this extra memory overhead.
Also: The testserver tests were broken on ToT due to a bug in _SaveEntry's saving of mtime which is fixed in this patch.
TBR=yoz@chromium.org
TBR=mnissler@chromium.org
TBR=pkasting@chromium.org
TBR=georgey@chromium.org
BUG=94992, 94925
Review URL: http://codereview.chromium.org/9460047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124912 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/sync/syncable/syncable.cc')
| -rw-r--r-- | chrome/browser/sync/syncable/syncable.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/sync/syncable/syncable.cc b/chrome/browser/sync/syncable/syncable.cc index ce2d8bf..48d50a8 100644 --- a/chrome/browser/sync/syncable/syncable.cc +++ b/chrome/browser/sync/syncable/syncable.cc @@ -456,7 +456,7 @@ Directory::PersistedKernelInfo::~PersistedKernelInfo() {} void Directory::PersistedKernelInfo::reset_download_progress( ModelType model_type) { download_progress[model_type].set_data_type_id( - GetExtensionFieldNumberFromModelType(model_type)); + GetSpecificsFieldNumberFromModelType(model_type)); // An empty-string token indicates no prior knowledge. download_progress[model_type].set_token(std::string()); } |