[Sync] Simplify sync startup behavior.

Now IsFirstSetupComplete, IsSetupInProgress, and AUTO_START do not
directly factor into the sync startup logic. Instead, AUTO_START simply
sets IsFirstSetupComplete to true on signin, and sync datatypes can only
be configured if IsFirstSetupComplete && !IsSetupInProgress (aka the new
CanConfigureDataTypes helper function).

This change is motivated by wanting to have better understanding and
control over when and how sync starts up in order to fix the attached
bug.

BUG=462796

Review URL: https://codereview.chromium.org/1575153004

Cr-Commit-Position: refs/heads/master@{#380685}

1 files changed, 10 insertions, 3 deletions

diff --git a/chrome/browser/sync/test/integration/sync_test.cc b/chrome/browser/sync/test/integration/sync_test.cc
index 2aaedad..259efd6 100644
--- a/chrome/browser/sync/test/integration/sync_test.cc
+++ b/chrome/browser/sync/test/integration/sync_test.cc
@@ -590,14 +590,18 @@ void SyncTest::InitializeInvalidations(int index) {
 bool SyncTest::SetupSync() {
   // Create sync profiles and clients if they haven't already been created.
   if (profiles_.empty()) {
-    if (!SetupClients())
+    if (!SetupClients()) {
       LOG(FATAL) << "SetupClients() failed.";
+      return false;
+    }
   }
 
   // Sync each of the profiles.
   for (int i = 0; i < num_clients_; ++i) {
-    if (!GetClient(i)->SetupSync())
+    if (!GetClient(i)->SetupSync()) {
       LOG(FATAL) << "SetupSync() failed.";
+      return false;
+    }
   }
 
   // Because clients may modify sync data as part of startup (for example local
@@ -608,7 +612,10 @@ bool SyncTest::SetupSync() {
   // have to find their own way of waiting for an initial state if they really
   // need such guarantees.
   if (TestUsesSelfNotifications()) {
-    AwaitQuiescence();
+    if (!AwaitQuiescence()) {
+      LOG(FATAL) << "AwaitQuiescence() failed.";
+      return false;
+    }
   }
 
   // SyncRefresher is used instead of invalidations to notify other profiles to