diff options
author | avi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-24 23:24:23 +0000 |
---|---|---|
committer | avi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-24 23:24:23 +0000 |
commit | f911df5f3947379800704cb2b0193b0976336b22 (patch) | |
tree | d08ecc8ee4bb4580794294e59d702c1c0d7c0424 /chrome/browser/sync | |
parent | 04338722eaee6d09b761353fb6e937b41933ff5e (diff) | |
download | chromium_src-f911df5f3947379800704cb2b0193b0976336b22.zip chromium_src-f911df5f3947379800704cb2b0193b0976336b22.tar.gz chromium_src-f911df5f3947379800704cb2b0193b0976336b22.tar.bz2 |
Update some uses of UTF conversions in chrome/browser to use the base:: namespace.
BUG=330556
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/120983002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242465 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/sync')
31 files changed, 111 insertions, 96 deletions
diff --git a/chrome/browser/sync/about_sync_util_unittest.cc b/chrome/browser/sync/about_sync_util_unittest.cc index bf5befe..6755d1b 100644 --- a/chrome/browser/sync/about_sync_util_unittest.cc +++ b/chrome/browser/sync/about_sync_util_unittest.cc @@ -26,7 +26,7 @@ TEST(SyncUIUtilTestAbout, ConstructAboutInformationWithUnrecoverableErrorTest) { NiceMock<ProfileSyncServiceMock> service(profile.get()); // Will be released when the dictionary is destroyed - base::string16 str(ASCIIToUTF16("none")); + base::string16 str(base::ASCIIToUTF16("none")); browser_sync::SyncBackendHost::Status status; diff --git a/chrome/browser/sync/glue/bookmark_change_processor.cc b/chrome/browser/sync/glue/bookmark_change_processor.cc index 9b0285f..fb26475 100644 --- a/chrome/browser/sync/glue/bookmark_change_processor.cc +++ b/chrome/browser/sync/glue/bookmark_change_processor.cc @@ -704,7 +704,7 @@ void BookmarkChangeProcessor::UpdateBookmarkWithSyncData( sync_node.GetBookmarkSpecifics(); if (!sync_node.GetIsFolder()) model->SetURL(node, GURL(specifics.url())); - model->SetTitle(node, UTF8ToUTF16(sync_node.GetTitle())); + model->SetTitle(node, base::UTF8ToUTF16(sync_node.GetTitle())); if (specifics.has_creation_time_us()) { model->SetDateAdded( node, @@ -740,7 +740,8 @@ const BookmarkNode* BookmarkChangeProcessor::CreateBookmarkNode( const BookmarkNode* node; if (sync_node->GetIsFolder()) { - node = model->AddFolder(parent, index, UTF8ToUTF16(sync_node->GetTitle())); + node = model->AddFolder( + parent, index, base::UTF8ToUTF16(sync_node->GetTitle())); } else { // 'creation_time_us' was added in m24. Assume a time of 0 means now. const sync_pb::BookmarkSpecifics& specifics = @@ -749,7 +750,8 @@ const BookmarkNode* BookmarkChangeProcessor::CreateBookmarkNode( base::Time create_time = (create_time_internal == 0) ? base::Time::Now() : base::Time::FromInternalValue(create_time_internal); node = model->AddURLWithCreationTime(parent, index, - UTF8ToUTF16(sync_node->GetTitle()), + base::UTF8ToUTF16( + sync_node->GetTitle()), GURL(specifics.url()), create_time); if (node) SetBookmarkFavicon(sync_node, node, model, profile); diff --git a/chrome/browser/sync/glue/bookmark_model_associator.cc b/chrome/browser/sync/glue/bookmark_model_associator.cc index a08669f..5e6a3c5 100644 --- a/chrome/browser/sync/glue/bookmark_model_associator.cc +++ b/chrome/browser/sync/glue/bookmark_model_associator.cc @@ -131,7 +131,7 @@ const BookmarkNode* BookmarkNodeFinder::FindBookmarkNode( const GURL& url, const std::string& title, bool is_folder) { // Create a bookmark node from the given bookmark attributes. BookmarkNode temp_node(url); - temp_node.SetTitle(UTF8ToUTF16(title)); + temp_node.SetTitle(base::UTF8ToUTF16(title)); if (is_folder) temp_node.set_type(BookmarkNode::FOLDER); else @@ -326,7 +326,7 @@ bool BookmarkModelAssociator::SyncModelHasUserCreatedNodes(bool* has_nodes) { bool BookmarkModelAssociator::NodesMatch( const BookmarkNode* bookmark, const syncer::BaseNode* sync_node) const { - if (bookmark->GetTitle() != UTF8ToUTF16(sync_node->GetTitle())) + if (bookmark->GetTitle() != base::UTF8ToUTF16(sync_node->GetTitle())) return false; if (bookmark->is_folder() != sync_node->GetIsFolder()) return false; diff --git a/chrome/browser/sync/glue/generic_change_processor.cc b/chrome/browser/sync/glue/generic_change_processor.cc index 6d6b6aa..9193192 100644 --- a/chrome/browser/sync/glue/generic_change_processor.cc +++ b/chrome/browser/sync/glue/generic_change_processor.cc @@ -411,7 +411,7 @@ syncer::SyncError GenericChangeProcessor::ProcessSyncChanges( } } } - sync_node.SetTitle(UTF8ToWide(change.sync_data().GetTitle())); + sync_node.SetTitle(base::UTF8ToWide(change.sync_data().GetTitle())); SetNodeSpecifics(change.sync_data().GetSpecifics(), &sync_node); if (merge_result_.get()) { merge_result_->set_num_items_added(merge_result_->num_items_added() + @@ -504,7 +504,7 @@ syncer::SyncError GenericChangeProcessor::ProcessSyncChanges( } } - sync_node.SetTitle(UTF8ToWide(change.sync_data().GetTitle())); + sync_node.SetTitle(base::UTF8ToWide(change.sync_data().GetTitle())); SetNodeSpecifics(change.sync_data().GetSpecifics(), &sync_node); if (merge_result_.get()) { merge_result_->set_num_items_modified( diff --git a/chrome/browser/sync/glue/password_model_associator.cc b/chrome/browser/sync/glue/password_model_associator.cc index 9abea43..ade8d6b 100644 --- a/chrome/browser/sync/glue/password_model_associator.cc +++ b/chrome/browser/sync/glue/password_model_associator.cc @@ -21,6 +21,8 @@ #include "sync/internal_api/public/write_transaction.h" #include "sync/protocol/password_specifics.pb.h" +using base::UTF8ToUTF16; +using base::UTF16ToUTF8; using content::BrowserThread; namespace browser_sync { diff --git a/chrome/browser/sync/glue/session_model_associator.cc b/chrome/browser/sync/glue/session_model_associator.cc index 40711bd..9321542 100644 --- a/chrome/browser/sync/glue/session_model_associator.cc +++ b/chrome/browser/sync/glue/session_model_associator.cc @@ -635,7 +635,7 @@ syncer::SyncError SessionModelAssociator::AssociateModels( // Write the initial values to the specifics so that in case of a crash or // error we don't persist a half-written node. - write_node.SetTitle(UTF8ToWide(current_machine_tag_)); + write_node.SetTitle(base::UTF8ToWide(current_machine_tag_)); sync_pb::SessionSpecifics base_specifics; base_specifics.set_session_tag(current_machine_tag_); sync_pb::SessionHeader* header_s = base_specifics.mutable_header(); diff --git a/chrome/browser/sync/glue/session_sync_test_helper.cc b/chrome/browser/sync/glue/session_sync_test_helper.cc index 401db7c..d908288 100644 --- a/chrome/browser/sync/glue/session_sync_test_helper.cc +++ b/chrome/browser/sync/glue/session_sync_test_helper.cc @@ -84,7 +84,7 @@ void SessionSyncTestHelper::VerifySyncedSession( ASSERT_EQ(tab->navigations[0].virtual_url(), GURL(kVirtualUrl)); ASSERT_EQ(tab->navigations[0].referrer().url, GURL(kReferrer)); ASSERT_EQ(tab->navigations[0].title(), - base::string16(ASCIIToUTF16(kTitle))); + base::ASCIIToUTF16(kTitle)); ASSERT_EQ(tab->navigations[0].transition_type(), content::PAGE_TRANSITION_TYPED); } diff --git a/chrome/browser/sync/glue/synced_device_tracker.cc b/chrome/browser/sync/glue/synced_device_tracker.cc index fd38bc8..0c8085a 100644 --- a/chrome/browser/sync/glue/synced_device_tracker.cc +++ b/chrome/browser/sync/glue/synced_device_tracker.cc @@ -179,7 +179,7 @@ void SyncedDeviceTracker::WriteDeviceInfo( if (node.InitByClientTagLookup(syncer::DEVICE_INFO, tag) == syncer::BaseNode::INIT_OK) { node.SetDeviceInfoSpecifics(specifics); - node.SetTitle(UTF8ToWide(specifics.client_name())); + node.SetTitle(base::UTF8ToWide(specifics.client_name())); } else { syncer::ReadNode type_root(&trans); syncer::BaseNode::InitByLookupResult type_root_lookup_result = @@ -193,7 +193,7 @@ void SyncedDeviceTracker::WriteDeviceInfo( tag); DCHECK_EQ(syncer::WriteNode::INIT_SUCCESS, create_result); new_node.SetDeviceInfoSpecifics(specifics); - new_node.SetTitle(UTF8ToWide(specifics.client_name())); + new_node.SetTitle(base::UTF8ToWide(specifics.client_name())); } } diff --git a/chrome/browser/sync/glue/synced_session_tracker.cc b/chrome/browser/sync/glue/synced_session_tracker.cc index 6f6f3e4..1d2e770 100644 --- a/chrome/browser/sync/glue/synced_session_tracker.cc +++ b/chrome/browser/sync/glue/synced_session_tracker.cc @@ -197,7 +197,7 @@ bool SyncedSessionTracker::DeleteOldSessionTabIfNecessary( SessionTab* tab_ptr = tab_wrapper.tab_ptr; std::string title; if (tab_ptr->navigations.size() > 0) { - title = " (" + UTF16ToUTF8( + title = " (" + base::UTF16ToUTF8( tab_ptr->navigations[tab_ptr->navigations.size()-1].title()) + ")"; } DVLOG(1) << "Deleting closed tab " << tab_ptr->tab_id.id() << title @@ -341,7 +341,7 @@ SessionTab* SyncedSessionTracker::GetTabImpl( if (VLOG_IS_ON(1)) { std::string title; if (tab_ptr->navigations.size() > 0) { - title = " (" + UTF16ToUTF8( + title = " (" + base::UTF16ToUTF8( tab_ptr->navigations[tab_ptr->navigations.size()-1].title()) + ")"; } DVLOG(1) << "Getting " diff --git a/chrome/browser/sync/glue/tab_node_pool.cc b/chrome/browser/sync/glue/tab_node_pool.cc index a16bb57..9ece54a 100644 --- a/chrome/browser/sync/glue/tab_node_pool.cc +++ b/chrome/browser/sync/glue/tab_node_pool.cc @@ -88,7 +88,7 @@ int TabNodePool::GetFreeTabNode() { } // We fill the new node with just enough data so that in case of a crash/bug // we can identify the node as our own on re-association and reuse it. - tab_node.SetTitle(UTF8ToWide(tab_node_tag)); + tab_node.SetTitle(base::UTF8ToWide(tab_node_tag)); sync_pb::SessionSpecifics specifics; specifics.set_session_tag(machine_tag_); specifics.set_tab_node_id(tab_node_id); diff --git a/chrome/browser/sync/glue/typed_url_change_processor.cc b/chrome/browser/sync/glue/typed_url_change_processor.cc index a5a2be8..0084eaf 100644 --- a/chrome/browser/sync/glue/typed_url_change_processor.cc +++ b/chrome/browser/sync/glue/typed_url_change_processor.cc @@ -173,7 +173,7 @@ bool TypedUrlChangeProcessor::CreateOrUpdateSyncNode( return false; } - create_node.SetTitle(UTF8ToWide(tag)); + create_node.SetTitle(base::UTF8ToWide(tag)); model_associator_->WriteToSyncNode(url, visit_vector, &create_node); } return true; diff --git a/chrome/browser/sync/glue/typed_url_model_associator.cc b/chrome/browser/sync/glue/typed_url_model_associator.cc index a2c989a..3c42750 100644 --- a/chrome/browser/sync/glue/typed_url_model_associator.cc +++ b/chrome/browser/sync/glue/typed_url_model_associator.cc @@ -304,7 +304,7 @@ syncer::SyncError TypedUrlModelAssociator::DoAssociateModels() { model_type()); } - node.SetTitle(UTF8ToWide(tag)); + node.SetTitle(base::UTF8ToWide(tag)); WriteToSyncNode(*ix, visits, &node); } @@ -573,7 +573,7 @@ TypedUrlModelAssociator::MergeResult TypedUrlModelAssociator::MergeUrls( return DIFF_UPDATE_NODE; // Convert these values only once. - base::string16 node_title(UTF8ToUTF16(node.title())); + base::string16 node_title(base::UTF8ToUTF16(node.title())); base::Time node_last_visit = base::Time::FromInternalValue( node.visits(node.visits_size() - 1)); @@ -690,7 +690,7 @@ void TypedUrlModelAssociator::WriteToTypedUrlSpecifics( visits.back().visit_time.ToInternalValue()); typed_url->set_url(url.url().spec()); - typed_url->set_title(UTF16ToUTF8(url.title())); + typed_url->set_title(base::UTF16ToUTF8(url.title())); typed_url->set_hidden(url.hidden()); DCHECK(CheckVisitOrdering(visits)); @@ -821,7 +821,7 @@ void TypedUrlModelAssociator::UpdateURLRowFromTypedUrlSpecifics( const sync_pb::TypedUrlSpecifics& typed_url, history::URLRow* new_url) { DCHECK_GT(typed_url.visits_size(), 0); CHECK_EQ(typed_url.visit_transitions_size(), typed_url.visits_size()); - new_url->set_title(UTF8ToUTF16(typed_url.title())); + new_url->set_title(base::UTF8ToUTF16(typed_url.title())); new_url->set_hidden(typed_url.hidden()); // Only provide the initial value for the last_visit field - after that, let // the history code update the last_visit field on its own. diff --git a/chrome/browser/sync/glue/typed_url_model_associator_unittest.cc b/chrome/browser/sync/glue/typed_url_model_associator_unittest.cc index e514876..9c899ff 100644 --- a/chrome/browser/sync/glue/typed_url_model_associator_unittest.cc +++ b/chrome/browser/sync/glue/typed_url_model_associator_unittest.cc @@ -31,7 +31,7 @@ class SyncTypedUrlModelAssociatorTest : public testing::Test { history::VisitVector* visits) { GURL gurl(url); history::URLRow history_url(gurl); - history_url.set_title(UTF8ToUTF16(title)); + history_url.set_title(base::UTF8ToUTF16(title)); history_url.set_typed_count(typed_count); history_url.set_last_visit( base::Time::FromInternalValue(last_visit)); diff --git a/chrome/browser/sync/profile_sync_service_android.cc b/chrome/browser/sync/profile_sync_service_android.cc index c0ce961..42e1929 100644 --- a/chrome/browser/sync/profile_sync_service_android.cc +++ b/chrome/browser/sync/profile_sync_service_android.cc @@ -324,7 +324,7 @@ ScopedJavaLocalRef<jstring> return base::android::ConvertUTF16ToJavaString(env, l10n_util::GetStringFUTF16( IDS_SYNC_ACCOUNT_SYNCING_TO_USER, - ASCIIToUTF16(sync_username))); + base::ASCIIToUTF16(sync_username))); } ScopedJavaLocalRef<jstring> diff --git a/chrome/browser/sync/profile_sync_service_autofill_unittest.cc b/chrome/browser/sync/profile_sync_service_autofill_unittest.cc index 9d8cbf3..3e73988 100644 --- a/chrome/browser/sync/profile_sync_service_autofill_unittest.cc +++ b/chrome/browser/sync/profile_sync_service_autofill_unittest.cc @@ -624,7 +624,8 @@ class ProfileSyncServiceAutofillTest syncer::WriteNode node(&trans); std::string tag = AutocompleteSyncableService::KeyToTag( - UTF16ToUTF8(entry.key().name()), UTF16ToUTF8(entry.key().value())); + base::UTF16ToUTF8(entry.key().name()), + base::UTF16ToUTF8(entry.key().value())); syncer::WriteNode::InitUniqueByCreationResult result = node.InitUniqueByCreation(syncer::AUTOFILL, autofill_root, tag); if (result != syncer::WriteNode::INIT_SUCCESS) @@ -680,8 +681,8 @@ class ProfileSyncServiceAutofillTest const sync_pb::AutofillSpecifics& autofill( child_node.GetAutofillSpecifics()); if (autofill.has_value()) { - AutofillKey key(UTF8ToUTF16(autofill.name()), - UTF8ToUTF16(autofill.value())); + AutofillKey key(base::UTF8ToUTF16(autofill.name()), + base::UTF8ToUTF16(autofill.value())); std::vector<base::Time> timestamps; int timestamps_count = autofill.usage_timestamp_size(); for (int i = 0; i < timestamps_count; ++i) { @@ -748,7 +749,8 @@ class ProfileSyncServiceAutofillTest if (time_shift1 > 0) timestamps.push_back(base_time + TimeDelta::FromSeconds(time_shift1)); return AutofillEntry( - AutofillKey(ASCIIToUTF16(name), ASCIIToUTF16(value)), timestamps); + AutofillKey(base::ASCIIToUTF16(name), base::ASCIIToUTF16(value)), + timestamps); } static AutofillEntry MakeAutofillEntry(const char* name, @@ -845,10 +847,11 @@ class FakeServerUpdater : public base::RefCountedThreadSafe<FakeServerUpdater> { // Create autofill protobuf. std::string tag = AutocompleteSyncableService::KeyToTag( - UTF16ToUTF8(entry_.key().name()), UTF16ToUTF8(entry_.key().value())); + base::UTF16ToUTF8(entry_.key().name()), + base::UTF16ToUTF8(entry_.key().value())); sync_pb::AutofillSpecifics new_autofill; - new_autofill.set_name(UTF16ToUTF8(entry_.key().name())); - new_autofill.set_value(UTF16ToUTF8(entry_.key().value())); + new_autofill.set_name(base::UTF16ToUTF8(entry_.key().name())); + new_autofill.set_value(base::UTF16ToUTF8(entry_.key().value())); const std::vector<base::Time>& ts(entry_.timestamps()); for (std::vector<base::Time>::const_iterator timestamp = ts.begin(); timestamp != ts.end(); ++timestamp) { diff --git a/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc b/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc index ab34e66..c8e7be8 100644 --- a/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc +++ b/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc @@ -183,7 +183,7 @@ class FakeServerChange { std::string old_title = node.GetTitle(); node.SetTitle(new_title); SetModified(id); - return UTF8ToWide(old_title); + return base::UTF8ToWide(old_title); } // Set a new parent and predecessor value. Return the old parent id. @@ -354,7 +354,7 @@ class ProfileSyncServiceBookmarkTest : public testing::Test { syncer::WriteNode node(trans); EXPECT_TRUE(node.InitBookmarkByCreation(bookmark_bar, NULL)); node.SetIsFolder(true); - node.SetTitle(ASCIIToWide(title)); + node.SetTitle(base::ASCIIToWide(title)); return node.GetId(); } @@ -382,7 +382,7 @@ class ProfileSyncServiceBookmarkTest : public testing::Test { syncer::WriteNode node(trans); EXPECT_TRUE(node.InitBookmarkByCreation(parent, NULL)); node.SetIsFolder(false); - node.SetTitle(ASCIIToWide(title)); + node.SetTitle(base::ASCIIToWide(title)); node.SetBookmarkSpecifics(specifics); return node.GetId(); @@ -468,7 +468,7 @@ class ProfileSyncServiceBookmarkTest : public testing::Test { return false; node.SetIsFolder(true); node.GetMutableEntryForTest()->PutUniqueServerTag(permanent_tags[i]); - node.SetTitle(UTF8ToWide(permanent_tags[i])); + node.SetTitle(base::UTF8ToWide(permanent_tags[i])); node.SetExternalId(0); last_child_id = node.GetId(); } @@ -565,7 +565,7 @@ class ProfileSyncServiceBookmarkTest : public testing::Test { ASSERT_TRUE(InitSyncNodeFromChromeNode(bnode, &gnode)); // Non-root node titles and parents must match. if (!model_->is_permanent_node(bnode)) { - EXPECT_EQ(bnode->GetTitle(), UTF8ToUTF16(gnode.GetTitle())); + EXPECT_EQ(bnode->GetTitle(), base::UTF8ToUTF16(gnode.GetTitle())); EXPECT_EQ( model_associator_->GetChromeNodeFromSyncId(gnode.GetParentId()), bnode->parent()); @@ -789,44 +789,45 @@ TEST_F(ProfileSyncServiceBookmarkTest, BookmarkModelOperations) { // Test addition. const BookmarkNode* folder = - model_->AddFolder(model_->other_node(), 0, ASCIIToUTF16("foobar")); + model_->AddFolder(model_->other_node(), 0, base::ASCIIToUTF16("foobar")); ExpectSyncerNodeMatching(folder); ExpectModelMatch(); const BookmarkNode* folder2 = - model_->AddFolder(folder, 0, ASCIIToUTF16("nested")); + model_->AddFolder(folder, 0, base::ASCIIToUTF16("nested")); ExpectSyncerNodeMatching(folder2); ExpectModelMatch(); const BookmarkNode* url1 = model_->AddURL( - folder, 0, ASCIIToUTF16("Internets #1 Pies Site"), + folder, 0, base::ASCIIToUTF16("Internets #1 Pies Site"), GURL("http://www.easypie.com/")); ExpectSyncerNodeMatching(url1); ExpectModelMatch(); const BookmarkNode* url2 = model_->AddURL( - folder, 1, ASCIIToUTF16("Airplanes"), GURL("http://www.easyjet.com/")); + folder, 1, base::ASCIIToUTF16("Airplanes"), + GURL("http://www.easyjet.com/")); ExpectSyncerNodeMatching(url2); ExpectModelMatch(); // Test addition. const BookmarkNode* mobile_folder = - model_->AddFolder(model_->mobile_node(), 0, ASCIIToUTF16("pie")); + model_->AddFolder(model_->mobile_node(), 0, base::ASCIIToUTF16("pie")); ExpectSyncerNodeMatching(mobile_folder); ExpectModelMatch(); // Test modification. - model_->SetTitle(url2, ASCIIToUTF16("EasyJet")); + model_->SetTitle(url2, base::ASCIIToUTF16("EasyJet")); ExpectModelMatch(); model_->Move(url1, folder2, 0); ExpectModelMatch(); model_->Move(folder2, model_->bookmark_bar_node(), 0); ExpectModelMatch(); - model_->SetTitle(folder2, ASCIIToUTF16("Not Nested")); + model_->SetTitle(folder2, base::ASCIIToUTF16("Not Nested")); ExpectModelMatch(); model_->Move(folder, folder2, 0); ExpectModelMatch(); - model_->SetTitle(folder, ASCIIToUTF16("who's nested now?")); + model_->SetTitle(folder, base::ASCIIToUTF16("who's nested now?")); ExpectModelMatch(); model_->Copy(url2, model_->bookmark_bar_node(), 0); ExpectModelMatch(); - model_->SetTitle(mobile_folder, ASCIIToUTF16("strawberry")); + model_->SetTitle(mobile_folder, base::ASCIIToUTF16("strawberry")); ExpectModelMatch(); // Test deletion. @@ -1076,8 +1077,8 @@ TEST_F(ProfileSyncServiceBookmarkTest, CornerCaseNames) { // Create both folders and bookmarks using each name. GURL url("http://www.doublemint.com"); for (size_t i = 0; i < arraysize(names); ++i) { - model_->AddFolder(model_->other_node(), 0, ASCIIToUTF16(names[i])); - model_->AddURL(model_->other_node(), 0, ASCIIToUTF16(names[i]), url); + model_->AddFolder(model_->other_node(), 0, base::ASCIIToUTF16(names[i])); + model_->AddURL(model_->other_node(), 0, base::ASCIIToUTF16(names[i]), url); } // Verify that the browser model matches the sync model. @@ -1096,15 +1097,15 @@ TEST_F(ProfileSyncServiceBookmarkTest, RepeatedMiddleInsertion) { static const int kTimesToInsert = 256; // Create two book-end nodes to insert between. - model_->AddFolder(model_->other_node(), 0, ASCIIToUTF16("Alpha")); - model_->AddFolder(model_->other_node(), 1, ASCIIToUTF16("Omega")); + model_->AddFolder(model_->other_node(), 0, base::ASCIIToUTF16("Alpha")); + model_->AddFolder(model_->other_node(), 1, base::ASCIIToUTF16("Omega")); int count = 2; // Test insertion in first half of range by repeatedly inserting in second // position. for (int i = 0; i < kTimesToInsert; ++i) { base::string16 title = - ASCIIToUTF16("Pre-insertion ") + base::IntToString16(i); + base::ASCIIToUTF16("Pre-insertion ") + base::IntToString16(i); model_->AddFolder(model_->other_node(), 1, title); count++; } @@ -1113,7 +1114,7 @@ TEST_F(ProfileSyncServiceBookmarkTest, RepeatedMiddleInsertion) { // second-to-last position. for (int i = 0; i < kTimesToInsert; ++i) { base::string16 title = - ASCIIToUTF16("Post-insertion ") + base::IntToString16(i); + base::ASCIIToUTF16("Post-insertion ") + base::IntToString16(i); model_->AddFolder(model_->other_node(), count - 1, title); count++; } @@ -1134,7 +1135,7 @@ TEST_F(ProfileSyncServiceBookmarkTest, UnrecoverableErrorSuspendsService) { // Add a node which will be the target of the consistency violation. const BookmarkNode* node = - model_->AddFolder(model_->other_node(), 0, ASCIIToUTF16("node")); + model_->AddFolder(model_->other_node(), 0, base::ASCIIToUTF16("node")); ExpectSyncerNodeMatching(node); // Now destroy the syncer node as if we were the ProfileSyncService without @@ -1152,7 +1153,7 @@ TEST_F(ProfileSyncServiceBookmarkTest, UnrecoverableErrorSuspendsService) { // Add a child to the inconsistent node. This should cause detection of the // problem and the syncer should stop processing changes. - model_->AddFolder(node, 0, ASCIIToUTF16("nested")); + model_->AddFolder(node, 0, base::ASCIIToUTF16("nested")); } // See what happens if we run model association when there are two exact URL @@ -1162,9 +1163,9 @@ TEST_F(ProfileSyncServiceBookmarkTest, MergeDuplicates) { LoadBookmarkModel(DELETE_EXISTING_STORAGE, SAVE_TO_STORAGE); StartSync(); - model_->AddURL(model_->other_node(), 0, ASCIIToUTF16("Dup"), + model_->AddURL(model_->other_node(), 0, base::ASCIIToUTF16("Dup"), GURL("http://dup.com/")); - model_->AddURL(model_->other_node(), 0, ASCIIToUTF16("Dup"), + model_->AddURL(model_->other_node(), 0, base::ASCIIToUTF16("Dup"), GURL("http://dup.com/")); EXPECT_EQ(2, model_->other_node()->child_count()); @@ -1230,7 +1231,7 @@ TEST_F(ProfileSyncServiceBookmarkTest, ApplySyncDeletesFromJournal) { // Add a bookmark under f1 when sync is off so that f1 will not be // deleted even when f1 matches delete journal because it's not empty. model_->AddURL(model_->bookmark_bar_node()->GetChild(1), - 0, UTF8ToUTF16("local"), GURL("http://www.youtube.com")); + 0, base::UTF8ToUTF16("local"), GURL("http://www.youtube.com")); // Sync model has fixed bookmarks nodes and u3. EXPECT_EQ(fixed_sync_bk_count + 1, GetSyncBookmarkCount()); StartSync(); @@ -1238,11 +1239,11 @@ TEST_F(ProfileSyncServiceBookmarkTest, ApplySyncDeletesFromJournal) { // by delete journal, f1 is not removed by delete journal because it's // not empty due to www.youtube.com added above. EXPECT_EQ(4, model_->bookmark_bar_node()->GetTotalNodeCount()); - EXPECT_EQ(UTF8ToUTF16("URL 0"), + EXPECT_EQ(base::UTF8ToUTF16("URL 0"), model_->bookmark_bar_node()->GetChild(0)->GetTitle()); - EXPECT_EQ(UTF8ToUTF16("Folder 1"), + EXPECT_EQ(base::UTF8ToUTF16("Folder 1"), model_->bookmark_bar_node()->GetChild(1)->GetTitle()); - EXPECT_EQ(UTF8ToUTF16("local"), + EXPECT_EQ(base::UTF8ToUTF16("local"), model_->bookmark_bar_node()->GetChild(1)->GetChild(0)->GetTitle()); StopSync(); @@ -1776,7 +1777,7 @@ TEST_F(ProfileSyncServiceBookmarkTestWithData, // the situation where bookmark model is different from sync model and // make sure model associator correctly rebuilds associations. const BookmarkNode* bookmark_bar_node = model_->bookmark_bar_node(); - model_->AddURL(bookmark_bar_node, 0, ASCIIToUTF16("xtra"), + model_->AddURL(bookmark_bar_node, 0, base::ASCIIToUTF16("xtra"), GURL("http://www.xtra.com")); // Now restart sync. This time it will try to use the persistent // associations and realize that they are invalid and hence will rebuild @@ -1956,9 +1957,9 @@ TEST_F(ProfileSyncServiceBookmarkTestWithData, UpdateMetaInfoFromModel) { const BookmarkNode* folder_node = model_->AddFolder(model_->bookmark_bar_node(), 0, - ASCIIToUTF16("folder title")); + base::ASCIIToUTF16("folder title")); const BookmarkNode* node = model_->AddURL(folder_node, 0, - ASCIIToUTF16("node title"), + base::ASCIIToUTF16("node title"), GURL("http://www.foo.com")); ExpectModelMatch(); diff --git a/chrome/browser/sync/profile_sync_service_password_unittest.cc b/chrome/browser/sync/profile_sync_service_password_unittest.cc index 9721a9e..4dd1efd 100644 --- a/chrome/browser/sync/profile_sync_service_password_unittest.cc +++ b/chrome/browser/sync/profile_sync_service_password_unittest.cc @@ -50,6 +50,7 @@ using autofill::PasswordForm; using base::Time; +using base::UTF8ToUTF16; using browser_sync::PasswordChangeProcessor; using browser_sync::PasswordDataTypeController; using browser_sync::PasswordModelAssociator; diff --git a/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc b/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc index 2e43f4c..6e3fa48 100644 --- a/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc +++ b/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc @@ -267,7 +267,7 @@ class ProfileSyncServiceTypedUrlTest : public AbstractProfileSyncServiceTest { child_node.GetTypedUrlSpecifics()); history::URLRow new_url(GURL(typed_url.url())); - new_url.set_title(UTF8ToUTF16(typed_url.title())); + new_url.set_title(base::UTF8ToUTF16(typed_url.title())); DCHECK(typed_url.visits_size()); DCHECK_EQ(typed_url.visits_size(), typed_url.visit_transitions_size()); new_url.set_last_visit(base::Time::FromInternalValue( @@ -306,7 +306,7 @@ class ProfileSyncServiceTypedUrlTest : public AbstractProfileSyncServiceTest { static int unique_url_id = 0; GURL gurl(url); URLRow history_url(gurl, ++unique_url_id); - history_url.set_title(UTF8ToUTF16(title)); + history_url.set_title(base::UTF8ToUTF16(title)); history_url.set_typed_count(typed_count); history_url.set_last_visit( base::Time::FromInternalValue(last_visit)); diff --git a/chrome/browser/sync/sync_ui_util.cc b/chrome/browser/sync/sync_ui_util.cc index d35bfd4..46f7072 100644 --- a/chrome/browser/sync/sync_ui_util.cc +++ b/chrome/browser/sync/sync_ui_util.cc @@ -47,7 +47,8 @@ namespace { base::string16 GetSyncedStateStatusLabel(ProfileSyncService* service, const SigninManagerBase& signin, StatusLabelStyle style) { - base::string16 user_name = UTF8ToUTF16(signin.GetAuthenticatedUsername()); + base::string16 user_name = + base::UTF8ToUTF16(signin.GetAuthenticatedUsername()); if (!user_name.empty()) { if (!service || service->IsManaged()) { @@ -78,7 +79,7 @@ base::string16 GetSyncedStateStatusLabel(ProfileSyncService* service, return l10n_util::GetStringFUTF16( IDS_SYNC_ACCOUNT_SYNCING_TO_USER_WITH_MANAGE_LINK, user_name, - ASCIIToUTF16(chrome::kSyncGoogleDashboardURL)); + base::ASCIIToUTF16(chrome::kSyncGoogleDashboardURL)); default: NOTREACHED(); return NULL; @@ -253,8 +254,8 @@ MessageType GetStatusInfo(ProfileSyncService* service, // The user is signed in, but sync has been stopped. if (status_label) { base::string16 label = l10n_util::GetStringFUTF16( - IDS_SIGNED_IN_WITH_SYNC_SUPPRESSED, - UTF8ToUTF16(signin.GetAuthenticatedUsername())); + IDS_SIGNED_IN_WITH_SYNC_SUPPRESSED, + base::UTF8ToUTF16(signin.GetAuthenticatedUsername())); status_label->assign(label); result_type = PRE_SYNCED; } diff --git a/chrome/browser/sync/sync_ui_util_unittest.cc b/chrome/browser/sync/sync_ui_util_unittest.cc index 6ff6d99..7728606 100644 --- a/chrome/browser/sync/sync_ui_util_unittest.cc +++ b/chrome/browser/sync/sync_ui_util_unittest.cc @@ -348,7 +348,7 @@ TEST_F(SyncUIUtilTest, DistinctCasesReportUniqueMessageSets) { EXPECT_FALSE(status_label.empty()) << "Empty status label returned for case #" << idx; base::string16 combined_label = - status_label + base::string16(ASCIIToUTF16("#")) + link_label; + status_label + base::ASCIIToUTF16("#") + link_label; EXPECT_TRUE(messages.find(combined_label) == messages.end()) << "Duplicate message for case #" << idx << ": " << combined_label; messages.insert(combined_label); @@ -387,7 +387,7 @@ TEST_F(SyncUIUtilTest, HtmlNotIncludedInStatusIfNotRequested) { // found in an English language message) fails when links are excluded from // the status label. EXPECT_FALSE(status_label.empty()); - EXPECT_EQ(status_label.find(base::string16(ASCIIToUTF16("href"))), + EXPECT_EQ(status_label.find(base::ASCIIToUTF16("href")), base::string16::npos); testing::Mock::VerifyAndClearExpectations(&service); testing::Mock::VerifyAndClearExpectations(&signin); diff --git a/chrome/browser/sync/test/integration/bookmarks_helper.cc b/chrome/browser/sync/test/integration/bookmarks_helper.cc index 27d5e56..7ecb916 100644 --- a/chrome/browser/sync/test/integration/bookmarks_helper.cc +++ b/chrome/browser/sync/test/integration/bookmarks_helper.cc @@ -427,7 +427,7 @@ const BookmarkNode* AddURL(int profile, return NULL; } const BookmarkNode* result = GetBookmarkModel(profile)-> - AddURL(parent, index, WideToUTF16(title), url); + AddURL(parent, index, base::WideToUTF16(title), url); if (!result) { LOG(ERROR) << "Could not add bookmark " << title << " to Profile " << profile; @@ -437,7 +437,7 @@ const BookmarkNode* AddURL(int profile, const BookmarkNode* v_parent = NULL; FindNodeInVerifier(GetBookmarkModel(profile), parent, &v_parent); const BookmarkNode* v_node = GetVerifierBookmarkModel()-> - AddURL(v_parent, index, WideToUTF16(title), url); + AddURL(v_parent, index, base::WideToUTF16(title), url); if (!v_node) { LOG(ERROR) << "Could not add bookmark " << title << " to the verifier"; return NULL; @@ -467,8 +467,8 @@ const BookmarkNode* AddFolder(int profile, << "Profile " << profile; return NULL; } - const BookmarkNode* result = - GetBookmarkModel(profile)->AddFolder(parent, index, WideToUTF16(title)); + const BookmarkNode* result = GetBookmarkModel(profile)->AddFolder( + parent, index, base::WideToUTF16(title)); EXPECT_TRUE(result); if (!result) { LOG(ERROR) << "Could not add folder " << title << " to Profile " @@ -479,7 +479,7 @@ const BookmarkNode* AddFolder(int profile, const BookmarkNode* v_parent = NULL; FindNodeInVerifier(GetBookmarkModel(profile), parent, &v_parent); const BookmarkNode* v_node = GetVerifierBookmarkModel()->AddFolder( - v_parent, index, WideToUTF16(title)); + v_parent, index, base::WideToUTF16(title)); if (!v_node) { LOG(ERROR) << "Could not add folder " << title << " to the verifier"; return NULL; @@ -498,9 +498,9 @@ void SetTitle(int profile, if (test()->use_verifier()) { const BookmarkNode* v_node = NULL; FindNodeInVerifier(GetBookmarkModel(profile), node, &v_node); - GetVerifierBookmarkModel()->SetTitle(v_node, WideToUTF16(new_title)); + GetVerifierBookmarkModel()->SetTitle(v_node, base::WideToUTF16(new_title)); } - GetBookmarkModel(profile)->SetTitle(node, WideToUTF16(new_title)); + GetBookmarkModel(profile)->SetTitle(node, base::WideToUTF16(new_title)); } void SetFavicon(int profile, @@ -698,13 +698,13 @@ const BookmarkNode* GetUniqueNodeByURL(int profile, const GURL& url) { int CountBookmarksWithTitlesMatching(int profile, const std::wstring& title) { return CountNodesWithTitlesMatching(GetBookmarkModel(profile), BookmarkNode::URL, - WideToUTF16(title)); + base::WideToUTF16(title)); } int CountFoldersWithTitlesMatching(int profile, const std::wstring& title) { return CountNodesWithTitlesMatching(GetBookmarkModel(profile), BookmarkNode::FOLDER, - WideToUTF16(title)); + base::WideToUTF16(title)); } gfx::Image CreateFavicon(SkColor color) { diff --git a/chrome/browser/sync/test/integration/multiple_client_typed_urls_sync_test.cc b/chrome/browser/sync/test/integration/multiple_client_typed_urls_sync_test.cc index 16d7407..ec81db8 100644 --- a/chrome/browser/sync/test/integration/multiple_client_typed_urls_sync_test.cc +++ b/chrome/browser/sync/test/integration/multiple_client_typed_urls_sync_test.cc @@ -27,7 +27,7 @@ class MultipleClientTypedUrlsSyncTest : public SyncTest { // TCM: 3728323 IN_PROC_BROWSER_TEST_F(MultipleClientTypedUrlsSyncTest, AddToOne) { const base::string16 kHistoryUrl( - ASCIIToUTF16("http://www.add-one-history.google.com/")); + base::ASCIIToUTF16("http://www.add-one-history.google.com/")); ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; // Populate one client with a URL, should sync to all others. @@ -46,7 +46,7 @@ IN_PROC_BROWSER_TEST_F(MultipleClientTypedUrlsSyncTest, AddToOne) { IN_PROC_BROWSER_TEST_F(MultipleClientTypedUrlsSyncTest, AddToAll) { const base::string16 kHistoryUrl( - ASCIIToUTF16("http://www.add-all-history.google.com/")); + base::ASCIIToUTF16("http://www.add-all-history.google.com/")); ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; // Populate clients with the same URL. diff --git a/chrome/browser/sync/test/integration/passwords_helper.cc b/chrome/browser/sync/test/integration/passwords_helper.cc index ccab9ef..ba78470 100644 --- a/chrome/browser/sync/test/integration/passwords_helper.cc +++ b/chrome/browser/sync/test/integration/passwords_helper.cc @@ -216,8 +216,10 @@ PasswordForm CreateTestPasswordForm(int index) { PasswordForm form; form.signon_realm = kFakeSignonRealm; form.origin = GURL(base::StringPrintf(kIndexedFakeOrigin, index)); - form.username_value = ASCIIToUTF16(base::StringPrintf("username%d", index)); - form.password_value = ASCIIToUTF16(base::StringPrintf("password%d", index)); + form.username_value = + base::ASCIIToUTF16(base::StringPrintf("username%d", index)); + form.password_value = + base::ASCIIToUTF16(base::StringPrintf("password%d", index)); form.date_created = base::Time::Now(); return form; } diff --git a/chrome/browser/sync/test/integration/performance/autofill_sync_perf_test.cc b/chrome/browser/sync/test/integration/performance/autofill_sync_perf_test.cc index 3a06587..5a74e7d 100644 --- a/chrome/browser/sync/test/integration/performance/autofill_sync_perf_test.cc +++ b/chrome/browser/sync/test/integration/performance/autofill_sync_perf_test.cc @@ -104,7 +104,7 @@ void AutofillSyncPerfTest::UpdateProfiles(int profile) { for (size_t i = 0; i < all_profiles.size(); ++i) { autofill_profiles.push_back(*all_profiles[i]); autofill_profiles.back().SetRawInfo(autofill::NAME_FIRST, - UTF8ToUTF16(NextName())); + base::UTF8ToUTF16(NextName())); } SetProfiles(profile, &autofill_profiles); } diff --git a/chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc b/chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc index 74928a7..4a9b7bd7 100644 --- a/chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc +++ b/chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc @@ -54,7 +54,7 @@ void PasswordsSyncPerfTest::UpdateLogins(int profile) { GetLogins(GetPasswordStore(profile), logins); for (std::vector<autofill::PasswordForm>::iterator it = logins.begin(); it != logins.end(); ++it) { - (*it).password_value = ASCIIToUTF16(NextPassword()); + (*it).password_value = base::ASCIIToUTF16(NextPassword()); UpdateLogin(GetPasswordStore(profile), (*it)); } } diff --git a/chrome/browser/sync/test/integration/search_engines_helper.cc b/chrome/browser/sync/test/integration/search_engines_helper.cc index 5445d95..2a1baa1 100644 --- a/chrome/browser/sync/test/integration/search_engines_helper.cc +++ b/chrome/browser/sync/test/integration/search_engines_helper.cc @@ -108,7 +108,7 @@ bool ServicesMatch(int profile_a, int profile_b) { // Convenience helper for consistently generating the same keyword for a given // seed. base::string16 CreateKeyword(int seed) { - return ASCIIToUTF16(base::StringPrintf("test%d", seed)); + return base::ASCIIToUTF16(base::StringPrintf("test%d", seed)); } } // namespace diff --git a/chrome/browser/sync/test/integration/two_client_autofill_sync_test.cc b/chrome/browser/sync/test/integration/two_client_autofill_sync_test.cc index fe2373c..ab876a2 100644 --- a/chrome/browser/sync/test/integration/two_client_autofill_sync_test.cc +++ b/chrome/browser/sync/test/integration/two_client_autofill_sync_test.cc @@ -108,8 +108,8 @@ IN_PROC_BROWSER_TEST_F(TwoClientAutofillSyncTest, AddUnicodeProfile) { ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; std::set<AutofillKey> keys; - keys.insert(AutofillKey(WideToUTF16(L"Sigur R\u00F3s"), - WideToUTF16(L"\u00C1g\u00E6tis byrjun"))); + keys.insert(AutofillKey(base::WideToUTF16(L"Sigur R\u00F3s"), + base::WideToUTF16(L"\u00C1g\u00E6tis byrjun"))); AddKeys(0, keys); ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; ASSERT_TRUE(AwaitQuiescence()); @@ -188,7 +188,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientAutofillSyncTest, UpdateProfile(0, GetAllProfiles(0)[0]->guid(), AutofillType(autofill::NAME_FIRST), - ASCIIToUTF16("Bart")); + base::ASCIIToUTF16("Bart")); MakeABookmarkChange(0); ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1))); ASSERT_TRUE(ProfilesMatch(0, 1)); @@ -221,7 +221,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientAutofillSyncTest, SameProfileWithConflict) { AutofillProfile profile0 = CreateAutofillProfile(PROFILE_HOMER); AutofillProfile profile1 = CreateAutofillProfile(PROFILE_HOMER); profile1.SetRawInfo(autofill::PHONE_HOME_WHOLE_NUMBER, - ASCIIToUTF16("1234567890")); + base::ASCIIToUTF16("1234567890")); AddProfile(0, profile0); AddProfile(1, profile1); @@ -308,11 +308,11 @@ IN_PROC_BROWSER_TEST_F(TwoClientAutofillSyncTest, UpdateFields) { UpdateProfile(0, GetAllProfiles(0)[0]->guid(), AutofillType(autofill::NAME_FIRST), - ASCIIToUTF16("Lisa")); + base::ASCIIToUTF16("Lisa")); UpdateProfile(0, GetAllProfiles(0)[0]->guid(), AutofillType(autofill::EMAIL_ADDRESS), - ASCIIToUTF16("grrrl@TV.com")); + base::ASCIIToUTF16("grrrl@TV.com")); MakeABookmarkChange(0); ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1))); ASSERT_TRUE(ProfilesMatch(0, 1)); @@ -332,12 +332,12 @@ IN_PROC_BROWSER_TEST_F(TwoClientAutofillSyncTest, DISABLED_ConflictingFields) { UpdateProfile(0, GetAllProfiles(0)[0]->guid(), AutofillType(autofill::NAME_FIRST), - ASCIIToUTF16("Lisa")); + base::ASCIIToUTF16("Lisa")); MakeABookmarkChange(0); UpdateProfile(1, GetAllProfiles(1)[0]->guid(), AutofillType(autofill::NAME_FIRST), - ASCIIToUTF16("Bart")); + base::ASCIIToUTF16("Bart")); MakeABookmarkChange(1); ASSERT_TRUE(AwaitQuiescence()); ASSERT_TRUE(ProfilesMatch(0, 1)); @@ -467,7 +467,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientAutofillSyncTest, NoCreditCardSync) { CreditCard card; card.SetRawInfo(autofill::CREDIT_CARD_NUMBER, - ASCIIToUTF16("6011111111111117")); + base::ASCIIToUTF16("6011111111111117")); std::vector<CreditCard> credit_cards; credit_cards.push_back(card); SetCreditCards(0, &credit_cards); diff --git a/chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc b/chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc index 1d4c7f9..b3bd68d 100644 --- a/chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc +++ b/chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc @@ -61,7 +61,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientPasswordsSyncTest, Race) { AddLogin(GetPasswordStore(0), form0); PasswordForm form1 = form0; - form1.password_value = ASCIIToUTF16("new_password"); + form1.password_value = base::ASCIIToUTF16("new_password"); AddLogin(GetPasswordStore(1), form1); ASSERT_TRUE(AwaitQuiescence()); @@ -155,7 +155,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientPasswordsSyncTest, Update) { AddLogin(GetPasswordStore(0), form); ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1))); - form.password_value = ASCIIToUTF16("new_password"); + form.password_value = base::ASCIIToUTF16("new_password"); UpdateLogin(GetVerifierPasswordStore(), form); UpdateLogin(GetPasswordStore(1), form); ASSERT_TRUE(AwaitQuiescence()); diff --git a/chrome/browser/sync/test/integration/two_client_search_engines_sync_test.cc b/chrome/browser/sync/test/integration/two_client_search_engines_sync_test.cc index 1719bd0..69811b9 100644 --- a/chrome/browser/sync/test/integration/two_client_search_engines_sync_test.cc +++ b/chrome/browser/sync/test/integration/two_client_search_engines_sync_test.cc @@ -11,6 +11,8 @@ #include "chrome/browser/sync/test/integration/sync_datatype_helper.h" #include "chrome/browser/sync/test/integration/sync_test.h" +using base::ASCIIToUTF16; + class TwoClientSearchEnginesSyncTest : public SyncTest { public: TwoClientSearchEnginesSyncTest() : SyncTest(TWO_CLIENT) {} diff --git a/chrome/browser/sync/test/integration/two_client_typed_urls_sync_test.cc b/chrome/browser/sync/test/integration/two_client_typed_urls_sync_test.cc index ca5026e..85bd98c 100644 --- a/chrome/browser/sync/test/integration/two_client_typed_urls_sync_test.cc +++ b/chrome/browser/sync/test/integration/two_client_typed_urls_sync_test.cc @@ -12,6 +12,7 @@ #include "chrome/browser/sync/test/integration/sync_test.h" #include "chrome/browser/sync/test/integration/typed_urls_helper.h" +using base::ASCIIToUTF16; using typed_urls_helper::AddUrlToHistory; using typed_urls_helper::AddUrlToHistoryWithTimestamp; using typed_urls_helper::AddUrlToHistoryWithTransition; diff --git a/chrome/browser/sync/test/integration/typed_urls_helper.cc b/chrome/browser/sync/test/integration/typed_urls_helper.cc index c297fef..0c60665 100644 --- a/chrome/browser/sync/test/integration/typed_urls_helper.cc +++ b/chrome/browser/sync/test/integration/typed_urls_helper.cc @@ -165,7 +165,7 @@ void AddToHistory(HistoryService* service, transition, source, false); - service->SetPageTitle(url, ASCIIToUTF16(url.spec() + " - title")); + service->SetPageTitle(url, base::ASCIIToUTF16(url.spec() + " - title")); } history::URLRows GetTypedUrlsFromHistoryService(HistoryService* service) { |