diff options
| author | brettw@google.com <brettw@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-08-12 16:11:09 +0000 |
|---|---|---|
| committer | brettw@google.com <brettw@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-08-12 16:11:09 +0000 |
| commit | b6e09acf8ced26198871626c76bb5a3741cc51f1 (patch) | |
| tree | a4029d45393a1c34ba1b88d67c052512ad16c7eb /chrome/browser/tab_contents.h | |
| parent | 2526315929de99fa5762583621fb52b626a62ef9 (diff) | |
| download | chromium_src-b6e09acf8ced26198871626c76bb5a3741cc51f1.zip chromium_src-b6e09acf8ced26198871626c76bb5a3741cc51f1.tar.gz chromium_src-b6e09acf8ced26198871626c76bb5a3741cc51f1.tar.bz2 | |
Move RenderViewHost management out of WebContents into a new
RenderViewHostManager object.
The goal for this patch is to change no logic or APIs, just move the code. So
there are some not very clean callback functions and no new unit tests for this
file (although is is still covered by the same WebContents unit tests). This
should make the actual cleanup in a later pass much easier to follow.
I changed the ordering of only a few operations (like WebContents shutdown), and checked that this shouldn't matter. I had to change the "source" for several notifications since they are no longer sent from the WebContents.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@716 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/tab_contents.h')
| -rw-r--r-- | chrome/browser/tab_contents.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/chrome/browser/tab_contents.h b/chrome/browser/tab_contents.h index 76061c1..e83cd72 100644 --- a/chrome/browser/tab_contents.h +++ b/chrome/browser/tab_contents.h @@ -191,6 +191,9 @@ class TabContents : public PageNavigator, // Sets up a new NavigationController for this TabContents. // |profile| is the user profile that should be associated with // the new controller. + // + // TODO(brettw) this seems bogus and I couldn't find any legitimate need for + // it. I think it should be passed in the constructor. void SetupController(Profile* profile); // Returns the user profile associated with this TabContents (via the |