diff options
| author | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-23 18:14:28 +0000 |
|---|---|---|
| committer | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-23 18:14:28 +0000 |
| commit | 89622004872be7f7ddaa24fa1694f76c7b9539b6 (patch) | |
| tree | 81b8a42c7649c8cbca99d04305470ccbc1fe61fa /chrome/browser/tab_contents | |
| parent | b7544eef7b81458a88597419eed6617c41e6d3dc (diff) | |
| download | chromium_src-89622004872be7f7ddaa24fa1694f76c7b9539b6.zip chromium_src-89622004872be7f7ddaa24fa1694f76c7b9539b6.tar.gz chromium_src-89622004872be7f7ddaa24fa1694f76c7b9539b6.tar.bz2 | |
UMA cleanup. Replacing calls to RecordAction(char*) to use a new structure.
That way it is easier to keep track of those constants in reporting tools.
TEST=Covered with standard ui tests
Patch by Frank Mantek <fmantek@google.com>.
Review URL: http://codereview.chromium.org/811005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42362 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/tab_contents')
| -rw-r--r-- | chrome/browser/tab_contents/render_view_context_menu.cc | 18 |
1 files changed, 12 insertions, 6 deletions
diff --git a/chrome/browser/tab_contents/render_view_context_menu.cc b/chrome/browser/tab_contents/render_view_context_menu.cc index 30f7e32..1011fa9 100644 --- a/chrome/browser/tab_contents/render_view_context_menu.cc +++ b/chrome/browser/tab_contents/render_view_context_menu.cc @@ -923,35 +923,40 @@ void RenderViewContextMenu::ExecuteItemCommand(int id) { break; case IDS_CONTENT_CONTEXT_PLAY: - UserMetrics::RecordAction("MediaContextMenu_Play", profile_); + UserMetrics::RecordAction(UserMetricsAction("MediaContextMenu_Play"), + profile_); MediaPlayerActionAt(gfx::Point(params_.x, params_.y), WebMediaPlayerAction( WebMediaPlayerAction::Play, true)); break; case IDS_CONTENT_CONTEXT_PAUSE: - UserMetrics::RecordAction("MediaContextMenu_Pause", profile_); + UserMetrics::RecordAction(UserMetricsAction("MediaContextMenu_Pause"), + profile_); MediaPlayerActionAt(gfx::Point(params_.x, params_.y), WebMediaPlayerAction( WebMediaPlayerAction::Play, false)); break; case IDS_CONTENT_CONTEXT_MUTE: - UserMetrics::RecordAction("MediaContextMenu_Mute", profile_); + UserMetrics::RecordAction(UserMetricsAction("MediaContextMenu_Mute"), + profile_); MediaPlayerActionAt(gfx::Point(params_.x, params_.y), WebMediaPlayerAction( WebMediaPlayerAction::Mute, true)); break; case IDS_CONTENT_CONTEXT_UNMUTE: - UserMetrics::RecordAction("MediaContextMenu_Unmute", profile_); + UserMetrics::RecordAction(UserMetricsAction("MediaContextMenu_Unmute"), + profile_); MediaPlayerActionAt(gfx::Point(params_.x, params_.y), WebMediaPlayerAction( WebMediaPlayerAction::Mute, false)); break; case IDS_CONTENT_CONTEXT_LOOP: - UserMetrics::RecordAction("MediaContextMenu_Loop", profile_); + UserMetrics::RecordAction(UserMetricsAction("MediaContextMenu_Loop"), + profile_); MediaPlayerActionAt(gfx::Point(params_.x, params_.y), WebMediaPlayerAction( WebMediaPlayerAction::Loop, @@ -1204,7 +1209,8 @@ void RenderViewContextMenu::CopyImageAt(int x, int y) { } void RenderViewContextMenu::Inspect(int x, int y) { - UserMetrics::RecordAction("DevTools_InspectElement", profile_); + UserMetrics::RecordAction(UserMetricsAction("DevTools_InspectElement"), + profile_); DevToolsManager::GetInstance()->InspectElement( source_tab_contents_->render_view_host(), x, y); } |