diff options
| author | joi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-12-04 18:14:02 +0000 |
|---|---|---|
| committer | joi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-12-04 18:14:02 +0000 |
| commit | 96a5c34a1f1b97f6130d98ea950a48102c3ddcbe (patch) | |
| tree | 0cc7170429583dbb319e31945d5753d95a28214f /chrome/browser/tab_contents | |
| parent | 1799b5600ec29a3a099f3c217cb8063799169aba (diff) | |
| download | chromium_src-96a5c34a1f1b97f6130d98ea950a48102c3ddcbe.zip chromium_src-96a5c34a1f1b97f6130d98ea950a48102c3ddcbe.tar.gz chromium_src-96a5c34a1f1b97f6130d98ea950a48102c3ddcbe.tar.bz2 | |
Remove the last usages of PrefObserver outside of Prefs.
This involved:
a) Removing methods that used PrefObserver from PrefChangeRegistrar and PrefMember.
b) Removing implementation of PrefObserver from a few remaining classes.
c) Removing NULL PrefObserver parameter for classes using PrefMember but not wishing for a callback.
d) Updating unit tests and test utility classes.
Also fixed what was most likely a bug (or at least an unintentional change in behavior) that I had introduced in CoreChromeOSOptionsHandler in a previous change. Before my series of PrefObserver-related changes, there was polymorphism involved and the subclass was only handling pref changes for a couple of preferences (kProxy and kUseSharedProxy, only one of which it registers for itself) if the PrefService was the standard one, not the incognito one, otherwise delegating to the parent class.
TBR=ben@chromium.org
BUG=155525
Review URL: https://chromiumcodereview.appspot.com/11316163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171002 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/tab_contents')
| -rw-r--r-- | chrome/browser/tab_contents/spellchecker_submenu_observer_hunspell.cc | 3 | ||||
| -rw-r--r-- | chrome/browser/tab_contents/spelling_menu_observer.cc | 2 |
2 files changed, 2 insertions, 3 deletions
diff --git a/chrome/browser/tab_contents/spellchecker_submenu_observer_hunspell.cc b/chrome/browser/tab_contents/spellchecker_submenu_observer_hunspell.cc index f7e0233..7185ff0 100644 --- a/chrome/browser/tab_contents/spellchecker_submenu_observer_hunspell.cc +++ b/chrome/browser/tab_contents/spellchecker_submenu_observer_hunspell.cc @@ -153,8 +153,7 @@ void SpellCheckerSubMenuObserver::ExecuteCommand(int command_id) { if (profile && language < languages_.size()) { StringPrefMember dictionary_language; dictionary_language.Init(prefs::kSpellCheckDictionary, - profile->GetPrefs(), - NULL); + profile->GetPrefs()); dictionary_language.SetValue(languages_[language]); } return; diff --git a/chrome/browser/tab_contents/spelling_menu_observer.cc b/chrome/browser/tab_contents/spelling_menu_observer.cc index 98bbd0b..b3566fc 100644 --- a/chrome/browser/tab_contents/spelling_menu_observer.cc +++ b/chrome/browser/tab_contents/spelling_menu_observer.cc @@ -36,7 +36,7 @@ SpellingMenuObserver::SpellingMenuObserver(RenderViewContextMenuProxy* proxy) succeeded_(false) { if (proxy && proxy->GetProfile()) integrate_spelling_service_.Init(prefs::kSpellCheckUseSpellingService, - proxy->GetProfile()->GetPrefs(), NULL); + proxy->GetProfile()->GetPrefs()); } SpellingMenuObserver::~SpellingMenuObserver() { |