diff options
| author | darin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-04 18:30:43 +0000 |
|---|---|---|
| committer | darin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-04 18:30:43 +0000 |
| commit | b6987e0e556a5f72e5e783aae0e30e883cf66f91 (patch) | |
| tree | fb07c2c5803510285ef0d030d42eb6ced5a8d2b7 /chrome/browser/tab_contents | |
| parent | 53bc1a4364a3a75344e20f94aedff2eca2f6f9af (diff) | |
| download | chromium_src-b6987e0e556a5f72e5e783aae0e30e883cf66f91.zip chromium_src-b6987e0e556a5f72e5e783aae0e30e883cf66f91.tar.gz chromium_src-b6987e0e556a5f72e5e783aae0e30e883cf66f91.tar.bz2 | |
Simplify ExecuteJavaScript* functions.
Remove the "Java" and rename to ExecuteScript*. This better matches
conventions elsewhere in the codebase.
Introduce ExecuteScriptInFrame* variants for the less common case
where script execution in a subframe is desired.
Make it possible to pass the ExecuteScript* family of functions either
a WebContents pointer or a RenderViewHost pointer to further simplify
callsites.
R=jam@chromium.org
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11753009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175156 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/tab_contents')
| -rw-r--r-- | chrome/browser/tab_contents/view_source_browsertest.cc | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/chrome/browser/tab_contents/view_source_browsertest.cc b/chrome/browser/tab_contents/view_source_browsertest.cc index 32021cd..1236775 100644 --- a/chrome/browser/tab_contents/view_source_browsertest.cc +++ b/chrome/browser/tab_contents/view_source_browsertest.cc @@ -103,11 +103,8 @@ IN_PROC_BROWSER_TEST_F(ViewSourceTest, DISABLED_TestViewSourceReload) { ui_test_utils::NavigateToURL(browser(), url_viewsource); observer.Wait(); - content::RenderViewHost* rvh = - chrome::GetWebContentsAt(browser(), 0)->GetRenderViewHost(); - - ASSERT_TRUE( - content::ExecuteJavaScript(rvh, "", "window.location.reload();")); + ASSERT_TRUE(content::ExecuteScript(chrome::GetWebContentsAt(browser(), 0), + "window.location.reload();")); content::WindowedNotificationObserver observer2( content::NOTIFICATION_LOAD_STOP, |