summaryrefslogtreecommitdiffstats
path: root/chrome/browser/translate
diff options
context:
space:
mode:
authormad@chromium.org <mad@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-01-24 20:07:46 +0000
committermad@chromium.org <mad@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-01-24 20:07:46 +0000
commit7f8fdc7ac98c1543f837018c3ff034a0d4fbb26e (patch)
tree9eda9a1bf3c7ea7ab1b64ddefb107f3c8466e195 /chrome/browser/translate
parentbc50146bf7ed9d6a8043cadca454e383f77c9b5e (diff)
downloadchromium_src-7f8fdc7ac98c1543f837018c3ff034a0d4fbb26e.zip
chromium_src-7f8fdc7ac98c1543f837018c3ff034a0d4fbb26e.tar.gz
chromium_src-7f8fdc7ac98c1543f837018c3ff034a0d4fbb26e.tar.bz2
There are some application locale which can't be used as a target language for translation...
And this is the cause of some crashes... BUG=47807 TEST=Make sure that none of the application languages for which we don't support translating to don't enable the translate context menu option. Review URL: http://codereview.chromium.org/9212035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118880 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/translate')
-rw-r--r--chrome/browser/translate/translate_manager_browsertest.cc11
1 files changed, 9 insertions, 2 deletions
diff --git a/chrome/browser/translate/translate_manager_browsertest.cc b/chrome/browser/translate/translate_manager_browsertest.cc
index 1057705..8306655 100644
--- a/chrome/browser/translate/translate_manager_browsertest.cc
+++ b/chrome/browser/translate/translate_manager_browsertest.cc
@@ -956,8 +956,8 @@ TEST_F(TranslateManagerTest, ServerReportsUnsupportedLanguage) {
EXPECT_TRUE(GetTranslateInfoBar() == NULL);
}
-// Tests that no translate infobar is shown when Chrome is in a language that
-// the translate server does not support.
+// Tests that no translate infobar is shown and context menu is disabled, when
+// Chrome is in a language that the translate server does not support.
TEST_F(TranslateManagerTest, UnsupportedUILanguage) {
std::string original_lang = g_browser_process->GetApplicationLocale();
g_browser_process->SetApplicationLocale("qbz");
@@ -975,6 +975,13 @@ TEST_F(TranslateManagerTest, UnsupportedUILanguage) {
// No info-bar should be shown.
EXPECT_TRUE(GetTranslateInfoBar() == NULL);
+ // And the context menu option should be disabled too.
+ scoped_ptr<TestRenderViewContextMenu> menu(
+ TestRenderViewContextMenu::CreateContextMenu(contents()));
+ menu->Init();
+ EXPECT_TRUE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_TRANSLATE));
+ EXPECT_FALSE(menu->IsCommandIdEnabled(IDC_CONTENT_CONTEXT_TRANSLATE));
+
g_browser_process->SetApplicationLocale(original_lang);
}