Make all consumers of chrome::NewEmptyWindow and chrome::OpenEmptyWindow browser commands use the version specifying a HostDesktopType.

Removes chrome::OpenEmptyWindow() completely. 1 trickier consumer remains for chrome::NewEmptyWindow(), but the non-multi-desktop aware ovveride of this call was renamed to chrome::NewEmptyWindowDeprecated() and will be removed in a follow-up CL.

- Re-used desktop context where it was present.
- Hardcoded context to HOST_DESKTOP_TYPE_ASH for everything under 	 chrome/browser/ui/ash/.
- Hardcoded context to HOST_DESKTOP_TYPE_NATIVE in tests.

BUG=129187

Review URL: https://chromiumcodereview.appspot.com/12282048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183424 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 7 insertions, 7 deletions

diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc
index 3c5dac2..884e0cf 100644
--- a/chrome/browser/ui/browser_commands.cc
+++ b/chrome/browser/ui/browser_commands.cc
@@ -292,7 +292,9 @@ void NewEmptyWindow(Profile* profile, HostDesktopType desktop_type) {
   }
 }
 
-void NewEmptyWindow(Profile* profile) {
+// TODO(gab): This method is deprecated and will be removed shortly. Please use
+// the new version of the NewEmptyWindow call.
+void NewEmptyWindowDeprecated(Profile* profile) {
   NewEmptyWindow(profile, HOST_DESKTOP_TYPE_NATIVE);
 }
 
@@ -308,10 +310,6 @@ Browser* OpenEmptyWindow(Profile* profile, HostDesktopType desktop_type) {
   return browser;
 }
 
-Browser* OpenEmptyWindow(Profile* profile) {
-  return OpenEmptyWindow(profile, HOST_DESKTOP_TYPE_NATIVE);
-}
-
 void OpenWindowWithRestoredTabs(Profile* profile,
                                 HostDesktopType host_desktop_type) {
   TabRestoreService* service = TabRestoreServiceFactory::GetForProfile(profile);
@@ -449,11 +447,13 @@ void Stop(Browser* browser) {
 
 #if !defined(OS_WIN)
 void NewWindow(Browser* browser) {
-  NewEmptyWindow(browser->profile()->GetOriginalProfile());
+  NewEmptyWindow(browser->profile()->GetOriginalProfile(),
+                 browser->host_desktop_type());
 }
 
 void NewIncognitoWindow(Browser* browser) {
-  NewEmptyWindow(browser->profile()->GetOffTheRecordProfile());
+  NewEmptyWindow(browser->profile()->GetOffTheRecordProfile(),
+                 browser->host_desktop_type());
 }
 #endif  // OS_WIN