diff options
author | mgiuca <mgiuca@chromium.org> | 2015-05-06 19:20:31 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-05-07 02:21:02 +0000 |
commit | 8137fc2204cff57aa4d7393b93c85fb846cb70eb (patch) | |
tree | 11186b505228fa2cb6cad87322b6362289ec6f94 /chrome/browser/ui/browser_ui_prefs.cc | |
parent | bbaef9c249d171c387e5a8ab41d8d9f2022597e1 (diff) | |
download | chromium_src-8137fc2204cff57aa4d7393b93c85fb846cb70eb.zip chromium_src-8137fc2204cff57aa4d7393b93c85fb846cb70eb.tar.gz chromium_src-8137fc2204cff57aa4d7393b93c85fb846cb70eb.tar.bz2 |
FileVersionInfoWin: BASE_EXPORT the class instead of select methods.
Some methods are being called from a different component, so should be
exported. Rather than selectively exporting them, we just made the
entire class (and its parent class, FileVersionInfo) BASE_EXPORTed.
Note: This is not currently breaking the build, because the methods are
called by virtual dispatch, but in principle, they should be exported.
Context: I am investigating adding the "final" keyword to a bunch of
classes (http://crbug.com/482800) and this breaks once "final" is added
to FileVersionInfoWin.
BUG=484939
Review URL: https://codereview.chromium.org/1122413002
Cr-Commit-Position: refs/heads/master@{#328683}
Diffstat (limited to 'chrome/browser/ui/browser_ui_prefs.cc')
0 files changed, 0 insertions, 0 deletions