diff options
author | mpcomplete@chromium.org <mpcomplete@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-02-28 04:05:08 +0000 |
---|---|---|
committer | mpcomplete@chromium.org <mpcomplete@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-02-28 04:05:08 +0000 |
commit | bc9833c3cc8a3ed4090da16270de39722a6be2b4 (patch) | |
tree | 6ba25e8a748cba3fa72fbe16306b8d8746e6ee06 /chrome/browser/ui/chrome_pages.cc | |
parent | 97ff8b508812e58e7071579511ab04ca21d577be (diff) | |
download | chromium_src-bc9833c3cc8a3ed4090da16270de39722a6be2b4.zip chromium_src-bc9833c3cc8a3ed4090da16270de39722a6be2b4.tar.gz chromium_src-bc9833c3cc8a3ed4090da16270de39722a6be2b4.tar.bz2 |
The context menu for extension actions should show a Manage item, not just
"Manage Extensions...". This wasn't implemented back when the menu was
implemented because the ability to go to the manage page and highlight an
extension wasn't there. Now it is.
TBR=sky@chromium.org, thakis@chromium.org
BUG=173892
TEST=Right click a browser action (with at least a few extensions installed)
and select Manage. That should take you to the Extensions page with the right
extension scrolled to and highlighted.
Original patch by finnur: https://codereview.chromium.org/12224028/
Review URL: https://chromiumcodereview.appspot.com/12377003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185147 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/chrome_pages.cc')
-rw-r--r-- | chrome/browser/ui/chrome_pages.cc | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/chrome/browser/ui/chrome_pages.cc b/chrome/browser/ui/chrome_pages.cc index 5db3ed3..e289afb 100644 --- a/chrome/browser/ui/chrome_pages.cc +++ b/chrome/browser/ui/chrome_pages.cc @@ -95,11 +95,19 @@ void ShowDownloads(Browser* browser) { GetSingletonTabNavigateParams(browser, GURL(kChromeUIDownloadsURL))); } -void ShowExtensions(Browser* browser) { +void ShowExtensions(Browser* browser, + const std::string& extension_to_highlight) { content::RecordAction(UserMetricsAction("ShowExtensions")); NavigateParams params( GetSingletonTabNavigateParams(browser, GURL(kChromeUIExtensionsURL))); params.path_behavior = NavigateParams::IGNORE_AND_NAVIGATE; + if (!extension_to_highlight.empty()) { + GURL::Replacements replacements; + std::string query("id="); + query += extension_to_highlight; + replacements.SetQueryStr(query); + params.url = params.url.ReplaceComponents(replacements); + } ShowSingletonTabOverwritingNTP(browser, params); } |