diff options
| author | rdevlin.cronin@chromium.org <rdevlin.cronin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-10 02:46:31 +0000 |
|---|---|---|
| committer | rdevlin.cronin@chromium.org <rdevlin.cronin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-10 02:46:31 +0000 |
| commit | 2e1092860ab0be44cf392967deb045cc3fa104c3 (patch) | |
| tree | 48845254d4d41c627c5ea4c366b342d99e9e95f4 /chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm | |
| parent | 0e8e792cd3a41390cb18efda6981d609569f2761 (diff) | |
| download | chromium_src-2e1092860ab0be44cf392967deb045cc3fa104c3.zip chromium_src-2e1092860ab0be44cf392967deb045cc3fa104c3.tar.gz chromium_src-2e1092860ab0be44cf392967deb045cc3fa104c3.tar.bz2 | |
Resubmit: Add real file for AdNetworks DB
This is a resubmit of https://codereview.chromium.org/268063004/.
The previous version was reverted because it caused a memory leak. This was a
problem with RefCounting from ui::ResourceBundle::LoadDataResourceBytes(), which
has been fixed.
Details:
Even though the method returns a non-refcounted ptr to a RefCountedStaticMemory
(which according to the class comment, "the ref counting does not matter" [1]),
the ref-counting _does_ matter. The fix for this went in as part of a refactor
in https://codereview.chromium.org/263953003/.
[1] http://src.chromium.org/viewvc/chrome/trunk/src/base/memory/ref_counted_memory.h?revision=267321 line 44
BUG=357204
TBR=jhawkins@chromium.org (previously approved)
TBR=felt@chromium.org (very minor changes)
Review URL: https://codereview.chromium.org/274563003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269494 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm')
0 files changed, 0 insertions, 0 deletions