diff options
| author | jeremya@chromium.org <jeremya@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-29 00:55:02 +0000 |
|---|---|---|
| committer | jeremya@chromium.org <jeremya@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-29 00:55:02 +0000 |
| commit | a9bf3a5fe62bead51846f9165dcebe3529bac134 (patch) | |
| tree | 37592b76cb6e1a930a992788415516f428e0308d /chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm | |
| parent | 374b33fbfc49b54771104bff1a9b27fca30a84dd (diff) | |
| download | chromium_src-a9bf3a5fe62bead51846f9165dcebe3529bac134.zip chromium_src-a9bf3a5fe62bead51846f9165dcebe3529bac134.tar.gz chromium_src-a9bf3a5fe62bead51846f9165dcebe3529bac134.tar.bz2 | |
Fix a crash in FullscreenExitBubbleController when the user clicks the "Exit full screen" button.
The crash was due to the fact that Browser::OnDenyFullscreenPermission causes BrowserWindow::ExitFullscreen to be called, which causes the FullscreenExitBubbleController to be destroyed. [FullscreenExitBubbleController deny:] was sending a -hideSoon message to its zombie self following the call to Browser::OnDenyFullscreenPermission.
BUG=101835
TEST=The browser doesn't crash when you click "Exit full screen" on a fullscreened page.
Review URL: http://codereview.chromium.org/8399017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107841 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm')
| -rw-r--r-- | chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm b/chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm index bdbfcd2..fade662 100644 --- a/chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm +++ b/chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm @@ -93,7 +93,6 @@ const float kHideDuration = 0.7; - (void)deny:(id)sender { DCHECK(fullscreen_bubble::ShowButtonsForType(bubbleType_)); browser_->OnDenyFullscreenPermission(bubbleType_); - [self hideSoon]; } - (void)showButtons:(BOOL)show { |