diff options
| author | csharp@chromium.org <csharp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-01 17:15:35 +0000 |
|---|---|---|
| committer | csharp@chromium.org <csharp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-01 17:15:35 +0000 |
| commit | b6a2227b39282cd4a556105f5c8640bbaa7957e6 (patch) | |
| tree | 05603ebc8f75d5d03d8673e1b39c0fe93a7e84d9 /chrome/browser/ui/cocoa/global_error_bubble_controller.h | |
| parent | f5b2a576b31621783b5e2ed8c5026b8ce11b38fb (diff) | |
| download | chromium_src-b6a2227b39282cd4a556105f5c8640bbaa7957e6.zip chromium_src-b6a2227b39282cd4a556105f5c8640bbaa7957e6.tar.gz chromium_src-b6a2227b39282cd4a556105f5c8640bbaa7957e6.tar.bz2 | |
Revert 232403 "Revert 232369 "Revert 232312 "Cleanup ResourceFet..."
> Revert 232369 "Revert 232312 "Cleanup ResourceFetcher in prepara..."
>
> Revert didn't fix failing test.
>
> > Revert 232312 "Cleanup ResourceFetcher in preparation to add to ..."
> >
> > Seems to cause ResourceFetcherTests.ResourceFetcherDeletedInCallback
> > to timeout on Windows and crash on Linux.
> >
> > > Cleanup ResourceFetcher in preparation to add to public content API,
> > > in preparation to move error page logic from content to chrome:
> > >
> > > * Merge ResourceFetcher and ResourceFetcherWithTimeout.
> > > * Remove unnecessary member variables.
> > > * Remove Cancel() (All consumers were deleting and cancelling at the
> > > same time, anyways, and deleting already cancels).
> > > * Make definition order match declaration order.
> > > * Fix outdated comments.
> > >
> > > BUG=308232
> > >
> > > Review URL: https://codereview.chromium.org/33363003
> >
> > TBR=mmenke@chromium.org
> >
> > Review URL: https://codereview.chromium.org/55963002
>
> TBR=csharp@chromium.org
>
> Review URL: https://codereview.chromium.org/55943003
TBR=csharp@chromium.org
Review URL: https://codereview.chromium.org/56233002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232417 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/cocoa/global_error_bubble_controller.h')
0 files changed, 0 insertions, 0 deletions