diff options
| author | toyoshim@chromium.org <toyoshim@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-24 02:49:17 +0000 |
|---|---|---|
| committer | toyoshim@chromium.org <toyoshim@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-24 02:49:17 +0000 |
| commit | 7f4c84ffe959733ebe3fe1e6c5ea2c65a2dc218f (patch) | |
| tree | 1d273f5e372cad599d860b22be4ea3ec2bc7486e /chrome/browser/ui/cocoa/menu_button.h | |
| parent | ee2408b9230399f65a42107f230dde7a70f934e4 (diff) | |
| download | chromium_src-7f4c84ffe959733ebe3fe1e6c5ea2c65a2dc218f.zip chromium_src-7f4c84ffe959733ebe3fe1e6c5ea2c65a2dc218f.tar.gz chromium_src-7f4c84ffe959733ebe3fe1e6c5ea2c65a2dc218f.tar.bz2 | |
[Mac] Middle clicking on home button does not work. It should open home in new
tab. backward button, forward button and reload button have the same problem.
XIB Changes:
* Add ToolbarButton for buttons which should handle middle clicking.
* Switch the home button to be ToolbarButton instead of NSButton.
* Back/forward and reload buttons inherit from ToolbarButton instead of
NSButton.
BUG=45795
TEST=Middle click on the home button create new tab with home page, or on the
reload button create new tab with current page. Middle click on the
back/forward buttons also work with new tab. unit_tests include
TestbarButtonTest.* suites for testint that.
R=pinkerton@chromium.org,avi@chromium.org,viettrungluu@chromium.org,mark@chromium.org,shess@chromium.org,rohitrao@chromium.org
Review URL: http://codereview.chromium.org/6703004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79245 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/cocoa/menu_button.h')
| -rw-r--r-- | chrome/browser/ui/cocoa/menu_button.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/browser/ui/cocoa/menu_button.h b/chrome/browser/ui/cocoa/menu_button.h index 0b463db..b116b1f9 100644 --- a/chrome/browser/ui/cocoa/menu_button.h +++ b/chrome/browser/ui/cocoa/menu_button.h @@ -9,6 +9,7 @@ #import <Cocoa/Cocoa.h> #include "base/scoped_nsobject.h" +#import "chrome/browser/ui/cocoa/toolbar/toolbar_button.h" // This a button which displays a user-provided menu "attached" below it upon // being clicked or dragged (or clicked and held). It expects a @@ -22,7 +23,7 @@ // held. This is used for the toolbar back/forward buttons, which have a // primary action and the menu as a secondary click-hold action. The default // value is NO so that custom actions can be hooked up in Interface Builder. -@interface MenuButton : NSButton { +@interface MenuButton : ToolbarButton { @private scoped_nsobject<NSMenu> attachedMenu_; BOOL attachedMenuEnabled_; |