diff options
| author | jianli@chromium.org <jianli@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-01 03:50:45 +0000 |
|---|---|---|
| committer | jianli@chromium.org <jianli@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-01 03:50:45 +0000 |
| commit | 83bac47170b11cc5513ca91c62b702ae8fe0eb16 (patch) | |
| tree | 4b5329a5b03274df56f424e5cd7e95248ac684db /chrome/browser/ui/cocoa/notifications | |
| parent | 371dab1e621ab4157e42f4518e16a50b6ae03b56 (diff) | |
| download | chromium_src-83bac47170b11cc5513ca91c62b702ae8fe0eb16.zip chromium_src-83bac47170b11cc5513ca91c62b702ae8fe0eb16.tar.gz chromium_src-83bac47170b11cc5513ca91c62b702ae8fe0eb16.tar.bz2 | |
Fix bug 127498: Panels: The position of notifications aren't adjusted when panels are detached
I fixed a bunch of other issues that could cause balloons not to repositioned in addition to the issue described in the bug. We now observe a new NOTIFICATION_PANEL_STRIP_CHANGED notification that is triggered each time when strip needs to be updated. In addition, we also need to listen to NOTIFICATION_PANEL_CHANGED_EXPANSION_STATE because expansion state change does not update the strip.
More tests are added to cover various kinds of panel operations that could affect positioning of desktop notification balloon. They now live in the new test file.
BUG=127498,118168
TEST=New tests
Review URL: https://chromiumcodereview.appspot.com/10454027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139965 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/cocoa/notifications')
| -rw-r--r-- | chrome/browser/ui/cocoa/notifications/balloon_collection_cocoa.mm | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/ui/cocoa/notifications/balloon_collection_cocoa.mm b/chrome/browser/ui/cocoa/notifications/balloon_collection_cocoa.mm index 65aeab0..9e76836 100644 --- a/chrome/browser/ui/cocoa/notifications/balloon_collection_cocoa.mm +++ b/chrome/browser/ui/cocoa/notifications/balloon_collection_cocoa.mm @@ -69,7 +69,7 @@ void BalloonCollectionImpl::SetPositionPreference( else NOTREACHED(); - layout_.ComputeOffsetToMoveAbovePanels(gfx::Rect()); + layout_.ComputeOffsetToMoveAbovePanels(); PositionBalloons(true); } |