diff options
| author | msw@google.com <msw@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-10-19 20:18:16 +0000 |
|---|---|---|
| committer | msw@google.com <msw@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-10-19 20:18:16 +0000 |
| commit | 22cfe5fa8a8636af6eca91c99ca090cccd9d9dbd (patch) | |
| tree | 4d9c122bd12cfcafd4ab8a28b86ce58b4638139b /chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.cc | |
| parent | adef225bdf62da1c97aeb9066d72b40a21508fc5 (diff) | |
| download | chromium_src-22cfe5fa8a8636af6eca91c99ca090cccd9d9dbd.zip chromium_src-22cfe5fa8a8636af6eca91c99ca090cccd9d9dbd.tar.gz chromium_src-22cfe5fa8a8636af6eca91c99ca090cccd9d9dbd.tar.bz2 | |
Consolidate UMA metrics reporting for Chrome To Mobile
Add C...Service::Observer to log BUBBLE_SHOWN.
Add C...Service::SnapshotGenerated to log SNAPSHOT_[GENERATED|ERROR].
Nix C...Service::LogMetric, move enum to code file.
Remove metrics logging from Views, Cocoa, and GTK bubbles.
Cleanup CL; no observable behavior change.
BUG=102709,120941
TEST=none
R=sky@chromium.org,sail@chromium.org,erg@chromium.org
Review URL: https://codereview.chromium.org/11195061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163046 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.cc')
| -rw-r--r-- | chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.cc | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.cc b/chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.cc index 87e1b30..870bc7f 100644 --- a/chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.cc +++ b/chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.cc @@ -109,12 +109,10 @@ void ChromeToMobileBubbleGtk::SnapshotGenerated(const FilePath& path, int64 bytes) { snapshot_path_ = path; if (bytes > 0) { - service_->LogMetric(ChromeToMobileService::SNAPSHOT_GENERATED); gtk_button_set_label(GTK_BUTTON(send_copy_), l10n_util::GetStringFUTF8( IDS_CHROME_TO_MOBILE_BUBBLE_SEND_COPY, ui::FormatBytes(bytes)).c_str()); gtk_widget_set_sensitive(send_copy_, TRUE); } else { - service_->LogMetric(ChromeToMobileService::SNAPSHOT_ERROR); gtk_button_set_label(GTK_BUTTON(send_copy_), l10n_util::GetStringUTF8( IDS_CHROME_TO_MOBILE_BUBBLE_SEND_COPY_FAILED).c_str()); } @@ -151,7 +149,6 @@ ChromeToMobileBubbleGtk::ChromeToMobileBubbleGtk(GtkWidget* anchor_widget, error_(NULL), bubble_(NULL) { DCHECK(service_->HasMobiles()); - service_->LogMetric(ChromeToMobileService::BUBBLE_SHOWN); // Generate the MHTML snapshot now to report its size in the bubble. service_->GenerateSnapshot(browser_, weak_ptr_factory_.GetWeakPtr()); |