diff options
| author | asvitkine@chromium.org <asvitkine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-12-12 04:16:21 +0000 |
|---|---|---|
| committer | asvitkine@chromium.org <asvitkine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-12-12 04:16:21 +0000 |
| commit | 907432ee75ddfab61a7ac9063f86daa6dc6fe8b4 (patch) | |
| tree | 008d257e0061299e1e02fe658e3a758c1ac47392 /chrome/browser/ui/omnibox/omnibox_edit_model.h | |
| parent | 61806871bd4f447e2ad4511d3305cc835b6031c6 (diff) | |
| download | chromium_src-907432ee75ddfab61a7ac9063f86daa6dc6fe8b4.zip chromium_src-907432ee75ddfab61a7ac9063f86daa6dc6fe8b4.tar.gz chromium_src-907432ee75ddfab61a7ac9063f86daa6dc6fe8b4.tar.bz2 | |
Fix data race when setting FieldTrial::group_reported_.
Per the bug, the issue is that |group_reported_| gets set by a call to
group() while another thread may be iterating over trials and reading
these values via GetActiveFieldTrialGroups().
Since the value is read by another thread and we don't set it atomically
or under a lock, other threads may see a stale value for this variable.
This change refactors the code such that setting |group_reported_| is
also done while holding the lock.
BUG=164349
TEST=Data race failures in this code disappear
Review URL: https://chromiumcodereview.appspot.com/11516013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172522 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/omnibox/omnibox_edit_model.h')
0 files changed, 0 insertions, 0 deletions