Password bubble: ManagePasswordsIconView is now a BubbleIconView.

This CL introduces a new browser command to open the Manage Passwords bubble,
and converts the ManagePasswordsIconView class into a subclass of
BubbleIconView, which uses the new command to control the bubble's state.
This allows us to more easily test the view and the UI controller, as each
object's job is now more clearly defined (and the view is now doing a good
deal less work), and to independently verify that the command is doing the
right thing.

After this CL, we'll (finally!) have something approaching reasonable test
coverage for the core of the views code.

----------------------------------------------------------------------------
This is a re-land of r266859, which was reverted due to LSAN errors. The
original review is https://codereview.chromium.org/246393004/
----------------------------------------------------------------------------

BUG=365678
TBR=vabr@chromium.org,pkasting@chromium.org,cpu@chromium.org

Review URL: https://codereview.chromium.org/254263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267195 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 3 insertions, 2 deletions

diff --git a/chrome/browser/ui/passwords/manage_passwords_icon.h b/chrome/browser/ui/passwords/manage_passwords_icon.h
index 0a44406..004c8cd 100644
--- a/chrome/browser/ui/passwords/manage_passwords_icon.h
+++ b/chrome/browser/ui/passwords/manage_passwords_icon.h
@@ -42,8 +42,9 @@ class ManagePasswordsIcon {
   ManagePasswordsIcon();
   ~ManagePasswordsIcon();
 
-  // Called from SetState() iff the icon's state has changed.
-  virtual void SetStateInternal(State state) = 0;
+  // Called from SetState() iff the icon's state has changed in order to do
+  // whatever platform-specific UI work is necessary given the new state.
+  virtual void UpdateVisibleUI() = 0;
 
  private:
   State state_;