diff options
author | tfarina <tfarina@chromium.org> | 2016-03-25 09:18:23 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-03-25 16:20:09 +0000 |
commit | ba8376b3933223aa787273744c1bfd83f5574a15 (patch) | |
tree | 859cdd508e6c1c9f69f725392d59c84bc18dde8a /chrome/browser/ui/views/browser_dialogs.h | |
parent | dd41470bae5a05678aa150f0b98e35016b70ad03 (diff) | |
download | chromium_src-ba8376b3933223aa787273744c1bfd83f5574a15.zip chromium_src-ba8376b3933223aa787273744c1bfd83f5574a15.tar.gz chromium_src-ba8376b3933223aa787273744c1bfd83f5574a15.tar.bz2 |
views: remove the last function abstraction from browser_dialogs.h
After commit faed95410a75: ("views: remove unnecessary EditSearchEngine()
function abstraction"), only CreateFindBar() function abstraction
remained in browser_dialogs.h, but like EditSearchEngine(), it is
unlikely this function will be used to be called by cross-platform
code, so it is not necessary keep it wrapping FindBarHost.
BrowserView can just depend on it like it does with many other
chrome/browser/ui/views/ header files already. This is also what
BrowserWindowCocoa does as well.
This in effect get rid of browser_dialogs.h header file finally.
BUG=None
R=sky@chromium.org
Review URL: https://codereview.chromium.org/1828363002
Cr-Commit-Position: refs/heads/master@{#383282}
Diffstat (limited to 'chrome/browser/ui/views/browser_dialogs.h')
-rw-r--r-- | chrome/browser/ui/views/browser_dialogs.h | 25 |
1 files changed, 0 insertions, 25 deletions
diff --git a/chrome/browser/ui/views/browser_dialogs.h b/chrome/browser/ui/views/browser_dialogs.h deleted file mode 100644 index 1aaec5c..0000000 --- a/chrome/browser/ui/views/browser_dialogs.h +++ /dev/null @@ -1,25 +0,0 @@ -// Copyright (c) 2012 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef CHROME_BROWSER_UI_VIEWS_BROWSER_DIALOGS_H_ -#define CHROME_BROWSER_UI_VIEWS_BROWSER_DIALOGS_H_ - -// This file contains functions for running a variety of browser dialogs and -// popups. The dialogs here are the ones that the caller does not need to -// access the class of the popup. It allows us to break dependencies by -// allowing the callers to not depend on the classes implementing the dialogs. -// TODO: Make as many of these methods as possible cross platform, and move them -// into chrome/browser/ui/browser_dialogs.h. - -class BrowserView; -class FindBar; - -namespace chrome { - -// Creates and returns a find bar for the given browser window. See FindBarWin. -FindBar* CreateFindBar(BrowserView* browser_view); - -} // namespace chrome - -#endif // CHROME_BROWSER_UI_VIEWS_BROWSER_DIALOGS_H_ |