diff options
author | wittman@chromium.org <wittman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-03 00:41:58 +0000 |
---|---|---|
committer | wittman@chromium.org <wittman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-03 00:41:58 +0000 |
commit | d2b1657066dd75dae77a79f0d27b33c2eb708e3b (patch) | |
tree | 0fa11dccf1e81084eca2943bf7e61f3a9059a338 /chrome/browser/ui/views/constrained_window_views_browsertest.cc | |
parent | 937c4ebd57998c1fac40e5f9ed80cb8867ac661e (diff) | |
download | chromium_src-d2b1657066dd75dae77a79f0d27b33c2eb708e3b.zip chromium_src-d2b1657066dd75dae77a79f0d27b33c2eb708e3b.tar.gz chromium_src-d2b1657066dd75dae77a79f0d27b33c2eb708e3b.tar.bz2 |
Rename platform-independent ConstrainedWindow types to WebContentsModalDialog types (part 2). See https://codereview.chromium.org/11647017/ for part 1.
This performs the actual class/filename renames.
No functional changes are intended in this CL.
R=sky@chromium.org
BUG=157161
Review URL: https://chromiumcodereview.appspot.com/11633052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174900 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/views/constrained_window_views_browsertest.cc')
-rw-r--r-- | chrome/browser/ui/views/constrained_window_views_browsertest.cc | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/chrome/browser/ui/views/constrained_window_views_browsertest.cc b/chrome/browser/ui/views/constrained_window_views_browsertest.cc index 7a16ada..5b9740a 100644 --- a/chrome/browser/ui/views/constrained_window_views_browsertest.cc +++ b/chrome/browser/ui/views/constrained_window_views_browsertest.cc @@ -6,10 +6,10 @@ #include "chrome/browser/profiles/profile.h" #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/browser_commands.h" -#include "chrome/browser/ui/constrained_window_tab_helper.h" #include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/browser/ui/views/constrained_window_views.h" #include "chrome/browser/ui/views/frame/browser_view.h" +#include "chrome/browser/ui/web_contents_modal_dialog_manager.h" #include "chrome/browser/ui/webui/constrained_web_dialog_ui.h" #include "chrome/common/url_constants.h" #include "chrome/test/base/in_process_browser_test.h" @@ -122,9 +122,9 @@ IN_PROC_BROWSER_TEST_F(ConstrainedWindowViewTest, FocusTest) { content::WebContents* web_contents = browser()->tab_strip_model()->GetActiveWebContents(); ASSERT_TRUE(web_contents != NULL); - ConstrainedWindowTabHelper* constrained_window_helper = - ConstrainedWindowTabHelper::FromWebContents(web_contents); - ASSERT_TRUE(constrained_window_helper != NULL); + WebContentsModalDialogManager* web_contents_modal_dialog_manager = + WebContentsModalDialogManager::FromWebContents(web_contents); + ASSERT_TRUE(web_contents_modal_dialog_manager != NULL); // Create a constrained dialog. It will attach itself to web_contents. scoped_ptr<TestConstrainedDialog> test_dialog1(new TestConstrainedDialog); @@ -150,7 +150,7 @@ IN_PROC_BROWSER_TEST_F(ConstrainedWindowViewTest, FocusTest) { // test_dialog1's text field should still be the view that has focus. EXPECT_EQ(test_dialog1->GetInitiallyFocusedView(), focus_manager->GetFocusedView()); - ASSERT_EQ(2u, constrained_window_helper->dialog_count()); + ASSERT_EQ(2u, web_contents_modal_dialog_manager->dialog_count()); // Now send a VKEY_RETURN to the browser. This should result in closing // test_dialog1. @@ -160,7 +160,7 @@ IN_PROC_BROWSER_TEST_F(ConstrainedWindowViewTest, FocusTest) { EXPECT_TRUE(test_dialog1->done()); EXPECT_FALSE(test_dialog2->done()); - EXPECT_EQ(1u, constrained_window_helper->dialog_count()); + EXPECT_EQ(1u, web_contents_modal_dialog_manager->dialog_count()); // test_dialog2 will be shown. Focus should be on test_dialog2's text field. EXPECT_EQ(test_dialog2->GetInitiallyFocusedView(), @@ -187,7 +187,7 @@ IN_PROC_BROWSER_TEST_F(ConstrainedWindowViewTest, FocusTest) { ui::Accelerator(ui::VKEY_RETURN, ui::EF_NONE))); content::RunAllPendingInMessageLoop(); EXPECT_TRUE(test_dialog2->done()); - EXPECT_EQ(0u, constrained_window_helper->dialog_count()); + EXPECT_EQ(0u, web_contents_modal_dialog_manager->dialog_count()); } // Tests that the constrained window is closed properly when its tab is @@ -196,9 +196,9 @@ IN_PROC_BROWSER_TEST_F(ConstrainedWindowViewTest, TabCloseTest) { content::WebContents* web_contents = browser()->tab_strip_model()->GetActiveWebContents(); ASSERT_TRUE(web_contents != NULL); - ConstrainedWindowTabHelper* constrained_window_helper = - ConstrainedWindowTabHelper::FromWebContents(web_contents); - ASSERT_TRUE(constrained_window_helper != NULL); + WebContentsModalDialogManager* web_contents_modal_dialog_manager = + WebContentsModalDialogManager::FromWebContents(web_contents); + ASSERT_TRUE(web_contents_modal_dialog_manager != NULL); // Create a constrained dialog. It will attach itself to web_contents. scoped_ptr<TestConstrainedDialog> test_dialog(new TestConstrainedDialog); @@ -254,7 +254,7 @@ IN_PROC_BROWSER_TEST_F(ConstrainedWindowViewTest, TabSwitchTest) { // Tests that backspace is not processed before it's sent to the web contents. // We do not run this test on Aura because key events are sent to the web // contents through a different code path that does not call -// views::FocusManager::OnKeyEvent when ConstrainedWindow is focused. +// views::FocusManager::OnKeyEvent when WebContentsModalDialog is focused. IN_PROC_BROWSER_TEST_F(ConstrainedWindowViewTest, BackspaceSentToWebContent) { content::WebContents* web_contents = |