summaryrefslogtreecommitdiffstats
path: root/chrome/browser/ui/views/external_tab_container_win.h
diff options
context:
space:
mode:
authoryukawa@chromium.org <yukawa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-11-29 06:27:41 +0000
committeryukawa@chromium.org <yukawa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-11-29 06:27:41 +0000
commite675a40da82bf54681449d6b08efafd01d6a7671 (patch)
treefbdb1f2557292c117065b803db22e02eb983b13b /chrome/browser/ui/views/external_tab_container_win.h
parentbb499820e3d0bd9fe09fc7432571a882f1284a43 (diff)
downloadchromium_src-e675a40da82bf54681449d6b08efafd01d6a7671.zip
chromium_src-e675a40da82bf54681449d6b08efafd01d6a7671.tar.gz
chromium_src-e675a40da82bf54681449d6b08efafd01d6a7671.tar.bz2
Revert 237660 "Revert 237558 "Use MIDIMessageQueue/IsValidWebMID..."
The root cause was fixed as r237778. > Revert 237558 "Use MIDIMessageQueue/IsValidWebMIDIData for MIDI ..." > > Seems to have caused issues running perf tests. > > BUG=324160 > > > Use MIDIMessageQueue/IsValidWebMIDIData for MIDI byte stream validation > > > > WebMIDI spec draft: http://www.w3.org/TR/webmidi/ > > > > WebMIDI API guarantees that MIDIInput::onmessage is called back with a single MIDI message. To guarantee this, this CL introduces MIDIMessageQueue class, which allows you to > > - maintain fragmented MIDI message. > > - Skip any invalid data sequence. > > - Reorder MIDI messages so that "System Real Time Message", which can be inserted at any point of the byte stream, can be placed at the boundary of complete MIDI messages. > > - (Optional) Reconstruct complete MIDI messages from data stream that is compressed with "running status". > > > > This CL also replaces existing System Exclusive message validation logic in MIDIHost::OnSendData with MIDIHost::IsValidWebMIDIData, which can detect SysEx message even when it is concatenated with non-SysEx messages. > > > > With this change, renderer/blink can be much simpler and free from this kind of data validation. > > > > BUG=303599, 317355 > > TEST=media_unittests --gtest_filter=MIDI*, content_unittests --gtest_filter=MIDI* > > > > Review URL: https://codereview.chromium.org/68353002 > > TBR=yukawa@chromium.org > > Review URL: https://codereview.chromium.org/93583002 TBR=isherman@chromium.org, toyoshim@chromium.org, scherkus@chromium.org, jochen@chromium.org BUG=303599,317355,324160 Review URL: https://codereview.chromium.org/96113002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237889 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/views/external_tab_container_win.h')
0 files changed, 0 insertions, 0 deletions