diff options
| author | benwells <benwells@chromium.org> | 2015-07-20 17:53:39 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-07-21 00:54:47 +0000 |
| commit | cb03d6cb0f306228a7b7e3e4dfc1188d49b16556 (patch) | |
| tree | 719031c31d6ad419163afcde11d2ae769371305f /chrome/browser/ui/views/frame/browser_header_painter_ash.h | |
| parent | 648d7c41e5b7e39ab21f45eace404735b4fe5967 (diff) | |
| download | chromium_src-cb03d6cb0f306228a7b7e3e4dfc1188d49b16556.zip chromium_src-cb03d6cb0f306228a7b7e3e4dfc1188d49b16556.tar.gz chromium_src-cb03d6cb0f306228a7b7e3e4dfc1188d49b16556.tar.bz2 | |
Remove gap in ChromeOS hosted app frames which are showing the location.
For security reasons, hosted apps which have navigated away from their starting origin show the origin. On ChromeOS this caused a bug where a 2 pixel transparent gap was created between the frame and the location bar.
This was because the for this type of frame, the toolbar was positioned to be calculated using the HeaderHeightForPainting. However the HeaderHeightForPainting was adjusted prior to the toolbar being positioned to account for the toolbar not painting the top two rows of pixels. The fix is to position the toolbar relative to the base height of the frame.
BUG=508043
Review URL: https://codereview.chromium.org/1240733003
Cr-Commit-Position: refs/heads/master@{#339581}
Diffstat (limited to 'chrome/browser/ui/views/frame/browser_header_painter_ash.h')
| -rw-r--r-- | chrome/browser/ui/views/frame/browser_header_painter_ash.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/chrome/browser/ui/views/frame/browser_header_painter_ash.h b/chrome/browser/ui/views/frame/browser_header_painter_ash.h index ec172ca..3f4e7a9 100644 --- a/chrome/browser/ui/views/frame/browser_header_painter_ash.h +++ b/chrome/browser/ui/views/frame/browser_header_painter_ash.h @@ -46,6 +46,7 @@ class BrowserHeaderPainterAsh : public ash::HeaderPainter, int GetMinimumHeaderWidth() const override; void PaintHeader(gfx::Canvas* canvas, Mode mode) override; void LayoutHeader() override; + int GetHeaderHeight() const override; int GetHeaderHeightForPainting() const override; void SetHeaderHeightForPainting(int height) override; void SchedulePaintForTitle() override; |