diff options
author | tkent@chromium.org <tkent@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-12 04:29:58 +0000 |
---|---|---|
committer | tkent@chromium.org <tkent@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-12 04:29:58 +0000 |
commit | 5d22262e3f0a8f5f9a996060da5b0402414aab8d (patch) | |
tree | d19ad3ee07d4f3ec0bdbeba784116aa177cbee22 /chrome/browser/ui/views/validation_message_bubble_delegate.h | |
parent | beab38fc69a1a31fb11b2d301ea137fb15575d80 (diff) | |
download | chromium_src-5d22262e3f0a8f5f9a996060da5b0402414aab8d.zip chromium_src-5d22262e3f0a8f5f9a996060da5b0402414aab8d.tar.gz chromium_src-5d22262e3f0a8f5f9a996060da5b0402414aab8d.tar.bz2 |
Some improvement of validation message bubble UI.
* Change anchor position arguments of some functions from the screen
coordinate system to the root view coordinate system. Blink can't
provide a rectangle in the screen coordinate on Android, and we'd like
to make it consistent. Each of validation message UI implementation
converts the anchor postion to the screen coordinate.
* Support WebValidationMessageClient::moveValidationMessage.
Add functions to ValidationMessageAgent, ValidationmessageFilter, and
ValidationMessageBubble classes, and add new IPC message to
validation_message_messages.h.
Changs for platform-specific files:
* chrome/browser/ui/android/:
Just rename argument names; anchor_in_screen -> anchor_in_root_view
* chrome/browser/ui/cocoa/:
Implement SetPositionRelativeToAnchor, add a helper function
* chrome/browser/ui/gtk/:
Add BubbleGtk::SetPositionRelativeToAnchor, and use it for
ValidationMessageBubble::SetPositionRelativeToAnchor implementation
* chrome/browser/ui/views/:
Add SetPositionRelativeToAnchor implementation.
Also, fixes a bug that ValidationMessageBubbleDelegate is never
destructed because Hide() won't call DeleteDelegate. We should call
Close().
BUG=146212
R=estade@chromium.org, sky@chromium.org, thakis@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/16583005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205723 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/views/validation_message_bubble_delegate.h')
-rw-r--r-- | chrome/browser/ui/views/validation_message_bubble_delegate.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/browser/ui/views/validation_message_bubble_delegate.h b/chrome/browser/ui/views/validation_message_bubble_delegate.h index fc8d18c..b3a2a4e 100644 --- a/chrome/browser/ui/views/validation_message_bubble_delegate.h +++ b/chrome/browser/ui/views/validation_message_bubble_delegate.h @@ -29,7 +29,8 @@ class ValidationMessageBubbleDelegate : public views::BubbleDelegateView { Observer* observer); virtual ~ValidationMessageBubbleDelegate(); - void Hide(); + void Close(); + void SetPositionRelativeToAnchor(const gfx::Rect& anchor_in_screen); // BubbleDelegateView overrides: virtual gfx::Size GetPreferredSize() OVERRIDE; |