diff options
| author | dbeam@chromium.org <dbeam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-27 02:19:25 +0000 |
|---|---|---|
| committer | dbeam@chromium.org <dbeam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-27 02:19:25 +0000 |
| commit | e03a7a468f01d6f42bc4ca689c900d22cf2f0c68 (patch) | |
| tree | bcc8400436b642704cebf0722610803058e650bc /chrome/browser/ui/webui/ntp/ntp_login_handler.h | |
| parent | 53616a1abc62ccbb1d29daf91dad47987e363132 (diff) | |
| download | chromium_src-e03a7a468f01d6f42bc4ca689c900d22cf2f0c68.zip chromium_src-e03a7a468f01d6f42bc4ca689c900d22cf2f0c68.tar.gz chromium_src-e03a7a468f01d6f42bc4ca689c900d22cf2f0c68.tar.bz2 | |
NTP4/Sync Promo:
- rename sync promo -> NTP sign-in promo
- re-arrange UMA to correctly report stuff given new code path
- re-fix pane switcher issue.
R=sail@chromium.org,estade@chromium.org
TBR=mirandac@chromium.org
BUG=99540
TEST=Unit tests still pass, code still compiles, UMA gets reported, and pane switchers don't obscure.
Review URL: http://codereview.chromium.org/8363035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107517 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/webui/ntp/ntp_login_handler.h')
| -rw-r--r-- | chrome/browser/ui/webui/ntp/ntp_login_handler.h | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/chrome/browser/ui/webui/ntp/ntp_login_handler.h b/chrome/browser/ui/webui/ntp/ntp_login_handler.h index 3169ba0..890a34c 100644 --- a/chrome/browser/ui/webui/ntp/ntp_login_handler.h +++ b/chrome/browser/ui/webui/ntp/ntp_login_handler.h @@ -38,10 +38,10 @@ class NTPLoginHandler : public WebUIMessageHandler, private: // User actions while on the NTP when clicking on or viewing the sync promo. - enum SyncPromoNTPPromoBuckets { - SYNC_PROMO_NTP_PROMO_VIEWED, - SYNC_PROMO_NTP_PROMO_CLICKED, - SYNC_PROMO_NTP_PROMO_BUCKET_BOUNDARY, + enum NTPSignInPromoBuckets { + NTP_SIGN_IN_PROMO_VIEWED, + NTP_SIGN_IN_PROMO_CLICKED, + NTP_SIGN_IN_PROMO_BUCKET_BOUNDARY, }; // Called from JS when the NTP is loaded. |args| is the list of arguments @@ -53,6 +53,9 @@ class NTPLoginHandler : public WebUIMessageHandler, // arguments passed from JS and should be an empty list. void HandleShowSyncLoginUI(const ListValue* args); + // Records actions in SyncPromo.NTPPromo histogram. + void RecordInHistogram(int type); + // Internal helper method void UpdateLogin(); |