diff options
author | mihaip@chromium.org <mihaip@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-04 18:27:57 +0000 |
---|---|---|
committer | mihaip@chromium.org <mihaip@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-04 18:27:57 +0000 |
commit | 5e3477e34c93c52e03f10101909ceeb71324b38c (patch) | |
tree | 1484fa0fcf8bb278a4337996c978cbafeb1a16a6 /chrome/browser/ui/webui/options/extension_settings_handler.cc | |
parent | 27e2aac0cf49bc7e72e71c1f550c95bd62c001e1 (diff) | |
download | chromium_src-5e3477e34c93c52e03f10101909ceeb71324b38c.zip chromium_src-5e3477e34c93c52e03f10101909ceeb71324b38c.tar.gz chromium_src-5e3477e34c93c52e03f10101909ceeb71324b38c.tar.bz2 |
Remove content_scripts and permissions from detail JSON output.
Neither seems to be used anywhere.
BUG=none
TEST=ExtensionUITest.*
R=aa@chromium.org,finnur@chromium.org
Review URL: http://codereview.chromium.org/6788026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80344 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/webui/options/extension_settings_handler.cc')
-rw-r--r-- | chrome/browser/ui/webui/options/extension_settings_handler.cc | 60 |
1 files changed, 0 insertions, 60 deletions
diff --git a/chrome/browser/ui/webui/options/extension_settings_handler.cc b/chrome/browser/ui/webui/options/extension_settings_handler.cc index 49b43a1..0796863 100644 --- a/chrome/browser/ui/webui/options/extension_settings_handler.cc +++ b/chrome/browser/ui/webui/options/extension_settings_handler.cc @@ -766,46 +766,6 @@ void ExtensionsDOMHandler::MaybeUpdateAfterNotification() { deleting_rvh_ = NULL; } -static void CreateScriptFileDetailValue( - const FilePath& extension_path, const UserScript::FileList& scripts, - const char* key, DictionaryValue* script_data) { - if (scripts.empty()) - return; - - ListValue *list = new ListValue(); - for (size_t i = 0; i < scripts.size(); ++i) { - const UserScript::File& file = scripts[i]; - // TODO(cira): this information is not used on extension page yet. We - // may want to display actual resource that got loaded, not default. - list->Append( - new StringValue(file.relative_path().value())); - } - script_data->Set(key, list); -} - -// Static -DictionaryValue* ExtensionsDOMHandler::CreateContentScriptDetailValue( - const UserScript& script, const FilePath& extension_path) { - DictionaryValue* script_data = new DictionaryValue(); - CreateScriptFileDetailValue(extension_path, script.js_scripts(), "js", - script_data); - CreateScriptFileDetailValue(extension_path, script.css_scripts(), "css", - script_data); - - // Get list of glob "matches" strings - ListValue *url_pattern_list = new ListValue(); - const std::vector<URLPattern>& url_patterns = script.url_patterns(); - for (std::vector<URLPattern>::const_iterator url_pattern = - url_patterns.begin(); - url_pattern != url_patterns.end(); ++url_pattern) { - url_pattern_list->Append(new StringValue(url_pattern->GetAsString())); - } - - script_data->Set("matches", url_pattern_list); - - return script_data; -} - // Static DictionaryValue* ExtensionsDOMHandler::CreateExtensionDetailValue( ExtensionService* service, const Extension* extension, @@ -840,26 +800,6 @@ DictionaryValue* ExtensionsDOMHandler::CreateExtensionDetailValue( if (service && !service->GetBrowserActionVisibility(extension)) extension_data->SetBoolean("enable_show_button", true); - // Add list of content_script detail DictionaryValues. - ListValue *content_script_list = new ListValue(); - UserScriptList content_scripts = extension->content_scripts(); - for (UserScriptList::const_iterator script = content_scripts.begin(); - script != content_scripts.end(); ++script) { - content_script_list->Append( - CreateContentScriptDetailValue(*script, extension->path())); - } - extension_data->Set("content_scripts", content_script_list); - - // Add permissions. - ListValue *permission_list = new ListValue; - std::vector<URLPattern> permissions = extension->host_permissions(); - for (std::vector<URLPattern>::iterator permission = permissions.begin(); - permission != permissions.end(); ++permission) { - permission_list->Append(Value::CreateStringValue( - permission->GetAsString())); - } - extension_data->Set("permissions", permission_list); - // Add views ListValue* views = new ListValue; for (std::vector<ExtensionPage>::const_iterator iter = pages.begin(); |