diff options
| author | bauerb@chromium.org <bauerb@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-05 20:36:21 +0000 |
|---|---|---|
| committer | bauerb@chromium.org <bauerb@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-05 20:36:21 +0000 |
| commit | 853cd0a3ca9fced3ed1ff6add9c9947d048d1443 (patch) | |
| tree | 2992a5cc6e71f8c960a86ef696769ec3143496cf /chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc | |
| parent | e9a9aaa8de9bb1cd6bb5a2a18ab48c34efcc71d4 (diff) | |
| download | chromium_src-853cd0a3ca9fced3ed1ff6add9c9947d048d1443.zip chromium_src-853cd0a3ca9fced3ed1ff6add9c9947d048d1443.tar.gz chromium_src-853cd0a3ca9fced3ed1ff6add9c9947d048d1443.tar.bz2 | |
Don't compile out return value decoding in TabModalDialogWebUI::OnDialogClosed in release builds.
BUG=
TEST=browser_tests:TabModalDialogTest.Accept
Review URL: http://codereview.chromium.org/9110006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116537 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc')
| -rw-r--r-- | chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc b/chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc index f748f1a..f30467a 100644 --- a/chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc +++ b/chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc @@ -97,8 +97,8 @@ void TabModalConfirmDialogWebUI::OnDialogClosed( if (!json_retval.empty()) { base::JSONReader reader; scoped_ptr<Value> value(reader.JsonToValue(json_retval, false, false)); - DCHECK(value.get() && value->GetAsBoolean(&accepted)) - << "Missing or unreadable response from dialog"; + if (!value.get() || !value->GetAsBoolean(&accepted)) + NOTREACHED() << "Missing or unreadable response from dialog"; } delegate_->set_window(NULL); |