summaryrefslogtreecommitdiffstats
path: root/chrome/browser/ui/webui
diff options
context:
space:
mode:
authorakuegel@chromium.org <akuegel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-04-03 12:15:34 +0000
committerakuegel@chromium.org <akuegel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-04-03 12:15:34 +0000
commit953d054dc1bd47ecb590265eec5b72bfe52e43bf (patch)
tree5eefb2d059ec8dcf01216c44b23285a4d3a5bf1a /chrome/browser/ui/webui
parent0c2ebef56c7d9b32a4df60fac57469e60b0c43c7 (diff)
downloadchromium_src-953d054dc1bd47ecb590265eec5b72bfe52e43bf.zip
chromium_src-953d054dc1bd47ecb590265eec5b72bfe52e43bf.tar.gz
chromium_src-953d054dc1bd47ecb590265eec5b72bfe52e43bf.tar.bz2
Add UMA to passphrase dialog.
Count how often the passphrase dialog is displayed and closed, and whether the entered passphrase was correct. Related changelist which defines ManagedMode_PassphraseCorrect in the histograms.xml: https://chromereviews.googleplex.com/7312014/ BUG=171382 TEST=Manual Review URL: https://chromiumcodereview.appspot.com/12604013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192055 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/webui')
-rw-r--r--chrome/browser/ui/webui/managed_user_passphrase_dialog.cc15
1 files changed, 12 insertions, 3 deletions
diff --git a/chrome/browser/ui/webui/managed_user_passphrase_dialog.cc b/chrome/browser/ui/webui/managed_user_passphrase_dialog.cc
index 601ba95..64f92fca 100644
--- a/chrome/browser/ui/webui/managed_user_passphrase_dialog.cc
+++ b/chrome/browser/ui/webui/managed_user_passphrase_dialog.cc
@@ -9,6 +9,7 @@
#include "base/bind.h"
#include "base/memory/weak_ptr.h"
+#include "base/metrics/histogram.h"
#include "base/prefs/pref_service.h"
#include "base/values.h"
#include "chrome/browser/managed_mode/managed_user_passphrase.h"
@@ -16,6 +17,7 @@
#include "chrome/browser/ui/webui/constrained_web_dialog_ui.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/url_constants.h"
+#include "content/public/browser/user_metrics.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_ui_data_source.h"
#include "content/public/browser/web_ui_message_handler.h"
@@ -24,6 +26,8 @@
#include "ui/base/resource/resource_bundle.h"
#include "ui/gfx/size.h"
+using content::UserMetricsAction;
+
namespace {
// Handles the message when the user entered a passphrase and clicks the Unlock
@@ -50,7 +54,8 @@ class ManagedUserPassphraseDialogMessageHandler
};
ManagedUserPassphraseDialogMessageHandler
- ::ManagedUserPassphraseDialogMessageHandler() : weak_factory_(this) {
+ ::ManagedUserPassphraseDialogMessageHandler()
+ : ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)) {
}
void ManagedUserPassphraseDialogMessageHandler::RegisterMessages() {
@@ -83,9 +88,10 @@ void ManagedUserPassphraseDialogMessageHandler::CheckPassphrase(
// Check if the entered passphrase is correct and give the result back to the
// UI.
- base::FundamentalValue passphrase_correct(
- stored_passphrase_hash == encoded_passphrase_hash);
+ bool is_correct = stored_passphrase_hash == encoded_passphrase_hash;
+ base::FundamentalValue passphrase_correct(is_correct);
web_ui()->CallJavascriptFunction("passphraseResult", passphrase_correct);
+ UMA_HISTOGRAM_BOOLEAN("ManagedMode_PassphraseCorrect", is_correct);
}
} // namespace
@@ -93,6 +99,7 @@ void ManagedUserPassphraseDialogMessageHandler::CheckPassphrase(
ManagedUserPassphraseDialog::ManagedUserPassphraseDialog(
content::WebContents* web_contents,
const PassphraseCheckedCallback& callback) : callback_(callback) {
+ content::RecordAction(UserMetricsAction("ManagedMode_OpenPassphraseDialog"));
Profile* profile =
Profile::FromBrowserContext(web_contents->GetBrowserContext());
CreateDataSource(profile);
@@ -135,6 +142,8 @@ void ManagedUserPassphraseDialog::OnDialogClosed(
if (!callback_.is_null()) {
callback_.Run(!json_retval.empty());
callback_.Reset();
+ content::RecordAction(
+ UserMetricsAction("ManagedMode_ClosePassphraseDialog"));
}
}