diff options
author | erg@chromium.org <erg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-12 23:04:41 +0000 |
---|---|---|
committer | erg@chromium.org <erg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-12 23:04:41 +0000 |
commit | c72275dc6492eed399515a341ba17641fe6c798e (patch) | |
tree | de6207a2139df8f4708b39c364180affe3dc0183 /chrome/browser/ui/window_sizer | |
parent | f06b05978f9fe04dbf3ca754d8f2f01270690efe (diff) | |
download | chromium_src-c72275dc6492eed399515a341ba17641fe6c798e.zip chromium_src-c72275dc6492eed399515a341ba17641fe6c798e.tar.gz chromium_src-c72275dc6492eed399515a341ba17641fe6c798e.tar.bz2 |
Revert 269892 "linux_aura: Compile ash into chrome."
Major regression in chrome-si/initializers. Reverting for now to fix.
> linux_aura: Compile ash into chrome.
>
> Running chrome with the "--open-ash" parameter will create an ash
> desktop window. Ash on Linux has some problems, but at least we're now
> compiling the code into the binary.
>
> TODO: The applist isn't positioned correctly, and some details of the
> system tray aren't correct.
>
> BUG=300084, 303862
> R=sky@chromium.org
>
> Review URL: https://codereview.chromium.org/25108005
TBR=erg@chromium.org
Review URL: https://codereview.chromium.org/276773004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269902 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/window_sizer')
-rw-r--r-- | chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc | 2 | ||||
-rw-r--r-- | chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc | 40 |
2 files changed, 5 insertions, 37 deletions
diff --git a/chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc b/chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc index a688ebf..4637433 100644 --- a/chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc +++ b/chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc @@ -67,7 +67,7 @@ void OpenBrowserUsingShelfOnRootWindow(aura::Window* root_window) { } // namespace -#if !defined(OS_CHROMEOS) +#if defined(OS_WIN) #define MAYBE_OpenBrowserUsingShelfOnOtherDisplay DISABLED_OpenBrowserUsingShelfOnOtherDisplay #define MAYBE_OpenBrowserUsingContextMenuOnOtherDisplay DISABLED_OpenBrowserUsingContextMenuOnOtherDisplay #else diff --git a/chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc b/chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc index 4bd32d5..a33aa20 100644 --- a/chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc +++ b/chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc @@ -92,17 +92,9 @@ scoped_ptr<TestBrowserWindowAura> CreateTestBrowserWindow( } // namespace -// On desktop linux aura, we currently don't use the ash frame, breaking some -// tests which expect ash sizes: http://crbug.com/303862 -#if defined(OS_LINUX) && !defined(OS_CHROMEOS) -#define MAYBE_DefaultSizeCase DISABLED_DefaultSizeCase -#else -#define MAYBE_DefaultSizeCase DefaultSizeCase -#endif - // Test that the window is sized appropriately for the first run experience // where the default window bounds calculation is invoked. -TEST_F(WindowSizerAshTest, MAYBE_DefaultSizeCase) { +TEST_F(WindowSizerAshTest, DefaultSizeCase) { #if defined(OS_WIN) CommandLine::ForCurrentProcess()->AppendSwitch(switches::kOpenAsh); #endif @@ -459,16 +451,8 @@ TEST_F(WindowSizerAshTest, LastWindowOffscreenWithNonAggressiveRepositioning) { } } -// On desktop linux aura, we currently don't use the ash frame, breaking some -// tests which expect ash sizes: http://crbug.com/303862 -#if defined(OS_LINUX) && !defined(OS_CHROMEOS) -#define MAYBE_PlaceNewWindows DISABLED_PlaceNewWindows -#else -#define MAYBE_PlaceNewWindows PlaceNewWindows -#endif - // Test the placement of newly created windows. -TEST_F(WindowSizerAshTest, MAYBE_PlaceNewWindows) { +TEST_F(WindowSizerAshTest, PlaceNewWindows) { // Create a browser which we can use to pass into the GetWindowBounds // function. scoped_ptr<TestingProfile> profile(new TestingProfile()); @@ -537,18 +521,10 @@ TEST_F(WindowSizerAshTest, MAYBE_PlaceNewWindows) { } } -// On desktop linux aura, we currently don't use the ash frame, breaking some -// tests which expect ash sizes: http://crbug.com/303862 -#if defined(OS_LINUX) && !defined(OS_CHROMEOS) -#define MAYBE_PlaceNewBrowserWindowOnEmptyDesktop DISABLED_PlaceNewBrowserWindowOnEmptyDesktop -#else -#define MAYBE_PlaceNewBrowserWindowOnEmptyDesktop PlaceNewBrowserWindowOnEmptyDesktop -#endif - // Test the placement of newly created windows on an empty desktop. // This test supplements "PlaceNewWindows" by testing the creation of a newly // created browser window on an empty desktop. -TEST_F(WindowSizerAshTest, MAYBE_PlaceNewBrowserWindowOnEmptyDesktop) { +TEST_F(WindowSizerAshTest, PlaceNewBrowserWindowOnEmptyDesktop) { // Create a browser which we can use to pass into the GetWindowBounds // function. scoped_ptr<TestingProfile> profile(new TestingProfile()); @@ -719,16 +695,8 @@ TEST_F(WindowSizerAshTest, MAYBE_PlaceNewWindowsOnMultipleDisplays) { } } -// On desktop linux aura, we currently don't use the ash frame, breaking some -// tests which expect ash sizes: http://crbug.com/303862 -#if defined(OS_LINUX) && !defined(OS_CHROMEOS) -#define MAYBE_TestShowState DISABLED_TestShowState -#else -#define MAYBE_TestShowState TestShowState -#endif - // Test that the show state is properly returned for non default cases. -TEST_F(WindowSizerAshTest, MAYBE_TestShowState) { +TEST_F(WindowSizerAshTest, TestShowState) { scoped_ptr<TestingProfile> profile(new TestingProfile()); // Creating a browser & window to play with. |