diff options
author | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-17 18:19:25 +0000 |
---|---|---|
committer | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-17 18:19:25 +0000 |
commit | da87688e8571282c47493c4f9da3b68dbf1b642c (patch) | |
tree | 4c85957a1785903d77993ef48ef54927def146cc /chrome/browser/ui | |
parent | 350584cd74487989ad3debad5a6d2b83cbfe80b2 (diff) | |
download | chromium_src-da87688e8571282c47493c4f9da3b68dbf1b642c.zip chromium_src-da87688e8571282c47493c4f9da3b68dbf1b642c.tar.gz chromium_src-da87688e8571282c47493c4f9da3b68dbf1b642c.tar.bz2 |
retry 137554 - convert help page to loadTimeData
BUG=122753
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/10408007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137691 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui')
-rw-r--r-- | chrome/browser/ui/webui/help/help_browsertest.js | 21 | ||||
-rw-r--r-- | chrome/browser/ui/webui/help/help_ui.cc | 1 |
2 files changed, 22 insertions, 0 deletions
diff --git a/chrome/browser/ui/webui/help/help_browsertest.js b/chrome/browser/ui/webui/help/help_browsertest.js new file mode 100644 index 0000000..77d4481 --- /dev/null +++ b/chrome/browser/ui/webui/help/help_browsertest.js @@ -0,0 +1,21 @@ +// Copyright (c) 2012 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +/** + * TestFixture for extension settings WebUI testing. + * @extends {testing.Test} + * @constructor + */ +function HelpPageWebUITest() {} + +HelpPageWebUITest.prototype = { + __proto__: testing.Test.prototype, + + browsePreload: 'chrome://help-frame/', +}; + +// Test opening extension settings has correct location. +TEST_F('HelpPageWebUITest', 'testOpenHelpPage', function() { + assertEquals(this.browsePreload, document.location.href); +}); diff --git a/chrome/browser/ui/webui/help/help_ui.cc b/chrome/browser/ui/webui/help/help_ui.cc index 0c53d19..88ef864 100644 --- a/chrome/browser/ui/webui/help/help_ui.cc +++ b/chrome/browser/ui/webui/help/help_ui.cc @@ -21,6 +21,7 @@ ChromeWebUIDataSource* CreateAboutPageHTMLSource() { new ChromeWebUIDataSource(chrome::kChromeUIHelpFrameHost); source->set_json_path("strings.js"); + source->set_use_json_js_format_v2(); source->add_resource_path("help.js", IDR_HELP_JS); source->set_default_resource(IDR_HELP_HTML); return source; |