diff options
author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-21 22:35:56 +0000 |
---|---|---|
committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-21 22:35:56 +0000 |
commit | f5fa20e471b2fc9bb18f6f673146704483d0b18e (patch) | |
tree | 0fc2253432ce98c202ae00afdea927f5bda22730 /chrome/browser/ui | |
parent | ec55bd7353cbae29541cc348869319104e7349f4 (diff) | |
download | chromium_src-f5fa20e471b2fc9bb18f6f673146704483d0b18e.zip chromium_src-f5fa20e471b2fc9bb18f6f673146704483d0b18e.tar.gz chromium_src-f5fa20e471b2fc9bb18f6f673146704483d0b18e.tar.bz2 |
Revert 115346. The change didn't break anything, the test was faulty. Will disable in a followup. - Revert r115276, it broke PanelDownloadTest.Download in interactive_ui_tests
on win,linux,mac.
Original change: Rename TabContents::controller() to GetController and put it into the WebContents namespace.
BUG=98716
TBR=dpranke
Review URL: http://codereview.chromium.org/8956050
TBR=jam
Review URL: http://codereview.chromium.org/9018016
TBR=thakis@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115428 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui')
49 files changed, 162 insertions, 158 deletions
diff --git a/chrome/browser/ui/auto_login_prompter.cc b/chrome/browser/ui/auto_login_prompter.cc index 9bb0994..ae47d63 100644 --- a/chrome/browser/ui/auto_login_prompter.cc +++ b/chrome/browser/ui/auto_login_prompter.cc @@ -227,7 +227,7 @@ AutoLoginPrompter::AutoLoginPrompter( args_(args) { registrar_.Add(this, content::NOTIFICATION_LOAD_STOP, content::Source<NavigationController>( - &tab_contents_->controller())); + &tab_contents_->GetController())); registrar_.Add(this, content::NOTIFICATION_TAB_CONTENTS_DESTROYED, content::Source<TabContents>(tab_contents_)); } @@ -333,7 +333,7 @@ void AutoLoginPrompter::Observe(int type, InfoBarTabHelper* infobar_helper = wrapper->infobar_tab_helper(); Profile* profile = wrapper->profile(); infobar_helper->AddInfoBar(new AutoLoginInfoBarDelegate( - infobar_helper, &tab_contents_->controller(), + infobar_helper, &tab_contents_->GetController(), profile->GetTokenService(), profile->GetPrefs(), username_, args_)); } diff --git a/chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc b/chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc index fc24f03..ac3b8d6 100644 --- a/chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc +++ b/chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc @@ -80,7 +80,8 @@ void BlockedContentTabHelper::AddPopup(TabContentsWrapper* new_contents, // entry is the page to be loaded as we navigate away from the unloading // page. For this reason, we can't use GetURL() to get the opener URL, // because it returns the active entry. - NavigationEntry* entry = tab_contents()->controller().GetLastCommittedEntry(); + NavigationEntry* entry = + tab_contents()->GetController().GetLastCommittedEntry(); GURL creator = entry ? entry->virtual_url() : GURL::EmptyGURL(); Profile* profile = Profile::FromBrowserContext(tab_contents()->browser_context()); diff --git a/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc b/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc index 5e22dee..b4aa381 100644 --- a/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc +++ b/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc @@ -49,7 +49,7 @@ bool BookmarkTabHelper::ShouldShowBookmarkBar() { // is very similar, but for non-first loads, we want to use the committed // entry. This is so the bookmarks bar disappears at the same time the page // does. - if (tab_contents()->controller().GetLastCommittedEntry()) { + if (tab_contents()->GetController().GetLastCommittedEntry()) { // Not the first load, always use the committed Web UI. return CanShowBookmarkBar(tab_contents()->committed_web_ui()); } diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc index 9f2b127..d9ffe73 100644 --- a/chrome/browser/ui/browser.cc +++ b/chrome/browser/ui/browser.cc @@ -1305,7 +1305,7 @@ TabContents* Browser::AddRestoredTab( std::vector<NavigationEntry*> entries; TabNavigation::CreateNavigationEntriesFromTabNavigations( profile_, navigations, &entries); - new_tab->controller().Restore( + new_tab->GetController().Restore( selected_navigation, from_last_session, &entries); DCHECK_EQ(0u, entries.size()); @@ -1328,7 +1328,7 @@ TabContents* Browser::AddRestoredTab( // contains similar logic. new_tab->GetView()->SizeContents(window_->GetRestoredBounds().size()); new_tab->HideContents(); - new_tab->controller().LoadIfNecessary(); + new_tab->GetController().LoadIfNecessary(); } SessionService* session_service = SessionServiceFactory::GetForProfileIfExisting(profile_); @@ -1355,7 +1355,7 @@ void Browser::ReplaceRestoredTab( std::vector<NavigationEntry*> entries; TabNavigation::CreateNavigationEntriesFromTabNavigations( profile_, navigations, &entries); - replacement->controller().Restore( + replacement->GetController().Restore( selected_navigation, from_last_session, &entries); DCHECK_EQ(0u, entries.size()); @@ -1371,7 +1371,7 @@ bool Browser::CanRestoreTab() { bool Browser::NavigateToIndexWithDisposition(int index, WindowOpenDisposition disp) { NavigationController& controller = - GetOrCloneTabForDisposition(disp)->controller(); + GetOrCloneTabForDisposition(disp)->GetController(); if (index < 0 || index >= controller.entry_count()) return false; controller.GoToIndex(index); @@ -1500,7 +1500,7 @@ bool Browser::IsClosingPermitted() { bool Browser::CanGoBack() const { return GetSelectedTabContentsWrapper()-> - tab_contents()->controller().CanGoBack(); + tab_contents()->GetController().CanGoBack(); } void Browser::GoBack(WindowOpenDisposition disposition) { @@ -1514,19 +1514,19 @@ void Browser::GoBack(WindowOpenDisposition disposition) { if (current_tab->tab_contents()->showing_interstitial_page() && (new_tab != current_tab->tab_contents())) return; - new_tab->controller().GoBack(); + new_tab->GetController().GoBack(); } } bool Browser::CanGoForward() const { return GetSelectedTabContentsWrapper()-> - tab_contents()->controller().CanGoForward(); + tab_contents()->GetController().CanGoForward(); } void Browser::GoForward(WindowOpenDisposition disposition) { content::RecordAction(UserMetricsAction("Forward")); if (CanGoForward()) - GetOrCloneTabForDisposition(disposition)->controller().GoForward(); + GetOrCloneTabForDisposition(disposition)->GetController().GoForward(); } void Browser::Reload(WindowOpenDisposition disposition) { @@ -1544,7 +1544,7 @@ void Browser::ReloadInternal(WindowOpenDisposition disposition, // If we are showing an interstitial, treat this as an OpenURL. TabContents* current_tab = GetSelectedTabContents(); if (current_tab && current_tab->showing_interstitial_page()) { - NavigationEntry* entry = current_tab->controller().GetActiveEntry(); + NavigationEntry* entry = current_tab->GetController().GetActiveEntry(); DCHECK(entry); // Should exist if interstitial is showing. OpenURL(entry->url(), GURL(), disposition, content::PAGE_TRANSITION_RELOAD); return; @@ -1555,9 +1555,9 @@ void Browser::ReloadInternal(WindowOpenDisposition disposition, if (!tab->FocusLocationBarByDefault()) tab->Focus(); if (ignore_cache) - tab->controller().ReloadIgnoringCache(true); + tab->GetController().ReloadIgnoringCache(true); else - tab->controller().Reload(true); + tab->GetController().Reload(true); } void Browser::Home(WindowOpenDisposition disposition) { @@ -2061,7 +2061,7 @@ void Browser::OpenCreateShortcutsDialog() { "Menu item should be disabled."; NavigationEntry* entry = - current_tab->tab_contents()->controller().GetLastCommittedEntry(); + current_tab->tab_contents()->GetController().GetLastCommittedEntry(); if (!entry) return; @@ -2175,7 +2175,7 @@ void Browser::ShowAboutConflictsTab() { void Browser::ShowBrokenPageTab(TabContents* contents) { content::RecordAction(UserMetricsAction("ReportBug")); string16 page_title = contents->GetTitle(); - NavigationEntry* entry = contents->controller().GetActiveEntry(); + NavigationEntry* entry = contents->GetController().GetActiveEntry(); if (!entry) return; std::string page_url = entry->url().spec(); @@ -3095,7 +3095,7 @@ TabContentsWrapper* Browser::CreateTabContentsForURL( if (!defer_load) { // Load the initial URL before adding the new tab contents to the tab strip // so that the tab contents has navigation state. - contents->tab_contents()->controller().LoadURL( + contents->tab_contents()->GetController().LoadURL( url, referrer, transition, std::string()); } @@ -3103,7 +3103,7 @@ TabContentsWrapper* Browser::CreateTabContentsForURL( } bool Browser::CanDuplicateContentsAt(int index) { - NavigationController& nc = GetTabContentsAt(index)->controller(); + NavigationController& nc = GetTabContentsAt(index)->GetController(); return nc.tab_contents() && nc.GetLastCommittedEntry(); } @@ -3182,7 +3182,7 @@ void Browser::CreateHistoricalTab(TabContentsWrapper* contents) { // We only create historical tab entries for tabbed browser windows. if (service && CanSupportWindowFeature(FEATURE_TABSTRIP)) { - service->CreateHistoricalTab(&contents->tab_contents()->controller(), + service->CreateHistoricalTab(&contents->tab_contents()->GetController(), tab_handler_->GetTabStripModel()->GetIndexOfTabContents(contents)); } } @@ -3274,7 +3274,7 @@ void Browser::TabClosingAt(TabStripModel* tab_strip_model, content::NotificationService::current()->Notify( content::NOTIFICATION_TAB_CLOSING, content::Source<NavigationController>( - &contents->tab_contents()->controller()), + &contents->tab_contents()->GetController()), content::NotificationService::NoDetails()); // Sever the TabContents' connection back to us. @@ -3372,11 +3372,11 @@ void Browser::TabReplacedAt(TabStripModel* tab_strip_model, TabInsertedAt(new_contents, index, (index == tab_handler_->GetTabStripModel()->active_index())); - int entry_count = new_contents->tab_contents()->controller().entry_count(); + int entry_count = new_contents->tab_contents()->GetController().entry_count(); if (entry_count > 0) { // Send out notification so that observers are updated appropriately. - new_contents->tab_contents()->controller().NotifyEntryChanged( - new_contents->tab_contents()->controller().GetEntryAtIndex( + new_contents->tab_contents()->GetController().NotifyEntryChanged( + new_contents->tab_contents()->GetController().GetEntryAtIndex( entry_count - 1), entry_count - 1); } @@ -3544,7 +3544,7 @@ void Browser::LoadingStateChanged(TabContents* source) { // last committed entry is not NULL. Last committed entry could be NULL // when an interstitial page is injected (e.g. bad https certificate, // malware site etc). When this happens, we abort the shortcut update. - NavigationEntry* entry = source->controller().GetLastCommittedEntry(); + NavigationEntry* entry = source->GetController().GetLastCommittedEntry(); if (entry) { TabContentsWrapper::GetCurrentWrapperForContents(source)-> extension_tab_helper()->GetApplicationInfo(entry->page_id()); @@ -3645,7 +3645,7 @@ bool Browser::IsApplication() const { } void Browser::ConvertContentsToApplication(TabContents* contents) { - const GURL& url = contents->controller().GetActiveEntry()->url(); + const GURL& url = contents->GetController().GetActiveEntry()->url(); std::string app_name = web_app::GenerateApplicationNameFromURL(url); DetachContents(contents); @@ -3763,7 +3763,7 @@ void Browser::OnStartDownload(TabContents* source, } // If the download occurs in a new tab, close it. - if (source->controller().IsInitialNavigation() && tab_count() > 1) + if (source->GetController().IsInitialNavigation() && tab_count() > 1) CloseContents(source); } @@ -3990,7 +3990,7 @@ void Browser::OnDidGetApplicationInfo(TabContentsWrapper* source, return; NavigationEntry* entry = - source->tab_contents()->controller().GetLastCommittedEntry(); + source->tab_contents()->GetController().GetLastCommittedEntry(); if (!entry || (entry->page_id() != page_id)) return; @@ -4101,7 +4101,7 @@ void Browser::Observe(int type, // actually be for a different window while we're doing asynchronous // closing of this one. if (GetSelectedTabContents() && - &GetSelectedTabContents()->controller() == + &GetSelectedTabContents()->GetController() == content::Source<NavigationController>(source).ptr()) UpdateToolbar(false); break; @@ -4581,7 +4581,7 @@ void Browser::UpdateCommandsForTabState() { return; // Navigation commands - NavigationController& nc = current_tab->controller(); + NavigationController& nc = current_tab->GetController(); command_updater_.UpdateCommandEnabled(IDC_BACK, nc.CanGoBack()); command_updater_.UpdateCommandEnabled(IDC_FORWARD, nc.CanGoForward()); command_updater_.UpdateCommandEnabled(IDC_RELOAD, @@ -4597,7 +4597,7 @@ void Browser::UpdateCommandsForTabState() { window_->SetStarredState( current_tab_wrapper->bookmark_tab_helper()->is_starred()); command_updater_.UpdateCommandEnabled(IDC_VIEW_SOURCE, - current_tab->controller().CanViewSource()); + current_tab->GetController().CanViewSource()); command_updater_.UpdateCommandEnabled(IDC_EMAIL_PAGE_LOCATION, toolbar_model_.ShouldDisplayURL() && current_tab->GetURL().is_valid()); if (is_devtools()) @@ -4753,7 +4753,7 @@ void Browser::ScheduleUIUpdate(const TabContents* source, // this for any tab so they start & stop quickly. tab_handler_->GetTabStripModel()->UpdateTabContentsStateAt( tab_handler_->GetTabStripModel()->GetIndexOfController( - &source->controller()), + &source->GetController()), TabStripModelObserver::LOADING_ONLY); // The status bubble needs to be updated during INVALIDATE_LOAD too, but // we do that asynchronously by not stripping INVALIDATE_LOAD from @@ -4767,7 +4767,7 @@ void Browser::ScheduleUIUpdate(const TabContents* source, // asynchronously. tab_handler_->GetTabStripModel()->UpdateTabContentsStateAt( tab_handler_->GetTabStripModel()->GetIndexOfController( - &source->controller()), + &source->GetController()), TabStripModelObserver::TITLE_NOT_LOADING); } @@ -5175,7 +5175,7 @@ bool Browser::OpenInstant(WindowOpenDisposition disposition) { // HideInstant is invoked after release so that InstantController is not // active when HideInstant asks it for its state. HideInstant(); - preview_contents->tab_contents()->controller().PruneAllButActive(); + preview_contents->tab_contents()->GetController().PruneAllButActive(); tab_handler_->GetTabStripModel()->AddTabContents( preview_contents, -1, @@ -5207,7 +5207,7 @@ void Browser::ViewSource(TabContentsWrapper* contents) { DCHECK(contents); NavigationEntry* active_entry = - contents->tab_contents()->controller().GetActiveEntry(); + contents->tab_contents()->GetController().GetActiveEntry(); if (!active_entry) return; @@ -5221,9 +5221,9 @@ void Browser::ViewSource(TabContentsWrapper* contents, DCHECK(contents); TabContentsWrapper* view_source_contents = contents->Clone(); - view_source_contents->tab_contents()->controller().PruneAllButActive(); + view_source_contents->tab_contents()->GetController().PruneAllButActive(); NavigationEntry* active_entry = - view_source_contents->tab_contents()->controller().GetActiveEntry(); + view_source_contents->tab_contents()->GetController().GetActiveEntry(); if (!active_entry) return; @@ -5277,7 +5277,8 @@ int Browser::GetContentRestrictionsForSelectedTab() { TabContents* current_tab = GetSelectedTabContents(); if (current_tab) { content_restrictions = current_tab->content_restrictions(); - NavigationEntry* active_entry = current_tab->controller().GetActiveEntry(); + NavigationEntry* active_entry = + current_tab->GetController().GetActiveEntry(); // See comment in UpdateCommandsForTabState about why we call url(). if (!SavePackage::IsSavableURL(active_entry ? active_entry->url() : GURL()) || current_tab->showing_interstitial_page()) diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc index 91bedf1..4bbfe20 100644 --- a/chrome/browser/ui/browser_browsertest.cc +++ b/chrome/browser/ui/browser_browsertest.cc @@ -398,9 +398,9 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, NullOpenerRedirectForksProcess) { EXPECT_TRUE(newtab); EXPECT_NE(oldtab, newtab); nav_observer.Wait(); - ASSERT_TRUE(newtab->controller().GetLastCommittedEntry()); + ASSERT_TRUE(newtab->GetController().GetLastCommittedEntry()); EXPECT_EQ(https_url.spec(), - newtab->controller().GetLastCommittedEntry()->url().spec()); + newtab->GetController().GetLastCommittedEntry()->url().spec()); // Popup window should not be in the opener's process. content::RenderProcessHost* popup_process = @@ -432,9 +432,9 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, NullOpenerRedirectForksProcess) { EXPECT_TRUE(newtab2); EXPECT_NE(oldtab, newtab2); nav_observer2.Wait(); - ASSERT_TRUE(newtab2->controller().GetLastCommittedEntry()); + ASSERT_TRUE(newtab2->GetController().GetLastCommittedEntry()); EXPECT_EQ(https_url.spec(), - newtab2->controller().GetLastCommittedEntry()->url().spec()); + newtab2->GetController().GetLastCommittedEntry()->url().spec()); // This popup window should also not be in the opener's process. content::RenderProcessHost* popup_process2 = @@ -485,9 +485,9 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, OtherRedirectsDontForkProcess) { EXPECT_TRUE(newtab); EXPECT_NE(oldtab, newtab); nav_observer.Wait(); - ASSERT_TRUE(newtab->controller().GetLastCommittedEntry()); + ASSERT_TRUE(newtab->GetController().GetLastCommittedEntry()); EXPECT_EQ(https_url.spec(), - newtab->controller().GetLastCommittedEntry()->url().spec()); + newtab->GetController().GetLastCommittedEntry()->url().spec()); // Popup window should still be in the opener's process. content::RenderProcessHost* popup_process = @@ -505,9 +505,9 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, OtherRedirectsDontForkProcess) { oldtab->GetRenderViewHost()-> ExecuteJavascriptInWebFrame(string16(), ASCIIToUTF16(navigate_str)); nav_observer2.Wait(); - ASSERT_TRUE(oldtab->controller().GetLastCommittedEntry()); + ASSERT_TRUE(oldtab->GetController().GetLastCommittedEntry()); EXPECT_EQ(https_url.spec(), - oldtab->controller().GetLastCommittedEntry()->url().spec()); + oldtab->GetController().GetLastCommittedEntry()->url().spec()); // Original window should still be in the original process. content::RenderProcessHost* new_process = newtab->GetRenderProcessHost(); @@ -662,7 +662,7 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, ui_test_utils::NavigateToURL(browser(), url); NavigationEntry* entry = browser()->GetSelectedTabContents()-> - controller().GetActiveEntry(); + GetController().GetActiveEntry(); EXPECT_EQ(expected_favicon_url.spec(), entry->favicon().url().spec()); } @@ -682,7 +682,7 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, MAYBE_FaviconChange) { ui_test_utils::NavigateToURL(browser(), file_url); NavigationEntry* entry = browser()->GetSelectedTabContents()-> - controller().GetActiveEntry(); + GetController().GetActiveEntry(); static const FilePath::CharType* kIcon = FILE_PATH_LITERAL("test1.png"); GURL expected_favicon_url( @@ -1151,7 +1151,7 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, ForwardDisabledOnForward) { ui_test_utils::WindowedNotificationObserver back_nav_load_observer( content::NOTIFICATION_LOAD_STOP, content::Source<NavigationController>( - &browser()->GetSelectedTabContents()->controller())); + &browser()->GetSelectedTabContents()->GetController())); browser()->GoBack(CURRENT_TAB); back_nav_load_observer.Wait(); EXPECT_TRUE(browser()->command_updater()->IsCommandEnabled(IDC_FORWARD)); @@ -1159,7 +1159,7 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, ForwardDisabledOnForward) { ui_test_utils::WindowedNotificationObserver forward_nav_load_observer( content::NOTIFICATION_LOAD_STOP, content::Source<NavigationController>( - &browser()->GetSelectedTabContents()->controller())); + &browser()->GetSelectedTabContents()->GetController())); browser()->GoForward(CURRENT_TAB); // This check will happen before the navigation completes, since the browser // won't process the renderer's response until the Wait() call below. diff --git a/chrome/browser/ui/browser_navigator.cc b/chrome/browser/ui/browser_navigator.cc index 84a673f..c4a6aec 100644 --- a/chrome/browser/ui/browser_navigator.cc +++ b/chrome/browser/ui/browser_navigator.cc @@ -247,19 +247,19 @@ void LoadURLInContents(TabContents* target_contents, browser::NavigateParams* params, const std::string& extra_headers) { if (params->transferred_global_request_id != GlobalRequestID()) { - target_contents->controller().TransferURL( + target_contents->GetController().TransferURL( url, params->referrer, params->transition, extra_headers, params->transferred_global_request_id, params->is_renderer_initiated); } else if (params->is_renderer_initiated) { - target_contents->controller().LoadURLFromRenderer( + target_contents->GetController().LoadURLFromRenderer( url, params->referrer, params->transition, extra_headers); } else { - target_contents->controller().LoadURL( + target_contents->GetController().LoadURL( url, params->referrer, params->transition, extra_headers); @@ -569,7 +569,7 @@ void Navigate(NavigateParams* params) { TabContents* target = params->browser->GetTabContentsAt(singleton_index); if (target->is_crashed()) { - target->controller().Reload(true); + target->GetController().Reload(true); } else if (params->path_behavior == NavigateParams::IGNORE_AND_NAVIGATE && target->GetURL() != params->url) { InitializeExtraHeaders(params, NULL, &extra_headers); diff --git a/chrome/browser/ui/cocoa/applescript/tab_applescript.mm b/chrome/browser/ui/cocoa/applescript/tab_applescript.mm index cf43749..b215f1a 100644 --- a/chrome/browser/ui/cocoa/applescript/tab_applescript.mm +++ b/chrome/browser/ui/cocoa/applescript/tab_applescript.mm @@ -187,7 +187,7 @@ static NSAppleEventDescriptor* valueToDescriptor(Value* value) { } NavigationEntry* entry = - tabContents_->tab_contents()->controller().GetActiveEntry(); + tabContents_->tab_contents()->GetController().GetActiveEntry(); if (!entry) { return nil; } @@ -211,7 +211,7 @@ static NSAppleEventDescriptor* valueToDescriptor(Value* value) { } NavigationEntry* entry = - tabContents_->tab_contents()->controller().GetActiveEntry(); + tabContents_->tab_contents()->GetController().GetActiveEntry(); if (!entry) return; @@ -226,7 +226,7 @@ static NSAppleEventDescriptor* valueToDescriptor(Value* value) { - (NSString*)title { NavigationEntry* entry = - tabContents_->tab_contents()->controller().GetActiveEntry(); + tabContents_->tab_contents()->GetController().GetActiveEntry(); if (!entry) return nil; @@ -305,21 +305,21 @@ static NSAppleEventDescriptor* valueToDescriptor(Value* value) { - (void)handlesGoBackScriptCommand:(NSScriptCommand*)command { NavigationController& navigationController = - tabContents_->tab_contents()->controller(); + tabContents_->tab_contents()->GetController(); if (navigationController.CanGoBack()) navigationController.GoBack(); } - (void)handlesGoForwardScriptCommand:(NSScriptCommand*)command { NavigationController& navigationController = - tabContents_->tab_contents()->controller(); + tabContents_->tab_contents()->GetController(); if (navigationController.CanGoForward()) navigationController.GoForward(); } - (void)handlesReloadScriptCommand:(NSScriptCommand*)command { NavigationController& navigationController = - tabContents_->tab_contents()->controller(); + tabContents_->tab_contents()->GetController(); const bool checkForRepost = true; navigationController.Reload(checkForRepost); } @@ -388,7 +388,7 @@ static NSAppleEventDescriptor* valueToDescriptor(Value* value) { - (void)handlesViewSourceScriptCommand:(NSScriptCommand*)command { NavigationEntry* entry = - tabContents_->tab_contents()->controller().GetLastCommittedEntry(); + tabContents_->tab_contents()->GetController().GetLastCommittedEntry(); if (entry) { tabContents_->tab_contents()->OpenURL( GURL(chrome::kViewSourceScheme + std::string(":") + diff --git a/chrome/browser/ui/cocoa/constrained_html_delegate_mac.mm b/chrome/browser/ui/cocoa/constrained_html_delegate_mac.mm index 426d959..29494e7 100644 --- a/chrome/browser/ui/cocoa/constrained_html_delegate_mac.mm +++ b/chrome/browser/ui/cocoa/constrained_html_delegate_mac.mm @@ -105,10 +105,10 @@ ConstrainedHtmlDelegateMac::ConstrainedHtmlDelegateMac( ConstrainedHtmlUI::GetPropertyAccessor().SetProperty( tab_contents->GetPropertyBag(), this); - tab_contents->controller().LoadURL(delegate->GetDialogContentURL(), - content::Referrer(), - content::PAGE_TRANSITION_START_PAGE, - std::string()); + tab_contents->GetController().LoadURL(delegate->GetDialogContentURL(), + content::Referrer(), + content::PAGE_TRANSITION_START_PAGE, + std::string()); // Create NSWindow to hold tab_contents in the constrained sheet: gfx::Size size; diff --git a/chrome/browser/ui/cocoa/html_dialog_window_controller.mm b/chrome/browser/ui/cocoa/html_dialog_window_controller.mm index 694afe5f..f1daf98 100644 --- a/chrome/browser/ui/cocoa/html_dialog_window_controller.mm +++ b/chrome/browser/ui/cocoa/html_dialog_window_controller.mm @@ -298,11 +298,11 @@ void HtmlDialogWindowDelegateBridge::HandleKeyboardEvent( HtmlDialogUI::GetPropertyAccessor().SetProperty( contentsWrapper_->tab_contents()->GetPropertyBag(), delegate_.get()); - contentsWrapper_->tab_contents()->controller().LoadURL( - delegate_->GetDialogContentURL(), - content::Referrer(), - content::PAGE_TRANSITION_START_PAGE, - std::string()); + contentsWrapper_->tab_contents()->GetController().LoadURL( + delegate_->GetDialogContentURL(), + content::Referrer(), + content::PAGE_TRANSITION_START_PAGE, + std::string()); // TODO(akalin): add accelerator for ESC to close the dialog box. // diff --git a/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm b/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm index 195386b..bcf4086 100644 --- a/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm +++ b/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm @@ -93,7 +93,7 @@ bool LocationIconDecoration::OnMousePressed(NSRect frame) { return true; TabContents* tab = owner_->GetTabContents(); - NavigationEntry* nav_entry = tab->controller().GetActiveEntry(); + NavigationEntry* nav_entry = tab->GetController().GetActiveEntry(); if (!nav_entry) { NOTREACHED(); return true; diff --git a/chrome/browser/ui/cocoa/notifications/balloon_controller.mm b/chrome/browser/ui/cocoa/notifications/balloon_controller.mm index 54ac791..d60c92d 100644 --- a/chrome/browser/ui/cocoa/notifications/balloon_controller.mm +++ b/chrome/browser/ui/cocoa/notifications/balloon_controller.mm @@ -176,7 +176,7 @@ const int kRightMargin = 2; - (void)updateContents { DCHECK(htmlContents_.get()) << "BalloonView::Update called before Show"; if (htmlContents_->tab_contents()) { - htmlContents_->tab_contents()->controller().LoadURL( + htmlContents_->tab_contents()->GetController().LoadURL( balloon_->notification().content_url(), content::Referrer(), content::PAGE_TRANSITION_LINK, std::string()); } diff --git a/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm b/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm index 4b4aa77..a5f5a4d 100644 --- a/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm +++ b/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm @@ -66,7 +66,7 @@ void TabContentsNotificationBridge::ChangeTabContents(TabContents* contents) { registrar_.Add( this, content::NOTIFICATION_RENDER_VIEW_HOST_CHANGED, - content::Source<NavigationController>(&contents->controller())); + content::Source<NavigationController>(&contents->GetController())); } } diff --git a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm index 97c0917..a5988c6 100644 --- a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm +++ b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm @@ -1178,7 +1178,7 @@ private: if (oldContents) { int oldModelIndex = browser_->GetIndexOfController( - &(oldContents->tab_contents()->controller())); + &(oldContents->tab_contents()->GetController())); if (oldModelIndex != -1) { // When closing a tab, the old tab may be gone. NSInteger oldIndex = [self indexFromModelIndex:oldModelIndex]; TabContentsController* oldController = diff --git a/chrome/browser/ui/collected_cookies_infobar_delegate.cc b/chrome/browser/ui/collected_cookies_infobar_delegate.cc index 0bd0d4f..75fad89 100644 --- a/chrome/browser/ui/collected_cookies_infobar_delegate.cc +++ b/chrome/browser/ui/collected_cookies_infobar_delegate.cc @@ -41,6 +41,6 @@ string16 CollectedCookiesInfoBarDelegate::GetButtonLabel( } bool CollectedCookiesInfoBarDelegate::Accept() { - owner()->tab_contents()->controller().Reload(true); + owner()->tab_contents()->GetController().Reload(true); return true; } diff --git a/chrome/browser/ui/find_bar/find_bar_controller.cc b/chrome/browser/ui/find_bar/find_bar_controller.cc index 19e9e1f8..7a3abd9 100644 --- a/chrome/browser/ui/find_bar/find_bar_controller.cc +++ b/chrome/browser/ui/find_bar/find_bar_controller.cc @@ -93,7 +93,7 @@ void FindBarController::ChangeTabContents(TabContentsWrapper* contents) { this, content::NOTIFICATION_NAV_ENTRY_COMMITTED, content::Source<NavigationController>( - &tab_contents_->tab_contents()->controller())); + &tab_contents_->tab_contents()->GetController())); MaybeSetPrepopulateText(); @@ -133,7 +133,7 @@ void FindBarController::Observe(int type, } else if (type == content::NOTIFICATION_NAV_ENTRY_COMMITTED) { NavigationController* source_controller = content::Source<NavigationController>(source).ptr(); - if (source_controller == &tab_contents_->tab_contents()->controller()) { + if (source_controller == &tab_contents_->tab_contents()->GetController()) { content::LoadCommittedDetails* commit_details = content::Details<content::LoadCommittedDetails>(details).ptr(); content::PageTransition transition_type = diff --git a/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc b/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc index acbcb2f..a77db9c 100644 --- a/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc +++ b/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc @@ -589,7 +589,7 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, FindDisappearOnNavigate) { content::NOTIFICATION_LOAD_STOP, content::Source<NavigationController>( &browser()->GetSelectedTabContentsWrapper()->tab_contents()-> - controller())); + GetController())); browser()->Reload(CURRENT_TAB); observer.Wait(); @@ -1115,7 +1115,7 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, ActivateLinkNavigatesPage) { ui_test_utils::WindowedNotificationObserver observer( content::NOTIFICATION_LOAD_STOP, content::Source<NavigationController>( - &tab->tab_contents()->controller())); + &tab->tab_contents()->GetController())); tab->find_tab_helper()->StopFinding(FindBarController::kActivateSelection); observer.Wait(); } diff --git a/chrome/browser/ui/gtk/constrained_html_delegate_gtk.cc b/chrome/browser/ui/gtk/constrained_html_delegate_gtk.cc index 50de533..6701c7f 100644 --- a/chrome/browser/ui/gtk/constrained_html_delegate_gtk.cc +++ b/chrome/browser/ui/gtk/constrained_html_delegate_gtk.cc @@ -108,10 +108,10 @@ ConstrainedHtmlDelegateGtk::ConstrainedHtmlDelegateGtk( ConstrainedHtmlUI::GetPropertyAccessor().SetProperty( tab_contents->GetPropertyBag(), this); - tab_contents->controller().LoadURL(delegate->GetDialogContentURL(), - content::Referrer(), - content::PAGE_TRANSITION_START_PAGE, - std::string()); + tab_contents->GetController().LoadURL(delegate->GetDialogContentURL(), + content::Referrer(), + content::PAGE_TRANSITION_START_PAGE, + std::string()); tab_contents_container_.SetTab(tab_.get()); gfx::Size dialog_size; diff --git a/chrome/browser/ui/gtk/html_dialog_gtk.cc b/chrome/browser/ui/gtk/html_dialog_gtk.cc index f1059a8..405bbd7 100644 --- a/chrome/browser/ui/gtk/html_dialog_gtk.cc +++ b/chrome/browser/ui/gtk/html_dialog_gtk.cc @@ -179,7 +179,7 @@ gfx::NativeWindow HtmlDialogGtk::InitDialog() { HtmlDialogUI::GetPropertyAccessor().SetProperty( tab_->tab_contents()->GetPropertyBag(), this); - tab_->tab_contents()->controller().LoadURL( + tab_->tab_contents()->GetController().LoadURL( GetDialogContentURL(), content::Referrer(), content::PAGE_TRANSITION_START_PAGE, diff --git a/chrome/browser/ui/gtk/location_bar_view_gtk.cc b/chrome/browser/ui/gtk/location_bar_view_gtk.cc index dbc4c28..c5d94e0 100644 --- a/chrome/browser/ui/gtk/location_bar_view_gtk.cc +++ b/chrome/browser/ui/gtk/location_bar_view_gtk.cc @@ -1044,7 +1044,7 @@ gboolean LocationBarViewGtk::OnIconReleased(GtkWidget* sender, if (event->x == 0 && event->y == 0) return FALSE; - NavigationEntry* nav_entry = tab->controller().GetActiveEntry(); + NavigationEntry* nav_entry = tab->GetController().GetActiveEntry(); if (!nav_entry) { NOTREACHED(); return FALSE; diff --git a/chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc b/chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc index 4c588bf..475e0cf 100644 --- a/chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc +++ b/chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc @@ -348,7 +348,7 @@ void BalloonViewImpl::Update() { DCHECK(html_contents_.get()) << "BalloonView::Update called before Show"; if (!html_contents_->tab_contents()) return; - html_contents_->tab_contents()->controller().LoadURL( + html_contents_->tab_contents()->GetController().LoadURL( balloon_->notification().content_url(), content::Referrer(), content::PAGE_TRANSITION_LINK, std::string()); } diff --git a/chrome/browser/ui/gtk/web_intent_picker_gtk.cc b/chrome/browser/ui/gtk/web_intent_picker_gtk.cc index 9f0067b..0cee824 100644 --- a/chrome/browser/ui/gtk/web_intent_picker_gtk.cc +++ b/chrome/browser/ui/gtk/web_intent_picker_gtk.cc @@ -253,7 +253,7 @@ TabContents* WebIntentPickerGtk::SetInlineDisposition(const GURL& url) { tab_contents_container_.reset(new TabContentsContainerGtk(NULL)); tab_contents_container_->SetTab(inline_disposition_tab_contents_.get()); - inline_disposition_tab_contents_->tab_contents()->controller().LoadURL( + inline_disposition_tab_contents_->tab_contents()->GetController().LoadURL( url, content::Referrer(), content::PAGE_TRANSITION_START_PAGE, std::string()); diff --git a/chrome/browser/ui/intents/web_intent_picker_controller.cc b/chrome/browser/ui/intents/web_intent_picker_controller.cc index 39ebd40..d71479b 100644 --- a/chrome/browser/ui/intents/web_intent_picker_controller.cc +++ b/chrome/browser/ui/intents/web_intent_picker_controller.cc @@ -116,7 +116,7 @@ WebIntentPickerController::WebIntentPickerController( picker_(NULL), pending_async_count_(0), service_tab_(NULL) { - NavigationController* controller = &wrapper->tab_contents()->controller(); + NavigationController* controller = &wrapper->tab_contents()->GetController(); registrar_.Add(this, content::NOTIFICATION_LOAD_START, content::Source<NavigationController>(controller)); registrar_.Add(this, content::NOTIFICATION_TAB_CLOSING, @@ -213,7 +213,7 @@ void WebIntentPickerController::OnSendReturnMessage() { if (service_tab_) { int index = TabStripModel::kNoTab; Browser* browser = Browser::GetBrowserForController( - &service_tab_->controller(), &index); + &service_tab_->GetController(), &index); if (browser) { browser->tabstrip_model()->CloseTabContentsAt( index, TabStripModel::CLOSE_CREATE_HISTORICAL_TAB); diff --git a/chrome/browser/ui/login/login_prompt.cc b/chrome/browser/ui/login/login_prompt.cc index ed351c1..09c76f9 100644 --- a/chrome/browser/ui/login/login_prompt.cc +++ b/chrome/browser/ui/login/login_prompt.cc @@ -282,7 +282,7 @@ void LoginHandler::NotifyAuthNeeded() { TabContents* requesting_contents = GetTabContentsForLogin(); if (requesting_contents) - controller = &requesting_contents->controller(); + controller = &requesting_contents->GetController(); LoginNotificationDetails details(this); @@ -301,7 +301,7 @@ void LoginHandler::NotifyAuthCancelled() { TabContents* requesting_contents = GetTabContentsForLogin(); if (requesting_contents) - controller = &requesting_contents->controller(); + controller = &requesting_contents->GetController(); LoginNotificationDetails details(this); @@ -321,7 +321,7 @@ void LoginHandler::NotifyAuthSupplied(const string16& username, content::NotificationService* service = content::NotificationService::current(); - NavigationController* controller = &requesting_contents->controller(); + NavigationController* controller = &requesting_contents->GetController(); AuthSuppliedLoginNotificationDetails details(this, username, password); service->Notify( diff --git a/chrome/browser/ui/login/login_prompt_browsertest.cc b/chrome/browser/ui/login/login_prompt_browsertest.cc index 5917fc7..ba8dcea 100644 --- a/chrome/browser/ui/login/login_prompt_browsertest.cc +++ b/chrome/browser/ui/login/login_prompt_browsertest.cc @@ -241,7 +241,7 @@ IN_PROC_BROWSER_TEST_F(LoginPromptBrowserTest, PrefetchAuthCancels) { TabContentsWrapper* contents = browser()->GetSelectedTabContentsWrapper(); ASSERT_TRUE(contents); - NavigationController* controller = &contents->tab_contents()->controller(); + NavigationController* controller = &contents->tab_contents()->GetController(); LoginPromptBrowserTestObserver observer; observer.Register(content::Source<NavigationController>(controller)); @@ -267,7 +267,7 @@ IN_PROC_BROWSER_TEST_F(LoginPromptBrowserTest, TestCancelAuth) { browser()->GetSelectedTabContentsWrapper(); ASSERT_TRUE(contents); - NavigationController* controller = &contents->tab_contents()->controller(); + NavigationController* controller = &contents->tab_contents()->GetController(); LoginPromptBrowserTestObserver observer; observer.Register(content::Source<NavigationController>(controller)); @@ -362,7 +362,7 @@ IN_PROC_BROWSER_TEST_F(LoginPromptBrowserTest, MultipleRealmCancellation) { browser()->GetSelectedTabContentsWrapper(); ASSERT_TRUE(contents); - NavigationController* controller = &contents->tab_contents()->controller(); + NavigationController* controller = &contents->tab_contents()->GetController(); LoginPromptBrowserTestObserver observer; observer.Register(content::Source<NavigationController>(controller)); @@ -414,7 +414,7 @@ IN_PROC_BROWSER_TEST_F(LoginPromptBrowserTest, MultipleRealmConfirmation) { browser()->GetSelectedTabContentsWrapper(); ASSERT_TRUE(contents); - NavigationController* controller = &contents->tab_contents()->controller(); + NavigationController* controller = &contents->tab_contents()->GetController(); LoginPromptBrowserTestObserver observer; observer.Register(content::Source<NavigationController>(controller)); @@ -466,7 +466,7 @@ IN_PROC_BROWSER_TEST_F(LoginPromptBrowserTest, IncorrectConfirmation) { browser()->GetSelectedTabContentsWrapper(); ASSERT_TRUE(contents); - NavigationController* controller = &contents->tab_contents()->controller(); + NavigationController* controller = &contents->tab_contents()->GetController(); LoginPromptBrowserTestObserver observer; observer.Register(content::Source<NavigationController>(controller)); @@ -537,7 +537,7 @@ IN_PROC_BROWSER_TEST_F(LoginPromptBrowserTest, NoLoginPromptForFavicon) { browser()->GetSelectedTabContentsWrapper(); ASSERT_TRUE(contents); - NavigationController* controller = &contents->tab_contents()->controller(); + NavigationController* controller = &contents->tab_contents()->GetController(); LoginPromptBrowserTestObserver observer; observer.Register(content::Source<NavigationController>(controller)); @@ -592,7 +592,7 @@ IN_PROC_BROWSER_TEST_F(LoginPromptBrowserTest, BlockCrossdomainPrompt) { TabContentsWrapper* contents = browser()->GetSelectedTabContentsWrapper(); ASSERT_TRUE(contents); - NavigationController* controller = &contents->tab_contents()->controller(); + NavigationController* controller = &contents->tab_contents()->GetController(); LoginPromptBrowserTestObserver observer; observer.Register(content::Source<NavigationController>(controller)); @@ -658,7 +658,7 @@ IN_PROC_BROWSER_TEST_F(LoginPromptBrowserTest, SupplyRedundantAuths) { browser()->GetSelectedTabContentsWrapper(); ASSERT_TRUE(contents_1); NavigationController* controller_1 = - &contents_1->tab_contents()->controller(); + &contents_1->tab_contents()->GetController(); // Open a new tab. ui_test_utils::NavigateToURLWithDisposition( @@ -673,7 +673,7 @@ IN_PROC_BROWSER_TEST_F(LoginPromptBrowserTest, SupplyRedundantAuths) { ASSERT_TRUE(contents_2); ASSERT_NE(contents_1, contents_2); NavigationController* controller_2 = - &contents_2->tab_contents()->controller(); + &contents_2->tab_contents()->GetController(); LoginPromptBrowserTestObserver observer; observer.Register(content::Source<NavigationController>(controller_1)); @@ -726,7 +726,7 @@ IN_PROC_BROWSER_TEST_F(LoginPromptBrowserTest, CancelRedundantAuths) { browser()->GetSelectedTabContentsWrapper(); ASSERT_TRUE(contents_1); NavigationController* controller_1 = - &contents_1->tab_contents()->controller(); + &contents_1->tab_contents()->GetController(); // Open a new tab. ui_test_utils::NavigateToURLWithDisposition( @@ -741,7 +741,7 @@ IN_PROC_BROWSER_TEST_F(LoginPromptBrowserTest, CancelRedundantAuths) { ASSERT_TRUE(contents_2); ASSERT_NE(contents_1, contents_2); NavigationController* controller_2 = - &contents_2->tab_contents()->controller(); + &contents_2->tab_contents()->GetController(); LoginPromptBrowserTestObserver observer; observer.Register(content::Source<NavigationController>(controller_1)); @@ -794,7 +794,7 @@ IN_PROC_BROWSER_TEST_F(LoginPromptBrowserTest, TabContentsWrapper* contents = browser()->GetSelectedTabContentsWrapper(); ASSERT_TRUE(contents); - NavigationController* controller = &contents->tab_contents()->controller(); + NavigationController* controller = &contents->tab_contents()->GetController(); // Open an incognito window. Browser* browser_incognito = CreateIncognitoBrowser(); @@ -805,7 +805,7 @@ IN_PROC_BROWSER_TEST_F(LoginPromptBrowserTest, ASSERT_TRUE(contents_incognito); ASSERT_NE(contents, contents_incognito); NavigationController* controller_incognito = - &contents_incognito->tab_contents()->controller(); + &contents_incognito->tab_contents()->GetController(); LoginPromptBrowserTestObserver observer; observer.Register(content::Source<NavigationController>(controller)); diff --git a/chrome/browser/ui/pdf/pdf_browsertest.cc b/chrome/browser/ui/pdf/pdf_browsertest.cc index 0061627..1d9d768 100644 --- a/chrome/browser/ui/pdf/pdf_browsertest.cc +++ b/chrome/browser/ui/pdf/pdf_browsertest.cc @@ -282,7 +282,7 @@ IN_PROC_BROWSER_TEST_F(PDFBrowserTest, FLAKY_SLOW_Loading) { ASSERT_TRUE(pdf_test_server()->Start()); NavigationController* controller = - &(browser()->GetSelectedTabContents()->controller()); + &(browser()->GetSelectedTabContents()->GetController()); content::NotificationRegistrar registrar; registrar.Add(this, content::NOTIFICATION_LOAD_STOP, @@ -348,7 +348,7 @@ IN_PROC_BROWSER_TEST_F(PDFBrowserTest, MAYBE_OnLoadAndReload) { ui_test_utils::WindowedNotificationObserver observer( content::NOTIFICATION_LOAD_STOP, content::Source<NavigationController>( - &browser()->GetSelectedTabContents()->controller())); + &browser()->GetSelectedTabContents()->GetController())); ASSERT_TRUE(ui_test_utils::ExecuteJavaScript( browser()->GetSelectedTabContents()->GetRenderViewHost(), std::wstring(), diff --git a/chrome/browser/ui/search_engines/search_engine_tab_helper.cc b/chrome/browser/ui/search_engines/search_engine_tab_helper.cc index 278008c..5ba0c11 100644 --- a/chrome/browser/ui/search_engines/search_engine_tab_helper.cc +++ b/chrome/browser/ui/search_engines/search_engine_tab_helper.cc @@ -86,7 +86,7 @@ void SearchEngineTabHelper::OnPageHasOSDD( return; } - const NavigationController& controller = tab_contents()->controller(); + const NavigationController& controller = tab_contents()->GetController(); const NavigationEntry* entry = controller.GetLastCommittedEntry(); DCHECK(entry); @@ -136,7 +136,7 @@ void SearchEngineTabHelper::GenerateKeywordIfNecessary( if (profile->IsOffTheRecord()) return; - const NavigationController& controller = tab_contents()->controller(); + const NavigationController& controller = tab_contents()->GetController(); int last_index = controller.last_committed_entry_index(); // When there was no previous page, the last index will be 0. This is // normally due to a form submit that opened in a new tab. diff --git a/chrome/browser/ui/sync/tab_contents_wrapper_synced_tab_delegate.cc b/chrome/browser/ui/sync/tab_contents_wrapper_synced_tab_delegate.cc index 65d66a5..4e9cee3 100644 --- a/chrome/browser/ui/sync/tab_contents_wrapper_synced_tab_delegate.cc +++ b/chrome/browser/ui/sync/tab_contents_wrapper_synced_tab_delegate.cc @@ -46,28 +46,29 @@ const std::string& TabContentsWrapperSyncedTabDelegate::GetExtensionAppId() } int TabContentsWrapperSyncedTabDelegate::GetCurrentEntryIndex() const { - return tab_contents_wrapper_->tab_contents()->controller(). + return tab_contents_wrapper_->tab_contents()->GetController(). GetCurrentEntryIndex(); } int TabContentsWrapperSyncedTabDelegate::GetEntryCount() const { - return tab_contents_wrapper_->tab_contents()->controller().entry_count(); + return tab_contents_wrapper_->tab_contents()->GetController().entry_count(); } int TabContentsWrapperSyncedTabDelegate::GetPendingEntryIndex() const { - return tab_contents_wrapper_->tab_contents()->controller(). + return tab_contents_wrapper_->tab_contents()->GetController(). pending_entry_index(); } NavigationEntry* TabContentsWrapperSyncedTabDelegate::GetPendingEntry() const { - return tab_contents_wrapper_->tab_contents()->controller().pending_entry(); + return tab_contents_wrapper_->tab_contents()->GetController().pending_entry(); } NavigationEntry* TabContentsWrapperSyncedTabDelegate::GetEntryAtIndex(int i) const { - return tab_contents_wrapper_->tab_contents()->controller().GetEntryAtIndex(i); + return + tab_contents_wrapper_->tab_contents()->GetController().GetEntryAtIndex(i); } NavigationEntry* TabContentsWrapperSyncedTabDelegate::GetActiveEntry() const { - return tab_contents_wrapper_->tab_contents()->controller().GetActiveEntry(); + return tab_contents_wrapper_->tab_contents()->GetController().GetActiveEntry(); } diff --git a/chrome/browser/ui/tab_modal_confirm_dialog_delegate.cc b/chrome/browser/ui/tab_modal_confirm_dialog_delegate.cc index f2b3590..4b97bb4 100644 --- a/chrome/browser/ui/tab_modal_confirm_dialog_delegate.cc +++ b/chrome/browser/ui/tab_modal_confirm_dialog_delegate.cc @@ -15,7 +15,7 @@ TabModalConfirmDialogDelegate::TabModalConfirmDialogDelegate( TabContents* tab_contents) : window_(NULL), closing_(false) { - NavigationController* controller = &tab_contents->controller(); + NavigationController* controller = &tab_contents->GetController(); registrar_.Add(this, content::NOTIFICATION_LOAD_START, content::Source<NavigationController>(controller)); registrar_.Add(this, content::NOTIFICATION_TAB_CLOSING, diff --git a/chrome/browser/ui/toolbar/back_forward_menu_model.cc b/chrome/browser/ui/toolbar/back_forward_menu_model.cc index 0fdd356..fbea791 100644 --- a/chrome/browser/ui/toolbar/back_forward_menu_model.cc +++ b/chrome/browser/ui/toolbar/back_forward_menu_model.cc @@ -289,10 +289,10 @@ int BackForwardMenuModel::GetHistoryItemCount() const { if (model_type_ == FORWARD_MENU) { // Only count items from n+1 to end (if n is current entry) - items = contents->controller().entry_count() - - contents->controller().GetCurrentEntryIndex() - 1; + items = contents->GetController().entry_count() - + contents->GetController().GetCurrentEntryIndex() - 1; } else { - items = contents->controller().GetCurrentEntryIndex(); + items = contents->GetController().GetCurrentEntryIndex(); } if (items > kMaxHistoryItems) @@ -307,7 +307,7 @@ int BackForwardMenuModel::GetChapterStopCount(int history_items) const { TabContents* contents = GetTabContents(); int chapter_stops = 0; - int current_entry = contents->controller().GetCurrentEntryIndex(); + int current_entry = contents->GetController().GetCurrentEntryIndex(); if (history_items == kMaxHistoryItems) { int chapter_id = current_entry; @@ -331,7 +331,7 @@ int BackForwardMenuModel::GetChapterStopCount(int history_items) const { int BackForwardMenuModel::GetIndexOfNextChapterStop(int start_from, bool forward) const { TabContents* contents = GetTabContents(); - NavigationController& controller = contents->controller(); + NavigationController& controller = contents->GetController(); int max_count = controller.entry_count(); if (start_from < 0 || start_from >= max_count) @@ -383,7 +383,7 @@ int BackForwardMenuModel::FindChapterStop(int offset, offset *= -1; TabContents* contents = GetTabContents(); - int entry = contents->controller().GetCurrentEntryIndex() + offset; + int entry = contents->GetController().GetCurrentEntryIndex() + offset; for (int i = 0; i < skip + 1; i++) entry = GetIndexOfNextChapterStop(entry, forward); @@ -417,10 +417,10 @@ int BackForwardMenuModel::MenuIndexToNavEntryIndex(int index) const { // Convert anything above the History items separator. if (index < history_items) { if (model_type_ == FORWARD_MENU) { - index += contents->controller().GetCurrentEntryIndex() + 1; + index += contents->GetController().GetCurrentEntryIndex() + 1; } else { // Back menu is reverse. - index = contents->controller().GetCurrentEntryIndex() - (index + 1); + index = contents->GetController().GetCurrentEntryIndex() - (index + 1); } return index; } @@ -440,7 +440,7 @@ int BackForwardMenuModel::MenuIndexToNavEntryIndex(int index) const { NavigationEntry* BackForwardMenuModel::GetNavigationEntry(int index) const { int controller_index = MenuIndexToNavEntryIndex(index); - NavigationController& controller = GetTabContents()->controller(); + NavigationController& controller = GetTabContents()->GetController(); if (controller_index >= 0 && controller_index < controller.entry_count()) return controller.GetEntryAtIndex(controller_index); diff --git a/chrome/browser/ui/toolbar/toolbar_model.cc b/chrome/browser/ui/toolbar/toolbar_model.cc index f2425ef..3810495 100644 --- a/chrome/browser/ui/toolbar/toolbar_model.cc +++ b/chrome/browser/ui/toolbar/toolbar_model.cc @@ -169,5 +169,5 @@ NavigationController* ToolbarModel::GetNavigationController() const { // toolbar during window creation (i.e. before any tabs have been added // to the window). TabContents* current_tab = browser_->GetSelectedTabContents(); - return current_tab ? ¤t_tab->controller() : NULL; + return current_tab ? ¤t_tab->GetController() : NULL; } diff --git a/chrome/browser/ui/toolbar/toolbar_model_unittest.cc b/chrome/browser/ui/toolbar/toolbar_model_unittest.cc index 349c3dc..5d321bc 100644 --- a/chrome/browser/ui/toolbar/toolbar_model_unittest.cc +++ b/chrome/browser/ui/toolbar/toolbar_model_unittest.cc @@ -29,7 +29,7 @@ class ToolbarModelTest : public BrowserWithTestWindowTest { browser()->toolbar_model()->GetText()); // Check after commit. - CommitPendingLoad(&contents->controller()); + CommitPendingLoad(&contents->GetController()); EXPECT_EQ(should_display, browser()->toolbar_model()->ShouldDisplayURL()); EXPECT_EQ(ASCIIToUTF16(expected_text), browser()->toolbar_model()->GetText()); diff --git a/chrome/browser/ui/views/constrained_html_delegate_gtk.cc b/chrome/browser/ui/views/constrained_html_delegate_gtk.cc index ea6200d..fc3f167 100644 --- a/chrome/browser/ui/views/constrained_html_delegate_gtk.cc +++ b/chrome/browser/ui/views/constrained_html_delegate_gtk.cc @@ -103,10 +103,10 @@ ConstrainedHtmlDelegateGtk::ConstrainedHtmlDelegateGtk( // Set |this| as a property so the ConstrainedHtmlUI can retrieve it. ConstrainedHtmlUI::GetPropertyAccessor().SetProperty( tab_contents->GetPropertyBag(), this); - tab_contents->controller().LoadURL(delegate->GetDialogContentURL(), - content::Referrer(), - content::PAGE_TRANSITION_START_PAGE, - std::string()); + tab_contents->GetController().LoadURL(delegate->GetDialogContentURL(), + content::Referrer(), + content::PAGE_TRANSITION_START_PAGE, + std::string()); views::Widget::InitParams params(views::Widget::InitParams::TYPE_CONTROL); params.native_widget = this; diff --git a/chrome/browser/ui/views/constrained_html_delegate_views.cc b/chrome/browser/ui/views/constrained_html_delegate_views.cc index c41dd95..64a29fb 100644 --- a/chrome/browser/ui/views/constrained_html_delegate_views.cc +++ b/chrome/browser/ui/views/constrained_html_delegate_views.cc @@ -115,10 +115,10 @@ ConstrainedHtmlDelegateViews::ConstrainedHtmlDelegateViews( // Set |this| as a property so the ConstrainedHtmlUI can retrieve it. ConstrainedHtmlUI::GetPropertyAccessor().SetProperty( html_tab_contents_->tab_contents()->GetPropertyBag(), this); - tab_contents->controller().LoadURL(delegate->GetDialogContentURL(), - content::Referrer(), - content::PAGE_TRANSITION_START_PAGE, - std::string()); + tab_contents->GetController().LoadURL(delegate->GetDialogContentURL(), + content::Referrer(), + content::PAGE_TRANSITION_START_PAGE, + std::string()); } ConstrainedHtmlDelegateViews::~ConstrainedHtmlDelegateViews() { diff --git a/chrome/browser/ui/views/dom_view.cc b/chrome/browser/ui/views/dom_view.cc index 73482a5..5854f6f5 100644 --- a/chrome/browser/ui/views/dom_view.cc +++ b/chrome/browser/ui/views/dom_view.cc @@ -52,7 +52,7 @@ TabContents* DOMView::CreateTabContents(Profile* profile, void DOMView::LoadURL(const GURL& url) { DCHECK(initialized_); - dom_contents_->tab_contents()->controller().LoadURL( + dom_contents_->tab_contents()->GetController().LoadURL( url, content::Referrer(), content::PAGE_TRANSITION_START_PAGE, std::string()); } diff --git a/chrome/browser/ui/views/location_bar/click_handler.cc b/chrome/browser/ui/views/location_bar/click_handler.cc index 710ec09..d94c83f 100644 --- a/chrome/browser/ui/views/location_bar/click_handler.cc +++ b/chrome/browser/ui/views/location_bar/click_handler.cc @@ -26,7 +26,7 @@ void ClickHandler::OnMouseReleased(const views::MouseEvent& event) { return; TabContents* tab = location_bar_->GetTabContentsWrapper()->tab_contents(); - NavigationEntry* nav_entry = tab->controller().GetActiveEntry(); + NavigationEntry* nav_entry = tab->GetController().GetActiveEntry(); if (!nav_entry) { NOTREACHED(); return; diff --git a/chrome/browser/ui/views/notifications/balloon_view.cc b/chrome/browser/ui/views/notifications/balloon_view.cc index c4b7543..311c877 100644 --- a/chrome/browser/ui/views/notifications/balloon_view.cc +++ b/chrome/browser/ui/views/notifications/balloon_view.cc @@ -232,7 +232,7 @@ void BalloonViewImpl::Update() { DCHECK(html_contents_.get()) << "BalloonView::Update called before Show"; if (!html_contents_->tab_contents()) return; - html_contents_->tab_contents()->controller().LoadURL( + html_contents_->tab_contents()->GetController().LoadURL( balloon_->notification().content_url(), content::Referrer(), content::PAGE_TRANSITION_LINK, std::string()); } diff --git a/chrome/browser/ui/views/sad_tab_view.cc b/chrome/browser/ui/views/sad_tab_view.cc index 046a794..cbf5dcc 100644 --- a/chrome/browser/ui/views/sad_tab_view.cc +++ b/chrome/browser/ui/views/sad_tab_view.cc @@ -76,7 +76,7 @@ void SadTabView::LinkClicked(views::Link* source, int event_flags) { false /* is renderer initiated */)); } else if (source == feedback_link_) { browser::ShowHtmlBugReportView( - Browser::GetBrowserForController(&tab_contents_->controller(), NULL), + Browser::GetBrowserForController(&tab_contents_->GetController(), NULL), l10n_util::GetStringUTF8(IDS_KILLED_TAB_FEEDBACK_MESSAGE), userfeedback::ChromeOsData_ChromeOsCategory_CRASH); } @@ -86,7 +86,7 @@ void SadTabView::ButtonPressed(views::Button* source, const views::Event& event) { DCHECK(tab_contents_); DCHECK(source == reload_button_); - tab_contents_->controller().Reload(true); + tab_contents_->GetController().Reload(true); } void SadTabView::Layout() { diff --git a/chrome/browser/ui/views/tab_contents/tab_contents_container.cc b/chrome/browser/ui/views/tab_contents/tab_contents_container.cc index 1e89da1..8604952 100644 --- a/chrome/browser/ui/views/tab_contents/tab_contents_container.cc +++ b/chrome/browser/ui/views/tab_contents/tab_contents_container.cc @@ -133,10 +133,10 @@ bool TabContentsContainer::OnMousePressed(const views::MouseEvent& event) { } switch (button) { case 8: - tab_contents_->controller().GoBack(); + tab_contents_->GetController().GoBack(); return true; case 9: - tab_contents_->controller().GoForward(); + tab_contents_->GetController().GoForward(); return true; } @@ -163,7 +163,7 @@ void TabContentsContainer::AddObservers() { registrar_.Add( this, content::NOTIFICATION_RENDER_VIEW_HOST_CHANGED, - content::Source<NavigationController>(&tab_contents_->controller())); + content::Source<NavigationController>(&tab_contents_->GetController())); registrar_.Add( this, diff --git a/chrome/browser/ui/web_applications/web_app_ui.cc b/chrome/browser/ui/web_applications/web_app_ui.cc index 225fd85c..5d08a2f 100644 --- a/chrome/browser/ui/web_applications/web_app_ui.cc +++ b/chrome/browser/ui/web_applications/web_app_ui.cc @@ -104,7 +104,7 @@ UpdateShortcutWorker::UpdateShortcutWorker(TabContentsWrapper* tab_contents) this, content::NOTIFICATION_TAB_CLOSING, content::Source<NavigationController>( - &tab_contents_->tab_contents()->controller())); + &tab_contents_->tab_contents()->GetController())); } void UpdateShortcutWorker::Run() { @@ -118,7 +118,7 @@ void UpdateShortcutWorker::Observe( const content::NotificationDetails& details) { if (type == content::NOTIFICATION_TAB_CLOSING && content::Source<NavigationController>(source).ptr() == - &tab_contents_->tab_contents()->controller()) { + &tab_contents_->tab_contents()->GetController()) { // Underlying tab is closing. tab_contents_ = NULL; } diff --git a/chrome/browser/ui/webui/active_downloads_ui.cc b/chrome/browser/ui/webui/active_downloads_ui.cc index c886758..f59af2a 100644 --- a/chrome/browser/ui/webui/active_downloads_ui.cc +++ b/chrome/browser/ui/webui/active_downloads_ui.cc @@ -220,7 +220,7 @@ void ActiveDownloadsHandler::PlayMediaFile(const ListValue* args) { FilePath file_path(UTF16ToUTF8(ExtractStringValue(args))); Browser* browser = Browser::GetBrowserForController( - &tab_contents_->controller(), NULL); + &tab_contents_->GetController(), NULL); MediaPlayer* mediaplayer = MediaPlayer::GetInstance(); mediaplayer->PopupMediaPlayer(browser); mediaplayer->ForcePlayMediaFile(profile_, file_path); diff --git a/chrome/browser/ui/webui/bug_report_ui.cc b/chrome/browser/ui/webui/bug_report_ui.cc index 1767709..ca36cca 100644 --- a/chrome/browser/ui/webui/bug_report_ui.cc +++ b/chrome/browser/ui/webui/bug_report_ui.cc @@ -356,8 +356,8 @@ WebUIMessageHandler* BugReportHandler::Attach(WebUI* web_ui) { bool BugReportHandler::Init() { std::string page_url; - if (tab_->controller().GetActiveEntry()) { - page_url = tab_->controller().GetActiveEntry()->url().spec(); + if (tab_->GetController().GetActiveEntry()) { + page_url = tab_->GetController().GetActiveEntry()->url().spec(); } std::string params = page_url.substr(strlen(chrome::kChromeUIBugReportURL)); diff --git a/chrome/browser/ui/webui/cloud_print_signin_dialog.cc b/chrome/browser/ui/webui/cloud_print_signin_dialog.cc index 0da4fb2..5742e18 100644 --- a/chrome/browser/ui/webui/cloud_print_signin_dialog.cc +++ b/chrome/browser/ui/webui/cloud_print_signin_dialog.cc @@ -60,7 +60,8 @@ CloudPrintSigninFlowHandler::CloudPrintSigninFlowHandler( void CloudPrintSigninFlowHandler::RegisterMessages() { if (web_ui_ && web_ui_->tab_contents()) { - NavigationController* controller = &web_ui_->tab_contents()->controller(); + NavigationController* controller = + &web_ui_->tab_contents()->GetController(); NavigationEntry* pending_entry = controller->pending_entry(); if (pending_entry) pending_entry->set_url(CloudPrintURL( diff --git a/chrome/browser/ui/webui/ntp/recently_closed_tabs_handler.cc b/chrome/browser/ui/webui/ntp/recently_closed_tabs_handler.cc index 575cf7d..24cea89 100644 --- a/chrome/browser/ui/webui/ntp/recently_closed_tabs_handler.cc +++ b/chrome/browser/ui/webui/ntp/recently_closed_tabs_handler.cc @@ -62,7 +62,7 @@ RecentlyClosedTabsHandler::~RecentlyClosedTabsHandler() { void RecentlyClosedTabsHandler::HandleReopenTab(const ListValue* args) { TabRestoreServiceDelegate* delegate = TabRestoreServiceDelegate::FindDelegateForController( - &web_ui_->tab_contents()->controller(), NULL); + &web_ui_->tab_contents()->GetController(), NULL); if (!delegate || !tab_restore_service_) return; diff --git a/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc index e0410be..06bfbc4 100644 --- a/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc +++ b/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc @@ -212,7 +212,7 @@ void CrosLanguageOptionsHandler::RestartCallback(const ListValue* args) { content::RecordAction(UserMetricsAction("LanguageOptions_SignOut")); Browser* browser = Browser::GetBrowserForController( - &web_ui_->tab_contents()->controller(), NULL); + &web_ui_->tab_contents()->GetController(), NULL); if (browser) browser->ExecuteCommand(IDC_EXIT); } diff --git a/chrome/browser/ui/webui/options2/chromeos/cros_language_options_handler2.cc b/chrome/browser/ui/webui/options2/chromeos/cros_language_options_handler2.cc index b3bbcc8..9aeedaf 100644 --- a/chrome/browser/ui/webui/options2/chromeos/cros_language_options_handler2.cc +++ b/chrome/browser/ui/webui/options2/chromeos/cros_language_options_handler2.cc @@ -214,7 +214,7 @@ void CrosLanguageOptionsHandler::RestartCallback(const ListValue* args) { content::RecordAction(UserMetricsAction("LanguageOptions_SignOut")); Browser* browser = Browser::GetBrowserForController( - &web_ui_->tab_contents()->controller(), NULL); + &web_ui_->tab_contents()->GetController(), NULL); if (browser) browser->ExecuteCommand(IDC_EXIT); } diff --git a/chrome/browser/ui/webui/print_preview_handler.cc b/chrome/browser/ui/webui/print_preview_handler.cc index 4161476..10b9f22 100644 --- a/chrome/browser/ui/webui/print_preview_handler.cc +++ b/chrome/browser/ui/webui/print_preview_handler.cc @@ -312,7 +312,7 @@ void PrintPreviewHandler::HandleGetPreview(const ListValue* args) { initiator_tab->tab_contents()->GetTitle()); std::string url; NavigationEntry* entry = - initiator_tab->tab_contents()->controller().GetActiveEntry(); + initiator_tab->tab_contents()->GetController().GetActiveEntry(); if (entry) url = entry->virtual_url().spec(); settings->SetString(printing::kSettingHeaderFooterURL, url); diff --git a/chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc b/chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc index b535894..136c507 100644 --- a/chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc +++ b/chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc @@ -90,12 +90,12 @@ WebUIMessageHandler* SyncPromoHandler::Attach(WebUI* web_ui) { prefs_ = Profile::FromWebUI(web_ui)->GetPrefs(); DCHECK(prefs_); // Ignore events from view-source:chrome://syncpromo. - if (!web_ui->tab_contents()->controller().GetActiveEntry()-> + if (!web_ui->tab_contents()->GetController().GetActiveEntry()-> IsViewSourceMode()) { // Listen to see if the tab we're in gets closed. registrar_.Add(this, content::NOTIFICATION_TAB_CLOSING, content::Source<NavigationController>( - &web_ui->tab_contents()->controller())); + &web_ui->tab_contents()->GetController())); // Listen to see if the window we're in gets closed. registrar_.Add(this, chrome::NOTIFICATION_BROWSER_CLOSING, content::NotificationService::AllSources()); diff --git a/chrome/browser/ui/webui/web_ui_browsertest.cc b/chrome/browser/ui/webui/web_ui_browsertest.cc index 7544751..e7cdc64 100644 --- a/chrome/browser/ui/webui/web_ui_browsertest.cc +++ b/chrome/browser/ui/webui/web_ui_browsertest.cc @@ -179,7 +179,7 @@ void WebUIBrowserTest::BrowsePreload(const GURL& browse_to) { TestNavigationObserver navigation_observer( content::Source<NavigationController>( &browser()->GetSelectedTabContentsWrapper()->tab_contents()-> - controller()), + GetController()), this, 1); browser::NavigateParams params( browser(), GURL(browse_to), content::PAGE_TRANSITION_TYPED); diff --git a/chrome/browser/ui/webui/web_ui_unittest.cc b/chrome/browser/ui/webui/web_ui_unittest.cc index eeb3d0d..40f0eee 100644 --- a/chrome/browser/ui/webui/web_ui_unittest.cc +++ b/chrome/browser/ui/webui/web_ui_unittest.cc @@ -26,7 +26,7 @@ class WebUITest : public TabContentsWrapperTestHarness { // values. This must be increasing for the life of the tests. static void DoNavigationTest(TabContentsWrapper* wrapper, int page_id) { TabContents* contents = wrapper->tab_contents(); - NavigationController* controller = &contents->controller(); + NavigationController* controller = &contents->GetController(); // Start a pending load. GURL new_tab_url(chrome::kChromeUINewTabURL); @@ -169,7 +169,7 @@ TEST_F(WebUITest, FocusOnNavigate) { TabContentsForFocusTest* tc = new TabContentsForFocusTest( contents()->browser_context(), SiteInstance::CreateSiteInstance(contents()->browser_context())); - tc->controller().CopyStateFrom(controller()); + tc->GetController().CopyStateFrom(controller()); SetContents(tc); int page_id = 200; |