diff options
author | sky@google.com <sky@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-29 23:38:06 +0000 |
---|---|---|
committer | sky@google.com <sky@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-29 23:38:06 +0000 |
commit | 7f856bee73ffdccdbbbbbab4cb79185290d38359 (patch) | |
tree | a837328e08a113abdc70b2fc0ae2f2a4a3f804eb /chrome/browser/views/bookmark_bar_view.h | |
parent | 281fe14063dd8fb81cea102f5abb7b82f407c3d1 (diff) | |
download | chromium_src-7f856bee73ffdccdbbbbbab4cb79185290d38359.zip chromium_src-7f856bee73ffdccdbbbbbab4cb79185290d38359.tar.gz chromium_src-7f856bee73ffdccdbbbbbab4cb79185290d38359.tar.bz2 |
First cut at the bookmark manager. There are still a fair number of
rough edges, but I'm at a good point where I want to land what I
have. Here's what is left:
. Flicker on show, likely the result of restoring window placement.
. tree flickers when dragging splitter.
. table/tree need to autoscroll when drop cursor held at bottom of view.
. prompts for deleting.
. When you move an item the table snaps to the top, this is because
I'm sending out model changed. need a better notification.
. Operations in menu to add need to change selection.
. Remember split location.
I would have preferred to split this up into a couple of reviews, but
everything is intertwined now. Sorry.
BUG=674
TEST=don't test the bookmark manager yet, but make sure bookmark bar
still works.
Review URL: http://codereview.chromium.org/8197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4191 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/views/bookmark_bar_view.h')
-rw-r--r-- | chrome/browser/views/bookmark_bar_view.h | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/chrome/browser/views/bookmark_bar_view.h b/chrome/browser/views/bookmark_bar_view.h index 242a7f2..754d6b6 100644 --- a/chrome/browser/views/bookmark_bar_view.h +++ b/chrome/browser/views/bookmark_bar_view.h @@ -72,6 +72,10 @@ class BookmarkBarView : public views::View, explicit BookmarkBarView(Profile* profile, Browser* browser); virtual ~BookmarkBarView(); + // Toggles whether the bookmark bar is shown only on the new tab page or on + // all tabs. + static void ToggleWhenVisible(Profile* profile); + static void RegisterUserPrefs(PrefService* prefs); // Resets the profile. This removes any buttons for the current profile and @@ -81,6 +85,9 @@ class BookmarkBarView : public views::View, // Returns the current profile. Profile* GetProfile() { return profile_; } + // Returns the current browser. + Browser* browser() const { return browser_; } + // Sets the PageNavigator that is used when the user selects an entry on // the bookmark bar. void SetPageNavigator(PageNavigator* navigator); @@ -122,10 +129,6 @@ class BookmarkBarView : public views::View, // Returns the model. BookmarkModel* GetModel() { return model_; } - // Toggles whether the bookmark bar is shown only on the new tab page or on - // all tabs. - void ToggleWhenVisible(); - // Returns true if the bookmarks bar preference is set to 'always show', we // use this as a shorthand way of knowing what style of bar to draw (if the // pref is set to false but we're painting, then we must be on the new tab |